Re: [PATCH] idlestat: Replace asserts with proper error handlings

2014-11-26 Thread Tuukka Tikkanen
Hi, committing amended (see below). On Wed, Nov 26, 2014 at 10:15 AM, pi-cheng.chen wrote: > Replace asserts with displaying error messages and/or terminating program in a > controlled manner. Also refine some error handling paths. This description doesn't really tell what is wrong in the origi

Re: [PATCH IDLESTAT V2] clear few memory leaks

2014-10-24 Thread Tuukka Tikkanen
On Thu, Oct 9, 2014 at 2:36 PM, Sanjay Singh Rawat wrote: > Signed-off-by: Sanjay Singh Rawat > --- > idlestat.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/idlestat.c b/idlestat.c > index ab561c1..1266215 100644 > --- a/idlestat.c > +++ b/idlestat.c > @@ -460,9 +460,14 @@ stat

Re: [PATCH v3] idlestat: Allocate struct cpufreq_pstate dynamically

2014-10-22 Thread Tuukka Tikkanen
Hi, On Sat, Oct 4, 2014 at 7:33 AM, pi-cheng.chen wrote: > Initialize struct cpufreq_pstates with initial P-state of CPUs and allocate > struct cpufreq_pstate dynamically when parsing trace file to solve the issue > caused by missing "scaling_avaialable_freqs" attr when using intel_pstate > drive

Re: [PATCH v3] idlestat: Allocate struct cpufreq_pstate dynamically

2014-10-21 Thread Tuukka Tikkanen
On Tue, Oct 21, 2014 at 3:42 PM, Daniel Lezcano wrote: > On 10/04/2014 06:33 AM, pi-cheng.chen wrote: >> >> Initialize struct cpufreq_pstates with initial P-state of CPUs and >> allocate >> struct cpufreq_pstate dynamically when parsing trace file to solve the >> issue >> caused by missing "scalin

Re: [PATCH v2] Bug 351 - Display topology fo:r p-states and wakeups array

2014-10-07 Thread Tuukka Tikkanen
Hi, On Tue, Oct 7, 2014 at 12:49 PM, Howard Chen wrote: > Currently only the c-state is showing the cpu topology when displaying the > results. For the sake of consistency, we should also give the topology for > the p-states and the wakeups array. > > Before: > ---

Re: [PATCH IDLESTAT] clear few memory leaks

2014-10-07 Thread Tuukka Tikkanen
Hi, On Wed, Sep 17, 2014 at 1:20 PM, Sanjay Singh Rawat wrote: > Signed-off-by: Sanjay Singh Rawat > --- > > below are the leaks which this patch clears > > 72 bytes in 3 blocks are definitely lost in loss record 2 of 9 > at 0x4C2ABBD: malloc (vg_replace_malloc.c:296) > by 0x4C2CA8B: realloc (vg

Re: [PATCH] Bug 351 - Display topology for p-states and wakeups array

2014-10-06 Thread Tuukka Tikkanen
On Wed, Oct 1, 2014 at 11:12 AM, Howard Chen wrote: > From: Howard Chen Please review section 12 of https://www.kernel.org/doc/Documentation/SubmittingPatches on how to sign your work. Sections 13 and 14 might be useful to look at, too. Try to avoid adding Signed-off-by manually (note the typo i