On 02/28/2013 05:12 AM, Vikas Sajjan wrote:
Adds support for pinctrl to drm fimd
Signed-off-by: Leela Krishna Amudala
Signed-off-by: Vikas Sajjan
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd
Hi Laurent,
On 09/27/2012 12:29 PM, Laurent Pinchart wrote:
> On Thursday 27 September 2012 00:00:20 Sylwester Nawrocki wrote:
>> On 09/26/2012 10:32 PM, Mauro Carvalho Chehab wrote:
>>> Em Thu, 13 Sep 2012 12:02:14 +0100 Sangwook Lee escreveu:
>>>> This patch adds d
lements preview mode of the S5K4ECGX sensor.
>> capture (snapshot) operation, face detection are missing now.
>> Following controls are supported:
>> contrast/saturation/brightness/sharpness
>>
>> Signed-off-by: Sangwook Lee
>> Reviewed-by: Sylwester Nawrocki
On 09/10/2012 08:52 PM, Francesco Lavra wrote:
> On 09/10/2012 05:04 PM, Sylwester Nawrocki wrote:
>> On 09/09/2012 06:01 PM, Francesco Lavra wrote:
>>>> +static int s5k4ecgx_load_firmware(struct v4l2_subdev *sd)
>>>> +{
>>>> + const stru
ld be no problem with reading 2-byte register values.
We could change the data types of the register values from u16 to u32,
wasting some memory (there is approximately 3 000 records), so there is
no other data types in the file structure than u32. Or use a patch as
below. Not sure what's bet
now.
Following controls are supported:
contrast/saturation/brightness/sharpness
Signed-off-by: Sangwook Lee
Reviewed-by: Sylwester Nawrocki
Thanks for the update. I've done a few more minor fixes and improved
s_stream() subdev op handling, so it really enables/disables data
stream on the sen
etection are missing now.
> Following controls are supported:
> contrast/saturation/brightness/sharpness
>
> Signed-off-by: Sangwook Lee
> Cc: Sylwester Nawrocki
> Cc: Scott Bambrough
Overall it looks good, thank you for patiently addressing all my
comments ;) There might be some r
Hi Sangwook,
On 08/03/2012 04:24 PM, Sangwook Lee wrote:
> I was thinking about this, but this seems to be is a bit time-consuming
> because
> I have to do this just due to lack of s5k4ecgx hardware information.
> let me try it later once
> this patch is accepted.
I've converted this driver to u
Hi Sangwook,
On 08/20/2012 12:43 PM, Sangwook Lee wrote:
> On 20 August 2012 09:12, Sangwook Lee wrote:
>> On 19 August 2012 22:29, Sylwester Nawrocki
>> wrote:
>>> On 08/03/2012 04:24 PM, Sangwook Lee wrote:
>>>> I was thinking about this, but this
Hi Sangwook,
On 08/10/2012 04:14 PM, Sangwook Lee wrote:
> +/**
> + * parse_line() - parse a line from a s5k4ecgx fimware file
> + *
> + * This function uses tokens to separate the patterns.
> + * The form of the pattern should be as follows:
> + * - use only C-sytle comments
> + * - use one "toke
Hi Sangwook,
On 08/03/2012 05:05 PM, Sangwook Lee wrote:
>>> +/* configure 30 fps */
>>> +static const struct regval_list s5k4ecgx_fps_30[] = {
>>
>> It really depends on sensor master clock frequency (as specified
>> in FIMC driver platform data) and PLL setting what the resulting
>> frame rate w
Hi Sangwook,
On 08/03/2012 04:24 PM, Sangwook Lee wrote:
> Hi Sylwester
>
> Thank you for the review.
>
> On 2 August 2012 21:11, Sylwester Nawrocki
> wrote:
>> On 08/02/2012 03:42 PM, Sangwook Lee wrote:
>>> The following 2 patches add driver for S5K4ECGX
On 08/02/2012 03:42 PM, Sangwook Lee wrote:
> Add factory default settings for S5K4ECGX sensor registers,
> which was copied from the reference code of Samsung S.LSI.
>
> Signed-off-by: Sangwook Lee
> ---
> drivers/media/video/s5k4ecgx_regs.h | 3105
> +++
> 1 f
On 08/02/2012 03:42 PM, Sangwook Lee wrote:
> This driver implements preview mode of the S5K4ECGX sensor.
> capture (snapshot) operation, face detection are missing now.
>
> Following controls are supported:
> contrast/saturation/brightness/sharpness
>
> Signed-off-by: Sangwook
> Lee
> ---
...
>
Hi Sangwook,
On 08/02/2012 03:42 PM, Sangwook Lee wrote:
> The following 2 patches add driver for S5K4ECGX sensor with embedded ISP SoC,
> and minor v4l2 control API enhancement. S5K4ECGX is 5M CMOS Image sensor from
> Samsung
>
> Changes since v2:
> - added GPIO (reset/stby) and regulators
> -
Hi Sangwook,
On 07/20/2012 12:03 PM, Sangwook Lee wrote:
> Hi Sylwester
>
> Thank for the review.
>
> On 19 July 2012 20:40, Sylwester Nawrocki
> wrote:
>> On 07/19/2012 02:14 PM, Sangwook Lee wrote:
...
>>> Add factory default settings for S5K4ECGX sensor
Hi Sangwook,
A few review comments for you below...
On 07/19/2012 02:14 PM, Sangwook Lee wrote:
> This dirver implements preview mode of the S5K4ECGX sensor.
dirver -> driver
> capture (snapshot) operation, face detection are missing now.
>
> Following controls are supported:
> contrast/satura
Hi Sangwook,
On 07/19/2012 02:14 PM, Sangwook Lee wrote:
> Add factory default settings for S5K4ECGX sensor registers.
> I copied them from the reference code of Samsung S.LSI.
I'm pretty sure we can do better than that. I've started S5K6AAFX sensor
driver development with similar set of write-o
On 03/03/2012 12:06 PM, Amit Daniel Kachhap wrote:
This movement is needed because the hwmon entries and corresponding
sysfs interface is a duplicate of utilities already provided by
driver/thermal/thermal_sys.c. The goal is to place it in mfd folder
and add necessary calls to get the temperature
ences the 'fimd' clock.
>
> Signed-off-by: Tushar Behera
Reviewed-by: Sylwester Nawrocki
> ---
> arch/arm/mach-exynos/clock.c | 14 +-
> 1 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/clock.c b/arch/arm/
On 11/11/2011 07:28 AM, Amit Kachhap wrote:
> On 4 November 2011 23:03, Sylwester Nawrocki wrote:
>> On 11/04/2011 06:03 PM, amit.kach...@linaro.org wrote:
>>> From: Amit Daniel Kachhap
>>>
>>> Following the merge of CPU PM notifiers and L2 resume code, this pa
On 11/04/2011 06:03 PM, amit.kach...@linaro.org wrote:
> From: Amit Daniel Kachhap
>
> Following the merge of CPU PM notifiers and L2 resume code, this patch
> removes useless code to save and restore L2 and GIC registers.
>
> This is now automatically covered by suspend calls which integrated
>
22 matches
Mail list logo
