[PATCH v3 1/3] fault-inject: export setup_fault_attr()

2011-09-14 Thread Per Forlin
mmc_core module needs to use setup_fault_attr() in order to set fault injection attributes during module load time. Signed-off-by: Per Forlin --- lib/fault-inject.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 328d433

[PATCH v3 3/3] fault-injection: update documentation with the mmc module param

2011-09-14 Thread Per Forlin
Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index 70f924e..ba4be8b 100644 --- a

[PATCH v3 0/3] mmc: rectify boot param option for fault injection

2011-09-14 Thread Per Forlin
am makes it possible to pass default fault attributes for external modules too. This patch set is for 3.2 Change log: v2 - use module_param_cb() to set default fault attributes - fix spelling of documentation in patch #3 v3 - remove unused variable and return error if invalid boot param. Per

[PATCH v3 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
Replace setup("fail_mmc_request") and faulty "ifdef KERNEL" with a module_param_cb(). The module param mmc_core.fail_request may be used to set the fault injection attributes during boot time or module load time. Signed-off-by: Per Forlin --- drivers/mmc/c

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
On 14 September 2011 12:38, Per Forlin wrote: > On 14 September 2011 12:18, Per Forlin wrote: >> On 14 September 2011 12:05, Akinobu Mita wrote: >>> 2011/9/14 Per Forlin : >>> >>>> +#ifdef CONFIG_FAIL_MMC_REQUEST >>>> + >>>> +

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
On 14 September 2011 12:18, Per Forlin wrote: > On 14 September 2011 12:05, Akinobu Mita wrote: >> 2011/9/14 Per Forlin : >> >>> +#ifdef CONFIG_FAIL_MMC_REQUEST >>> + >>> +static DECLARE_FAULT_ATTR(fail_default_attr); >>> +static cha

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
On 14 September 2011 12:05, Akinobu Mita wrote: > 2011/9/14 Per Forlin : > >> +#ifdef CONFIG_FAIL_MMC_REQUEST >> + >> +static DECLARE_FAULT_ATTR(fail_default_attr); >> +static char *fail_request; > > This is not used anymore and ... > Yes of

[PATCH v2 1/3] fault-inject: export setup_fault_attr()

2011-09-14 Thread Per Forlin
mmc_core module needs to use setup_fault_attr() in order to set fault injection attributes during module load time. Signed-off-by: Per Forlin --- lib/fault-inject.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 328d433

[PATCH v2 0/3] mmc: rectify boot param option for fault injection

2011-09-14 Thread Per Forlin
am makes it possible to pass default fault attributes for external modules too. This patch set is for 3.2 Change log: v2 - use module_param_cb() to set default fault attributes - fix spelling of documentation in patch #3 Per Forlin (3): fault-inject: export setup_fault_attr() mmc: add

[PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
Replace setup("fail_mmc_request") and faulty "ifdef KERNEL" with a module_param_cb(). The module param mmc_core.fail_request may be used to set the fault injection attributes during boot time or module load time. Signed-off-by: Per Forlin --- drivers/mmc/c

[PATCH v2 3/3] fault-injection: update documentation with the mmc module param

2011-09-14 Thread Per Forlin
Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index 70f924e..ba4be8b 100644 --- a

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-14 Thread Per Forlin
On 14 September 2011 10:04, Akinobu Mita wrote: > 2011/9/14 Per Forlin : > >> It's simple and the patch would be just two lines. >> The reason for changing my mind is that it may be useful to be able to >> pass the fault injection attributes even when mmc_core is a m

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
On 14 September 2011 01:37, Akinobu Mita wrote: > 2011/9/14 Per Forlin : >> Hi Akinobu, >> >> On 13 September 2011 16:19, Per Forlin wrote: >>> On 13 September 2011 15:12, Akinobu Mita wrote: >>>> 2011/8/19 Per Forlin : >>>> >>>&g

[PATCH 0/3] mmc: rectify boot param option for fault injection

2011-09-13 Thread Per Forlin
Akinobu Mita reported that the boot option for mmc fault injection is never compiled in due to a fauly "ifdef KERNEL" that is never set. A correct ifdef would be "ifndef MODULE". Akinobu suggested to use a module param instead. This patch set is for 3.2 Per Forlin (3):

[PATCH 1/3] fault-inject: export setup_fault_attr()

2011-09-13 Thread Per Forlin
mmc_core module needs to use setup_fault_attr() in order to set fault injection attributes during module load time. Signed-off-by: Per Forlin --- lib/fault-inject.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 328d433

[PATCH 2/3] mmc: add module param to set fault injection attributes

2011-09-13 Thread Per Forlin
Replace setup("fail_mmc_request") and faulty "ifdef KERNEL" with a simple module_param(). The module param mmc_core.fail_request may be used to set the fault injection attributes during boot time or module load time. Signed-off-by: Per Forlin --- drivers/mmc/c

[PATCH 3/3] fault-injection: update documenation with the mmc module param

2011-09-13 Thread Per Forlin
Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index 70f924e..ba4be8b 100644 --- a

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
Hi Akinobu, On 13 September 2011 16:19, Per Forlin wrote: > On 13 September 2011 15:12, Akinobu Mita wrote: >> 2011/8/19 Per Forlin : >> >>> +#ifdef KERNEL >>> +/* >>> + * Internal function. Pass the boot param fail_mmc_request to >>&g

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
On 13 September 2011 15:12, Akinobu Mita wrote: > 2011/8/19 Per Forlin : > >> +#ifdef KERNEL >> +/* >> + * Internal function. Pass the boot param fail_mmc_request to >> + * the setup fault injection attributes routine. >> + */ >> +static i

Re: [PATCH] mmc: omap_hsmmc: DMA unmap only once in case of MMC error

2011-09-12 Thread Per Forlin
On 1 September 2011 21:19, S, Venkatraman wrote: > On Mon, Aug 29, 2011 at 3:38 AM, Per Forlin wrote: >> Reported by Russell King: >> >> mmcblk0: error -84 transferring data, sector 149201, nr 64, >> cmd response 0x900, card status 0xb00 >> mmcblk0:

[PATCH 0/2] mmc: clarifications on host.post_req()

2011-08-29 Thread Per Forlin
Fixes for 3.1. This patchset doesn't fix any bugs in 3.1 but it improves the documentation in order to prevent new bugs. Per Forlin (2): mmc: core: clarify how to use post_req in case of errors mmc: mmci: simplify err check in mmci_post_request drivers/mmc/core/core.c |

[PATCH 1/2] mmc: core: clarify how to use post_req in case of errors

2011-08-29 Thread Per Forlin
The err condition in post_req() is set to undo a call made to pre_req() that hasn't been started yet. The err condition is not set if an MMC request returns error. Signed-off-by: Per Forlin --- drivers/mmc/core/core.c |6 ++ include/linux/mmc/host.h |3 +++ 2 files chang

[PATCH 2/2] mmc: mmci: simplify err check in mmci_post_request

2011-08-29 Thread Per Forlin
: Per Forlin --- drivers/mmc/host/mmci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 56e9a41..40e4c05 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -529,7 +529,7 @@ static void

[PATCH 4/4] dmaengine/ste_dma40: fix memory leak due to prepared descriptors

2011-08-29 Thread Per Forlin
Prepared descriptors that are not submitted will not be freed. Add prepared descriptor to a list to be able to release them upon dmaengine_terminate_all(). Signed-off-by: Per Forlin --- drivers/dma/ste_dma40.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff

[PATCH 0/4] dmaeninge/ste_dma40: bug fixes for 3.1

2011-08-29 Thread Per Forlin
ssing * duplication of d40_pool_lli_free() * free of client descriptor triggers an oops. Per Forlin (4): dmaengine/ste_dma40: add missing kernel doc for pending_queue dmaengine/ste_dma40: remove duplicate call to d40_pool_lli_free(). dmaengine/ste_dma40: fix Oops due to double free of client descr

[PATCH 3/4] dmaengine/ste_dma40: fix Oops due to double free of client descriptor

2011-08-29 Thread Per Forlin
request at virtual address 00100104 pgd = dea8c000 [00100104] *pgd=1ea62831, *pte=, *ppte= Internal error: Oops: 817 [#1] PREEMPT SMP Modules linked in: CPU: 0Not tainted (3.1.0-rc3+ #58) PC is at d40_free_chan_resources+0x64/0x330 Signed-off-by: Per Forlin --- drivers/dma

[PATCH 1/4] dmaengine/ste_dma40: add missing kernel doc for pending_queue

2011-08-29 Thread Per Forlin
Signed-off-by: Per Forlin --- drivers/dma/ste_dma40.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index cd3a7c7..486b6c0 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -174,6 +174,7 @@ struct

[PATCH 2/4] dmaengine/ste_dma40: remove duplicate call to d40_pool_lli_free().

2011-08-29 Thread Per Forlin
d40_desc_free() already calls d40_pool_lli_free(). Signed-off-by: Per Forlin --- drivers/dma/ste_dma40.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 486b6c0..37388d1 100644 --- a/drivers/dma/ste_dma40.c +++ b

[PATCH] mmc: omap_hsmmc: DMA unmap only once in case of MMC error

2011-08-28 Thread Per Forlin
mapped memory to unmap. Signed-off-by: Per Forlin --- Bug fix on 3.1-rc3 drivers/mmc/host/omap_hsmmc.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 21e4a79..31d9817 100644 --- a/drivers/mmc/host

Re: [PATCH v9 00/12] use nonblock mmc requests to minimize latency

2011-08-28 Thread Per Forlin
On 28 August 2011 13:11, Russell King - ARM Linux wrote: > On Sun, Aug 28, 2011 at 12:50:54PM +0200, Per Forlin wrote: >> On 26 August 2011 18:28, Santosh wrote: >> > + Balaji, >> > >> > On Friday 26 August 2011 09:49 PM, Russell King - ARM Linux wrote: >&g

Re: [PATCH v9 00/12] use nonblock mmc requests to minimize latency

2011-08-28 Thread Per Forlin
On 26 August 2011 18:28, Santosh wrote: > + Balaji, > > On Friday 26 August 2011 09:49 PM, Russell King - ARM Linux wrote: >> >> I'm not sure who's responsible for this, but the nonblocking MMC stuff is >> broken on OMAPs HSMMC: >> >> mmcblk0: error -84 transferring data, sector 149201, nr 64, cmd

[PATCH v6] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
, 5.2711 s, 19.9 MB/s There may not be one optimal number for all boards. This is why the number is added to Kconfig. If selecting USB_GADGET_DEBUG_FILES this value may be set by a module parameter as well. Signed-off-by: Per Forlin --- Change log. v2: Update after proofreading comments from Michal

Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
2011/8/19 Michal Nazarewicz : > On Fri, 19 Aug 2011 19:15:32 +0200, Per Forlin > wrote: > >> 2011/8/19 Michal Nazarewicz : >>> >>> On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin >>> >>> wrote: >>>> >>>> @@ -3605,

Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
2011/8/19 Michal Nazarewicz : > On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin > wrote: >> >> @@ -3605,6 +3608,9 @@ static int __init fsg_init(void) >>        int             rc; >>        struct fsg_dev  *fsg; >> +       if (!FSG_NUM_BUFFERS_IS_VALID(fsg_

Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
On 19 August 2011 16:28, Per Forlin wrote: > From: Per Forlin > > FSG_NUM_BUFFERS is set to 2 as default. > Usually 2 buffers are enough to establish a good buffering pipeline. > The number may be increased in order to compensate a for bursty VFS > behaviour. > > Here

[PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
From: Per Forlin FSG_NUM_BUFFERS is set to 2 as default. Usually 2 buffers are enough to establish a good buffering pipeline. The number may be increased in order to compensate a for bursty VFS behaviour. Here follows a description of system that may require more than 2 buffers. * CPU ondemand

[PATCH v9 2/3] mmc: core: add random fault injection

2011-08-19 Thread Per Forlin
From: Per Forlin This adds support to inject data errors after a completed host transfer. The mmc core will return error even though the host transfer is successful. This simple fault injection proved to be very useful to test the non-blocking error handling in the mmc_blk_issue_rw_rq(). Random

[PATCH v9 3/3] fault injection: add documentation on MMC IO fault injection

2011-08-19 Thread Per Forlin
From: Per Forlin Add description on how to enable random fault injection for MMC IO Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- Documentation/fault-injection/fault-injection.txt |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/Documentation/fault

[PATCH v9 0/3] mmc: make fault injection available for MMC IO

2011-08-19 Thread Per Forlin
From: Per Forlin change log: v2 - Resolve build issue in mmc core.c due to multiple init_module by removing the fault inject module. - Export fault injection functions to make them available for modules - Update fault injection documentation on MMC IO v3 - add function

[PATCH v9 1/3] fault-inject: export fault injection functions

2011-08-19 Thread Per Forlin
From: Per Forlin export symbols should_fail() and fault_create_debugfs_attr() in order to let modules utilize the fault injection Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault

Re: [PATCH --mmotm v8 2/3] mmc: core: add random fault injection

2011-08-19 Thread Per Forlin
On 19 August 2011 13:40, Linus Walleij wrote: > On Tue, Aug 9, 2011 at 2:07 PM, Per Forlin wrote: > >> This adds support to inject data errors after a completed host transfer. >> The mmc core will return error even though the host transfer is successful. >> This simple f

Re: [PATCH v4] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
2011/8/19 Michal Nazarewicz : > On Fri, 19 Aug 2011 10:39:24 +0200, Per Forlin > wrote: > >> 2011/8/18 Michal Nazarewicz : >>> >>> On Thu, 18 Aug 2011 11:28:46 +0200, Per Forlin wrote: >>>> >>>> diff --git a/drivers/usb/gadget/f_mass_storag

Re: [PATCH --mmotm v8 0/3] Make fault injection available for MMC IO

2011-08-19 Thread Per Forlin
the mmc part of this patchset is acked and accepted? Regards, Per On 9 August 2011 14:07, Per Forlin wrote: > change log: >  v2 - Resolve build issue in mmc core.c due to multiple init_module by >      removing the fault inject module. >    - Export fault injection functions to

Re: [PATCH v4] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
2011/8/18 Michal Nazarewicz : > On Thu, 18 Aug 2011 11:28:46 +0200, Per Forlin wrote: >> >> diff --git a/drivers/usb/gadget/f_mass_storage.c >> b/drivers/usb/gadget/f_mass_storage.c >> index 5b93395..3e546d9 100644 >> --- a/drivers/usb/gadget/f_mass_stor

Re: [PATCH v4] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-18 Thread Per Forlin
On 18 August 2011 13:14, Felipe Balbi wrote: > Hi, > > On Thu, Aug 18, 2011 at 11:28:46AM +0200, Per Forlin wrote: >> From: Per Forlin >> >> FSG_NUM_BUFFERS is set to 2 as default. >> Usually 2 buffers are enough to establish a good buffering pipeline. >>

[PATCH v4] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-18 Thread Per Forlin
From: Per Forlin FSG_NUM_BUFFERS is set to 2 as default. Usually 2 buffers are enough to establish a good buffering pipeline. The number may be increased in order to compensate a for bursty VFS behaviour. Here follows a description of system that may require more than 2 buffers. * CPU ondemand

Re: [PATCH v3] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-17 Thread Per Forlin
On 12 August 2011 17:49, Alan Stern wrote: > On Fri, 12 Aug 2011, Felipe Balbi wrote: > >> On Mon, Aug 08, 2011 at 11:43:35PM +0200, Per Forlin wrote: >> > FSG_NUM_BUFFERS is set to 2 as default. >> > Usually 2 buffers are enough to establish a good buffering pi

[PATCH v3] usb: musb: ux500: optimize DMA callback routine

2011-08-17 Thread Per Forlin
From: Per Forlin Skip the use of work queue and call musb_dma_completion() directly from DMA callback context. Here follows measurements on a Snowball board with ondemand governor active. Performance using work queue: (105 MB) copied, 6.23758 s, 16.8 MB/s (105 MB) copied, 5.7151 s, 18.3 MB/s

Re: [PATCH v2] usb: musb: ux500: optimize DMA callback routine

2011-08-14 Thread Per Forlin
On 12 August 2011 11:41, Felipe Balbi wrote: > Hi, > > On Mon, Aug 08, 2011 at 01:01:06PM +0200, Per Forlin wrote: >> From: Per Forlin >> >> Skip the use of work queue and call musb_dma_completion() directly from >> DMA callback context. >> >> Here

[PATCH --mmotm v8 3/3] fault injection: add documentation on MMC IO fault injection

2011-08-09 Thread Per Forlin
Add description on how to enable random fault injection for MMC IO Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- Documentation/fault-injection/fault-injection.txt |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/Documentation/fault-injection/fault

[PATCH --mmotm v8 2/3] mmc: core: add random fault injection

2011-08-09 Thread Per Forlin
test how the host driver handles pre_req() and post_req() in case of errors. Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- drivers/mmc/core/core.c| 44 drivers/mmc/core/debugfs.c | 27 +++ include/linux/mmc/host.h

[PATCH --mmotm v8 1/3] fault-inject: export fault injection functions

2011-08-09 Thread Per Forlin
export symbols should_fail() and fault_create_debugfs_attr() in order to let modules utilize the fault injection Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault

[PATCH --mmotm v8 0/3] Make fault injection available for MMC IO

2011-08-09 Thread Per Forlin
request to boot option section. Per Forlin (3): fault-inject: export fault injection functions mmc: core: add random fault injection fault injection: add documentation on MMC IO fault injection Documentation/fault-injection/fault-injection.txt |8 +++- drivers/mmc/core/core.c

[PATCH --mmotm v7 1/3] fault-inject: export fault injection functions

2011-08-09 Thread Per Forlin
export symbols should_fail() and fault_create_debugfs_attr() in order to let modules utilize the fault injection Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault

[PATCH --mmotm v7 2/3] mmc: core: add random fault injection

2011-08-09 Thread Per Forlin
test how the host driver handles pre_req() and post_req() in case of errors. Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- drivers/mmc/core/core.c| 44 drivers/mmc/core/debugfs.c | 27 +++ include/linux/mmc/host.h

[PATCH --mmotm v7 0/3] Make fault injection available for MMC IO

2011-08-09 Thread Per Forlin
-injection: add ability to export fault_attr in...". v6 - Fix typo in commit message in patch "export fault injection functions" v7 - Don't compile in boot param setup function if mmc-core is built as module. Per Forlin (3): fault-inject: export fault injection fun

[PATCH --mmotm v7 3/3] fault injection: add documentation on MMC IO fault injection

2011-08-09 Thread Per Forlin
Add description on how to enable random fault injection for MMC IO Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- Documentation/fault-injection/fault-injection.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/Documentation/fault-injection/fault

[PATCH --mmotm v6 2/3] mmc: core: add random fault injection

2011-08-09 Thread Per Forlin
test how the host driver handles pre_req() and post_req() in case of errors. Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- drivers/mmc/core/core.c| 44 drivers/mmc/core/debugfs.c | 24 include/linux/mmc/host.h

[PATCH --mmotm v6 3/3] fault injection: add documentation on MMC IO fault injection

2011-08-09 Thread Per Forlin
Add description on how to enable random fault injection for MMC IO Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- Documentation/fault-injection/fault-injection.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/Documentation/fault-injection/fault

[PATCH --mmotm v6 0/3] Make fault injection available for MMC IO

2011-08-09 Thread Per Forlin
-injection: add ability to export fault_attr in...". v6 - Fix typo in commit message in patch "export fault injection functions" Per Forlin (3): fault-inject: export fault injection functions mmc: core: add random fault injection fault injection: add documentation

[PATCH --mmotm v6 1/3] fault-inject: export fault injection functions

2011-08-09 Thread Per Forlin
export symbols should_fail() and fault_create_debugfs_attr() in order to let modules utilize the fault injection Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault

Re: [PATCH --mmotm v5 0/3] Make fault injection available for MMC IO

2011-08-09 Thread Per Forlin
On 9 August 2011 11:24, Akinobu Mita wrote: > 2011/8/9 Per Forlin : > >> Patch #1 "fault-injection: export fault injection functions" is merged > > Maybe you are looking at wrong tree.  I can't find it in Linus' tree or > mmotm patches. > Thanks for

Re: [PATCH --mmotm v5 0/3] Make fault injection available for MMC IO

2011-08-09 Thread Per Forlin
On 9 August 2011 02:51, Akinobu Mita wrote: > All three patches look good. > Acked-by: Akinobu Mita > > 2011/8/9 Per Forlin : >> This patchset is sent to the mm-tree because it depends on Akinobu's patch >> "fault-injection: add ability to export fault_attr in..

Re: [PATCH --mmotm v5 1/3] fault-inject: export fault injection functions

2011-08-09 Thread Per Forlin
On 8 August 2011 22:07, Per Forlin wrote: > export symbols fault_should_fail() and fault_create_debugfs_attr() in order > to let modules utilize the fault injection This patch is already merged in mainline too. Unfortunately I left a typo here. It says fault_should_fail() in the commit m

[PATCH v3] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-08 Thread Per Forlin
, 5.2711 s, 19.9 MB/s There may not be one optimal number for all boards. This is why the number is added to Kconfig. Signed-off-by: Per Forlin Acked-by: Michal Nazarewicz --- Change log. v2: Update after proofreading comments from Michal Nazarewicz v3: Clarify the description of this patch based on

Re: [PATCH] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-08 Thread Per Forlin
On 8 August 2011 22:23, Alan Stern wrote: > On Mon, 8 Aug 2011, Per Forlin wrote: > >> On 8 August 2011 20:45, Alan Stern wrote: >> > On Mon, 8 Aug 2011, Per Forlin wrote: >> > >> >> > Okay, 6% is a worthwhile improvement, though not huge.  Did you tr

[PATCH --mmotm v5 1/3] fault-inject: export fault injection functions

2011-08-08 Thread Per Forlin
export symbols fault_should_fail() and fault_create_debugfs_attr() in order to let modules utilize the fault injection Signed-off-by: Per Forlin --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index f193b77

[PATCH --mmotm v5 3/3] fault injection: add documentation on MMC IO fault injection

2011-08-08 Thread Per Forlin
Add description on how to enable random fault injection for MMC IO Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation

[PATCH --mmotm v5 2/3] mmc: core: add random fault injection

2011-08-08 Thread Per Forlin
test how the host driver handles pre_req() and post_req() in case of errors. Signed-off-by: Per Forlin Acked-by: Akinobu Mita --- drivers/mmc/core/core.c| 44 drivers/mmc/core/debugfs.c | 24 include/linux/mmc/host.h

[PATCH --mmotm v5 0/3] Make fault injection available for MMC IO

2011-08-08 Thread Per Forlin
rt for creating debugfs entries in arbitrary directory. v5 - Make use of fault_create_debugfs_attr() in Akinobu's patch "fault-injection: add ability to export fault_attr in...". Per Forlin (3): fault-inject: export fault injection functions mmc: core: add random fau

Re: [PATCH] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-08 Thread Per Forlin
On 8 August 2011 20:45, Alan Stern wrote: > On Mon, 8 Aug 2011, Per Forlin wrote: > >> > Okay, 6% is a worthwhile improvement, though not huge.  Did you try 6 >> > or 8 buffers?  I bet going beyond 4 makes very little difference. >> > >> On my board 4 buffer

Re: [PATCH] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-08 Thread Per Forlin
On 8 August 2011 16:34, Alan Stern wrote: > On Mon, 8 Aug 2011, Per Forlin wrote: > >> FSG_NUM_BUFFERS is set to 2 as default. >> Usually 2 buffers are enough to establish a good >> double buffering pipeline. But when dealing with expensive >> request preparati

[PATCH v2] usb: musb: ux500: optimize DMA callback routine

2011-08-08 Thread Per Forlin
From: Per Forlin Skip the use of work queue and call musb_dma_completion() directly from DMA callback context. Here follows measurements on a Snowball board with ondemand governor active. Performance using work queue: (105 MB) copied, 6.23758 s, 16.8 MB/s (105 MB) copied, 5.7151 s, 18.3 MB/s

[PATCH v2] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-08 Thread Per Forlin
From: Per Forlin FSG_NUM_BUFFERS is set to 2 as default. Usually 2 buffers are enough to establish a good buffering pipeline. But when dealing with expensive request preparation (i.e. dma_map) there may be benefits of increasing the number of buffers. There is an extra cost for every first

Re: [PATCH] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-08 Thread Per Forlin
Hi Michal, 2011/8/8 Michal Nazarewicz : > On Mon, 08 Aug 2011 02:22:14 +0200, Per Forlin > wrote: >> >> FSG_NUM_BUFFERS is set to 2 as default. >> Usually 2 buffers are enough to establish a good >> double buffering pipeline. But when dealing with expensive >&g

[PATCH] usb: musb: ux500: optimize DMA callback routine

2011-08-08 Thread Per Forlin
, 5.83583 s, 18.0 MB/s (105 MB) copied, 5.93611 s, 17.7 MB/s Performance without work queue (105 MB) copied, 5.62173 s, 18.7 MB/s (105 MB) copied, 5.61811 s, 18.7 MB/s (105 MB) copied, 5.57817 s, 18.8 MB/s (105 MB) copied, 5.58549 s, 18.8 MB/s Signed-off-by: Per Forlin Acked-by: Mian Yousaf Kaukab

[PATCH] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size

2011-08-07 Thread Per Forlin
(105 MB) copied, 5.27249 s, 19.9 MB/s There may not be one optimal number for all boards. That is the reason for adding the number to Kconfig, Signed-off-by: Per Forlin --- drivers/usb/gadget/Kconfig | 15 +++ drivers/usb/gadget/storage_common.c |4 ++-- 2 files changed

Re: [PATCH] usb: musb: cppi: fix build errors due to DBG and missing musb variable

2011-08-03 Thread Per Forlin
On 3 August 2011 15:43, Felipe Balbi wrote: > Hi, > > On Wed, Aug 03, 2011 at 03:39:15PM +0200, Per Forlin wrote: >> From: Per Forlin >> >> Replace DBG with dev_dbg add fix invalid access of musb->controller. >> With this patch cppi_dma builds successfully. &g

Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

2011-08-03 Thread Per Forlin
On 3 August 2011 15:31, Felipe Balbi wrote: > On Tue, Aug 02, 2011 at 05:33:39PM +0200, Per Forlin wrote: >> From: Per Forlin >> >> The dma driver requires both src and dst to be set. >> This fix is needed in order to run gadget mass storage. >> Patch is verified

[PATCH] usb: musb: cppi: fix build errors due to DBG and missing musb variable

2011-08-03 Thread Per Forlin
From: Per Forlin Replace DBG with dev_dbg add fix invalid access of musb->controller. With this patch cppi_dma builds successfully. Signed-off-by: Per Forlin Cc: --- drivers/usb/musb/cppi_dma.c | 26 +- 1 files changed, 17 insertions(+), 9 deletions(-) diff --gi

[PATCH] usb: musb: ux500: replace missing DBG with dev_dbg

2011-08-03 Thread Per Forlin
From: Per Forlin ux500_dma.c fail to compile becase DBG has been removed from musb_debug. Use dev_dbg for all prints. Signed-off-by: Per Forlin Acked-by: Mian Yousaf Kaukab --- drivers/usb/musb/ux500_dma.c | 22 ++ 1 files changed, 14 insertions(+), 8 deletions(-) diff

[PATCH] usb: musb: ux500: set dma config for both src and dst

2011-08-02 Thread Per Forlin
From: Per Forlin The dma driver requires both src and dst to be set. This fix is needed in order to run gadget mass storage. Patch is verified on snowball. Signed-off-by: Per Forlin --- drivers/usb/musb/ux500_dma.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions

Re: [PATCH v4 2/3] mmc: core: add random fault injection

2011-07-27 Thread Per Forlin
On 27 July 2011 18:08, Akinobu Mita wrote: > 2011/7/27 Per Forlin : > >> There is an issue with patch v4 now when fault_attr is per-host. >> Without your patch the entry is still created at the root but there >> are many instances of fault-attr. I think it's better

[PATCH 4/4] fault-inject: make mmc fault-inject depend on MMC

2011-07-27 Thread Per Forlin
Make sure MMC is configured when selecting config for mmc fault-inject. Signed-off-by: Per Forlin --- lib/Kconfig.debug |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 330fc70..b135c5e 100644 --- a/lib/Kconfig.debug +++ b/lib

[PATCH 2/4] mmc: core: resolve build error for fault inject

2011-07-27 Thread Per Forlin
Fault inject init can't be a module since core may be a module as well. Call fault inject init function from mmc_init instead. Signed-off-by: Per Forlin --- drivers/mmc/core/core.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/mmc

[PATCH 0/4] Bug fixes for mmc fault inject for linaro-linux-2.6.39

2011-07-27 Thread Per Forlin
The mmc fault injection is being refactored and the new version will not make it until 3.1 due to external dependencies. The current version works fine except that it can't be used if mmc is a module. This patch-set resolves that issue. Per Forlin (4): fault-inject: make fault inje

[PATCH 3/4] mmc: core: silence build warning for mmc fault inject

2011-07-27 Thread Per Forlin
Skip building fault inject boot param code in case of core being built as a module. Signed-off-by: Per Forlin --- drivers/mmc/core/core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index af09384..2f4b77e 100644

[PATCH 1/4] fault-inject: make fault injection available for modules

2011-07-27 Thread Per Forlin
export symbols should_fail() and init_fault_attr_dentries() in order to make modules use the fault injection functionality Signed-off-by: Per Forlin --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index

Re: [PATCH v4 2/3] mmc: core: add random fault injection

2011-07-27 Thread Per Forlin
On 27 July 2011 01:17, Akinobu Mita wrote: > 2011/7/27 Per Forlin : >> This adds support to inject data errors after a completed host transfer. >> The mmc core will return error even though the host transfer is successful. >> This simple fault injection proved to be very usef

[PATCH v4 2/3] mmc: core: add random fault injection

2011-07-26 Thread Per Forlin
test how the host driver handles pre_req() and post_req() in case of errors. Signed-off-by: Per Forlin --- drivers/mmc/core/core.c| 45 drivers/mmc/core/debugfs.c | 26 + include/linux/mmc/host.h |7 ++ lib

[PATCH v4 3/3] fault injection: add documentation on MMC IO fault injection

2011-07-26 Thread Per Forlin
Add description on how to enable random fault injection for MMC IO Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation

[PATCH v4 0/3] Make fault injection available for MMC IO

2011-07-26 Thread Per Forlin
debugfs entries in arbitrary directory. Per Forlin (3): fault-inject: make fault injection available for modules mmc: core: add random fault injection fault injection: add documentation on MMC IO fault injection Documentation/fault-injection/fault-injection.txt |5 ++ drivers/mmc

[PATCH v4 1/3] fault-inject: make fault injection available for modules

2011-07-26 Thread Per Forlin
export symbols should_fail() and init_fault_attr_dentries() in order to make modules use the fault injection functionality Signed-off-by: Per Forlin --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index

Re: [PATCH v3 2/3] mmc: core: add random fault injection

2011-07-26 Thread Per Forlin
On 25 July 2011 17:58, Akinobu Mita wrote: > 2011/7/21 Per Forlin : >> This adds support to inject data errors after a completed host transfer. >> The mmc core will return error even though the host transfer is successful. >> This simple fault injection proved to be very usef

Re: [PATCH v3 2/3] mmc: core: add random fault injection

2011-07-26 Thread Per Forlin
On 26 July 2011 03:41, Akinobu Mita wrote: > 2011/7/26 Per Forlin : >>>> And I know that init_fault_attr_dentries() can only create a >>>> subdirectory in debugfs root directory.  But I have a patch which >>>> support for creating it in arbitrary directo

Re: [PATCH v3 2/3] mmc: core: add random fault injection

2011-07-25 Thread Per Forlin
Hi Akinobu, On 25 July 2011 21:19, Per Forlin wrote: > On 25 July 2011 17:58, Akinobu Mita wrote: >> 2011/7/21 Per Forlin : >>> This adds support to inject data errors after a completed host transfer. >>> The mmc core will return error even though the host trans

Re: [PATCH v3 2/3] mmc: core: add random fault injection

2011-07-25 Thread Per Forlin
On 25 July 2011 17:58, Akinobu Mita wrote: > 2011/7/21 Per Forlin : >> This adds support to inject data errors after a completed host transfer. >> The mmc core will return error even though the host transfer is successful. >> This simple fault injection proved to be very usef

[PATCH v3 2/3] mmc: core: add random fault injection

2011-07-20 Thread Per Forlin
test how the host driver handles pre_req() and post_req() in case of errors. Signed-off-by: Per Forlin --- drivers/mmc/core/core.c| 69 drivers/mmc/core/debugfs.c |5 +++ include/linux/mmc/host.h |3 ++ lib/Kconfig.debug | 11

[PATCH v3 0/3] Make fault injection available for MMC IO

2011-07-20 Thread Per Forlin
make them available for modules - Update fault injection documentation on MMC IO v3 - add function descriptions in core.c - use export GPL for fault injection functions Per Forlin (3): fault-inject: make fault injection available for modules mmc: core: add random fault injection

[PATCH v3 1/3] fault-inject: make fault injection available for modules

2011-07-20 Thread Per Forlin
export symbols should_fail() and init_fault_attr_dentries() in order to make modules use the fault injection functionality Signed-off-by: Per Forlin --- lib/fault-inject.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index

  1   2   3   4   >