,
which cause the bursty VFS behaviour.
Signed-off-by: Per Forlin
Acked-by: Michal Nazarewicz
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewi
On Fri, 19 Aug 2011 19:15:32 +0200, Per Forlin
wrote:
2011/8/19 Michal Nazarewicz :
On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin
wrote:
@@ -3605,6 +3608,9 @@ static int __init fsg_init(void)
int rc;
struct fsg_dev *fsg;
+ if (!FSG_NUM_BUFFERS_IS_VALID
On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin
wrote:
@@ -3605,6 +3608,9 @@ static int __init fsg_init(void)
int rc;
struct fsg_dev *fsg;
+ if (!FSG_NUM_BUFFERS_IS_VALID(fsg_num_buffers))
Care to add pr_err() here? Or better yet, change
fsg_num_buffers_is
On Fri, 19 Aug 2011 13:42:08 +0200, Per Forlin
wrote:
Is it true that fsg_common_init() will never be called twice to
initialise the same fsg_common structure. It is always called once
followed by release.
If this is the case it is safe to only:
if (common->buffhds)
common->buffhds = kzalloc(
On Fri, 19 Aug 2011 10:39:24 +0200, Per Forlin
wrote:
2011/8/18 Michal Nazarewicz :
On Thu, 18 Aug 2011 11:28:46 +0200, Per Forlin wrote:
diff --git a/drivers/usb/gadget/f_mass_storage.c
b/drivers/usb/gadget/f_mass_storage.c
index 5b93395..3e546d9 100644
--- a/drivers/usb/gadget
On Thu, 18 Aug 2011 11:28:46 +0200, Per Forlin wrote:
diff --git a/drivers/usb/gadget/f_mass_storage.c
b/drivers/usb/gadget/f_mass_storage.c
index 5b93395..3e546d9 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -363,7 +363,6 @@ struct fsg_common {
On Mon, 08 Aug 2011 02:22:14 +0200, Per Forlin wrote:
There may not be one optimal number for all boards. That is the
reason for adding the number to Kconfig,
2011/8/8 Michal Nazarewicz :
It could actually be turned into a run-time configuration, but
that's a bit more intrusive,
On Mo
ed-by: Michal Nazarewicz
Some not very relevant comments below:
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 029e288..bbd17f3 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -96,6 +96,21 @@ config USB_GADGET_VBUS_DRAW
This value wi
