Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Manjunath Goudar
On 23 June 2013 00:38, Alan Stern wrote: > On Sun, 23 Jun 2013, Manjunath Goudar wrote: > > > > As a general rule, you should never change code that you don't > > > understand. Do you _know_ that it will be safe to call ohci_setup() or > > > ohci_restart

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Manjunath Goudar
On 21 June 2013 22:03, Alan Stern wrote: > On Fri, 21 Jun 2013, Manjunath Goudar wrote: > > > On 20 June 2013 22:23, Alan Stern wrote: > > > > > On Thu, 20 Jun 2013, Manjunath Goudar wrote: > > > > > > > > > @@ -686,7 +631,7 @@ ohci_hcd_at9

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-21 Thread Manjunath Goudar
On 20 June 2013 22:23, Alan Stern wrote: > On Thu, 20 Jun 2013, Manjunath Goudar wrote: > > > > > @@ -686,7 +631,7 @@ ohci_hcd_at91_drv_suspend(struct platform_device > > > *pdev, pm_message_t mesg) > > > >* REVISIT: so

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-20 Thread Manjunath Goudar
On 20 June 2013 01:46, Alan Stern wrote: > On Wed, 12 Jun 2013, Manjunath Goudar wrote: > > > Separate the TI OHCI Atmel host controller driver from ohci-hcd > > host code so that it can be built as a separate driver module. > > This work is part of enabling multi

Re: [PATCH V2 1/6] USB: OHCI: make ohci-exynos a separate driver

2013-06-19 Thread Manjunath Goudar
On 20 June 2013 09:40, Jingoo Han wrote: > On Thursday, June 13, 2013 12:54 AM, Manjunath Goudar wrote: > > > > Separate the Samsung OHCI EXYNOS host controller driver from ohci-hcd > > host code so that it can be built as a separate driver module. > > This wor

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-18 Thread Manjunath Goudar
On 14 June 2013 01:22, Alan Stern wrote: > On Thu, 13 Jun 2013, Tomasz Figa wrote: > > > > + rc = ohci_suspend(hcd, do_wakeup); > > > + if (rc == 0 && do_wakeup && HCD_WAKEUP_PENDING(hcd)) { > > > + ohci_resume(hcd, false); > > > + rc = -EBUSY; > > > + } > > > > I'm not

Re: [PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-17 Thread Manjunath Goudar
On 17 June 2013 14:55, Viresh Kumar wrote: > On 17 June 2013 14:52, Manjunath Goudar > wrote: > > when we are using tab characters before "do_wakeup" and "ret" > variable,we > > will be getting error below. > > > > WARNING: please, no space

Re: [PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-17 Thread Manjunath Goudar
On 14 June 2013 00:44, Alan Stern wrote: > On Thu, 13 Jun 2013, Manjunath Goudar wrote: > > > Suspend scenario in case of ohci-at91 glue was not properly > > handled as it was not suspending generic part of ohci controller. > > Calling explicitly the o

Re: [PATCH V2 00/10] USB: OHCI:Properly handle ohci_suspend()routine in bus glue

2013-06-14 Thread Manjunath Goudar
Hi Alan, Can you review other patches which are left out in this series. Manjunath Goudar On 13 June 2013 14:46, Manjunath Goudar wrote: > Suspend scenario in case of ohci bus glue was not properly handled as > it was not suspending generic part of ohci controller. Calling > expli

Re: [PATCH V2 0/6] USB: OHCI: more bus glues as separate modules

2013-06-14 Thread Manjunath Goudar
HI Alan, Can you review this patch series. Thanks Manjunath Goudar On 12 June 2013 21:23, Manjunath Goudar wrote: > These patches are for separating the SOC On-Chip ohci host controller > from ohci-hcd host code into its own driver module. > This work is part of enabling multi

Re: [PATCH 10/10] USB: OHCI: Properly handle ohci-spear suspend

2013-06-13 Thread Manjunath Goudar
On 13 June 2013 14:49, Viresh Kumar wrote: > On 13 June 2013 14:41, Manjunath Goudar > wrote: > > Suspend scenario in case of ohci-spear glue was not > > properly handled as it was not suspending generic part > > of ohci controller.Calling explicitly the ohci_suspend()

[PATCH V2 06/10] USB: OHCI: Properly handle ohci-omap suspend

2013-06-13 Thread Manjunath Goudar
without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-omap.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ohci-omap.c b

[PATCH V2 08/10] USB: OHCI: Properly handle ohci-pxa27x suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-pxa27x.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci

[PATCH V2 10/10] USB: OHCI: Properly handle ohci-spear suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-spear.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ohci

[PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-at91.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b

[PATCH V2 09/10] USB: OHCI: Properly handle ohci-sm501 suspend

2013-06-13 Thread Manjunath Goudar
without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-sm501.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-sm501.c b

[PATCH V2 07/10] USB: OHCI: Properly handle ohci-platform suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-platform.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci

[PATCH V2 00/10] USB: OHCI:Properly handle ohci_suspend()routine in bus glue

2013-06-13 Thread Manjunath Goudar
. Manjunath Goudar (10): USB: OHCI: Properly handle ohci-at91 suspend USB: OHCI: Properly handle ohci-s3c2410 suspend USB: OHCI: Properly handle ohci-da8xx suspend USB: OHCI: Properly handle ohci-ep93xx suspend USB: OHCI: Properly handle ohci-exynos suspend USB: OHCI: Properly handle

[PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-13 Thread Manjunath Goudar
away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-exynos.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci

[PATCH V2 04/10] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-ep93xx.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci

[PATCH V2 02/10] USB: OHCI: Properly handle ohci-s3c2410 suspend

2013-06-13 Thread Manjunath Goudar
, return right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-s3c2410.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb

[PATCH V2 03/10] USB: OHCI: Properly handle ohci-da8xx suspend

2013-06-13 Thread Manjunath Goudar
without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-da8xx.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b

[PATCH 04/10] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-ep93xx.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci

[PATCH 06/10] USB: OHCI: Properly handle ohci-omap suspend

2013-06-13 Thread Manjunath Goudar
without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-omap.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ohci-omap.c b

[PATCH 00/10] USB: OHCI:Properly handle ohci_suspend()routine in bus glue

2013-06-13 Thread Manjunath Goudar
. Manjunath Goudar (10): USB: OHCI: Properly handle ohci-at91 suspend USB: OHCI: Properly handle ohci-s3c2410 suspend USB: OHCI: Properly handle ohci-da8xx suspend USB: OHCI: Properly handle ohci-ep93xx suspend USB: OHCI: Properly handle ohci-exynos suspend USB: OHCI: Properly handle

[PATCH 10/10] USB: OHCI: Properly handle ohci-spear suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-spear.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ohci

[PATCH 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-at91.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b

[PATCH 07/10] USB: OHCI: Properly handle ohci-platform suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-platform.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci

[PATCH 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-13 Thread Manjunath Goudar
away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-exynos.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci

[PATCH 08/10] USB: OHCI: Properly handle ohci-pxa27x suspend

2013-06-13 Thread Manjunath Goudar
right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-pxa27x.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci

[PATCH 03/10] USB: OHCI: Properly handle ohci-da8xx suspend

2013-06-13 Thread Manjunath Goudar
without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-da8xx.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b

[PATCH 09/10] USB: OHCI: Properly handle ohci-sm501 suspend

2013-06-13 Thread Manjunath Goudar
without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-sm501.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-sm501.c b

[PATCH 02/10] USB: OHCI: Properly handle ohci-s3c2410 suspend

2013-06-13 Thread Manjunath Goudar
, return right away without executing further. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-s3c2410.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb

Re: [PATCH 03/10] USB: OHCI: Properly handle ohci-da8xx suspend

2013-06-12 Thread Manjunath Goudar
On 12 June 2013 21:24, Sergei Shtylyov wrote: > Hello. > > > On 12-06-2013 19:28, Manjunath Goudar wrote: > > Suspend scenario in case of ohci-da8xx glue was not >> properly handled as it was not suspending generic part >> of ohci controller.Calling explicitly th

[PATCH V2 1/6] USB: OHCI: make ohci-exynos a separate driver

2013-06-12 Thread Manjunath Goudar
multiple usb_create_hcd() from prob funtion. -platform_set_drvdata() called before exynos_ohci_phy_enable(). -ohci_setup() removed because it is called in .reset member of the ohci_hc_driver structure Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Jingoo Han Cc: Kukjin Kim Cc: Greg KH

[PATCH V2 6/6] USB: OHCI: make ohci-s3c2410 a separate driver

2013-06-12 Thread Manjunath Goudar
structure. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig|8 +++ drivers/usb/host/Makefile |1 + drivers/usb/host/ohci-hcd.c | 18 -- drivers/usb/host/ohci-s3c2410.c | 129

[PATCH V2 4/6] USB: OHCI: make ohci-spear a separate driver

2013-06-12 Thread Manjunath Goudar
ohci_hc_driver structure. -debugging stuff isn't needed any more that's what removed. Signed-off-by: Manjunath Goudar Cc: Viresh Kumar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig |8 +++ drivers/usb/host/Makefile

[PATCH V2 2/6] USB: OHCI: make ohci-omap a separate driver

2013-06-12 Thread Manjunath Goudar
(). -Removed ohci_setup() call from usb_hcd_omap_probe() and ohci_omap_reset(). -host_enabled and host_initialized variables aren't used for anything thats what removed. Signed-off-by: Manjunath Goudar Cc: Felipe Balbi Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kerne

[PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-12 Thread Manjunath Goudar
. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig |8 +++ drivers/usb/host/Makefile|1 + drivers/usb/host/ohci-at91.c | 148 +++--- drivers/usb/host/ohci

[PATCH V2 3/6] USB: OHCI: make ohci-omap3 a separate driver

2013-06-12 Thread Manjunath Goudar
ohci_hc_driver structure. -The improper multi-line commenting style written in proper way. ('*' characters aligned in vertically). Signed-off-by: Manjunath Goudar Cc: Anand Gadiyar Cc: Felipe Balbi Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- d

[PATCH V2 0/6] USB: OHCI: more bus glues as separate modules

2013-06-12 Thread Manjunath Goudar
/6 -ohci_setup() has been removed because it is called in .reset member of the ohci_hc_driver structure. Manjunath Goudar (6): USB: OHCI: make ohci-exynos a separate driver USB: OHCI: make ohci-omap a separate driver USB: OHCI: make ohci-omap3 a separate driver USB: OHCI: make ohci

[PATCH 08/10] USB: OHCI: Properly handle ohci-pxa27x suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-pxa27x glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in ohci_hcd_pxa27x_drv_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd

[PATCH 04/10] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-ep93xx glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in ohci_hcd_ep93xx_drv_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd

[PATCH 10/10] USB: OHCI: Properly handle ohci-spear suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-spear glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in spear_ohci_hcd_drv_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd

[PATCH 06/10] USB: OHCI: Properly handle ohci-omap suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-omap glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in ohci_omap_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc

[PATCH 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-exynos glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in exynos_ohci_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann

[PATCH 02/10] USB: OHCI: Properly handle ohci-s3c2410 suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-s3c2410 glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in ohci_hcd_s3c2410_drv_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc

[PATCH 07/10] USB: OHCI: Properly handle ohci-platform suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-platform glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in ohci_platform_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd

[PATCH 09/10] USB: OHCI: Properly handle ohci-sm501 suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-sm501 glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in ohci_sm501_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann

[PATCH 00/10] USB: OHCI:Properly handle ohci_suspend()routine in bus glue

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci bus glue was not properly handled as it was not suspending generic part of ohci controller. Calling explicitly the ohci_suspend()routine will ensure proper handling of suspend scenario. Manjunath Goudar (10): USB: OHCI: Properly handle ohci-at91 suspend

[PATCH 03/10] USB: OHCI: Properly handle ohci-da8xx suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-da8xx glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in ohci_da8xx_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann

[PATCH 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-12 Thread Manjunath Goudar
Suspend scenario in case of ohci-at91 glue was not properly handled as it was not suspending generic part of ohci controller. Calling explicitly the ohci_suspend()routine in ohci_hcd_at91_drv_suspend() will ensure proper handling of suspend scenario. Signed-off-by: Manjunath Goudar Cc: Arnd

Re: [RFC][PATCH 0/7] USB: OHCI: more bus glues as separate modules

2013-06-07 Thread Manjunath Goudar
On 7 June 2013 11:33, Manjunath Goudar wrote: > These patches are for separating the SOC On-Chip ohci host controller > from ohci-hcd host code into its own driver module. > This work is part of enabling multi-platform kernels on ARM. > > Manjunath Goudar (7): > USB: OHCI:

Re: [RFC][PATCH 4/7] USB: OHCI: make ohci-spear a separate driver

2013-06-07 Thread Manjunath Goudar
On 7 June 2013 16:00, Viresh Kumar wrote: > you need to cc spear-de...@list.st.com list for SPEAr patches. > > On 7 June 2013 11:33, Manjunath Goudar > wrote: > > Separate the TI OHCI SPEAr host controller driver from ohci-hcd > > TI ?? > not TI it should ST in

[RFC][PATCH 0/7] USB: OHCI: more bus glues as separate modules

2013-06-06 Thread Manjunath Goudar
These patches are for separating the SOC On-Chip ohci host controller from ohci-hcd host code into its own driver module. This work is part of enabling multi-platform kernels on ARM. Manjunath Goudar (7): USB: OHCI: make ohci-exynos a separate driver USB: OHCI: make ohci-omap a separate

[RFC][PATCH 1/7] USB: OHCI: make ohci-exynos a separate driver

2013-06-06 Thread Manjunath Goudar
Separate the Samsung OHCI EXYNOS host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Jingoo Han Cc: Kukjin Kim Cc: Greg KH Cc

[RFC][PATCH 5/7] USB: OHCI: export ohci_hub_control and ohci_hub_status_data

2013-06-06 Thread Manjunath Goudar
In order to make ohci-at91 and ohci-s3c2410 as a separate driver, ohci_hub_control and ohci_hub_status_data symbol needs to be exported. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux

[RFC][PATCH 3/7] USB: OHCI: make ohci-omap3 a separate driver

2013-06-06 Thread Manjunath Goudar
Separate the TI OHCI OMAP3 host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Anand Gadiyar Cc: Felipe Balbi Cc: Arnd Bergmann Cc: Greg KH Cc

[RFC][PATCH 6/7] USB: OHCI: make ohci-at91 a separate driver

2013-06-06 Thread Manjunath Goudar
Separate the TI OHCI Atmel host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux

[RFC][PATCH 7/7] USB: OHCI: make ohci-s3c2410 a separate driver

2013-06-06 Thread Manjunath Goudar
Separate the Samsung OHCI S3C host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Alan Stern Cc: Greg KH Cc: linux

[RFC][PATCH 4/7] USB: OHCI: make ohci-spear a separate driver

2013-06-06 Thread Manjunath Goudar
Separate the TI OHCI SPEAr host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Viresh Kumar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux

[RFC][PATCH 2/7] USB: OHCI: make ohci-omap a separate driver

2013-06-06 Thread Manjunath Goudar
Separate the TI OHCI OMAP1/2 host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Felipe Balbi Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc

[PATCH V3 1/2] USB: OHCI: make ohci-platform a separate driver

2013-06-03 Thread Manjunath Goudar
ent. In V3: -Directly passed "hcd" argument not required to call ohci_to_hcd() function. Signed-off-by: Manjunath Goudar Acked-by: Alan Stern Cc: Arnd Bergmann Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig |2 +- drivers/usb/host/Makefile

[PATCH V3 2/2] USB: OHCI: add a name for the platform-private field

2013-06-03 Thread Manjunath Goudar
This patch adds an ohci->priv field for private use by OHCI platform drivers. Until now none of the platform drivers has used this private space, but that's about to change in the next patch of this series. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan S

[PATCH V3 0/2] USB: OHCI: Splitting ohci-platform into independent driver

2013-06-03 Thread Manjunath Goudar
) function. Patch 2/2 adds an ohci->priv field for private use by OHCI platform drivers. V2 to V3: No changes. Manjunath Goudar (2): USB: OHCI: make ohci-platform a separate driver USB: OHCI: add a name for the platform-private field drivers/usb/host/Kconfig |2 +- drivers/usb/

[PATCH 2/2] USB: OHCI: add a name for the platform-private field

2013-06-03 Thread Manjunath Goudar
This patch adds an ohci->priv field for private use by OHCI platform drivers. Until now none of the platform drivers has used this private space, but that's about to change in the next patch of this series. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan S

[PATCH 1/2] USB: OHCI: make ohci-platform a separate driver

2013-06-03 Thread Manjunath Goudar
ent. In V3: -Directly passed "hcd" argument not required to call ohci_to_hcd() function. Signed-off-by: Manjunath Goudar Acked-by: Alan Stern Cc: Arnd Bergmann Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig |2 +- drivers/usb/host/Makefile

[PATCH V3 0/2] USB: OHCI: Splitting ohci-platform into independent driver

2013-06-03 Thread Manjunath Goudar
) function. Patch 2/2 adds an ohci->priv field for private use by OHCI platform drivers. V2 to V3: No changes. Manjunath Goudar (2): USB: OHCI: make ohci-platform a separate driver USB: OHCI: add a name for the platform-private field drivers/usb/host/Kconfig |2 +- drivers/usb/

Re: [PATCH V2 1/2] USB: OHCI: make ohci-platform a separate driver

2013-06-02 Thread Manjunath Goudar
On 31 May 2013 19:37, Alan Stern wrote: > On Fri, 31 May 2013 manjunath.gou...@linaro.org wrote: > > > From: Manjunath Goudar > > > > This patch splits the ohci-platform code from ohci-hcd out > > into its own separate driver module.This work is part of enabling

[PATCH V2 2/2] USB: OHCI: add a name for the platform-private field

2013-05-31 Thread manjunath . goudar
From: Manjunath Goudar This patch adds an ohci->priv field for private use by OHCI platform drivers. Until now none of the platform drivers has used this private space, but that's about to change in the next patch of this series. In V2: No changes. Signed-off-by: Manjunath Goudar

[PATCH V2 0/2] USB: OHCI: Splitting ohci-platform into independent driver

2013-05-31 Thread manjunath . goudar
From: Manjunath Goudar This series patch begins the process of splitting ohci-platform up into independent driver modules and add a name for the platform-private field. Patch 1/2 separate ohci-platform into independent driver modules. V1 to V2: Passed "hcd" argment instead of

[PATCH V2 1/2] USB: OHCI: make ohci-platform a separate driver

2013-05-31 Thread manjunath . goudar
From: Manjunath Goudar This patch splits the ohci-platform code from ohci-hcd out into its own separate driver module.This work is part of enabling multi-platform kernels on ARM. In V2: -Passed "hcd" argment instead of "ohci" in ohci_setup() because it is using &quo

Re: [RFC PATCH 2/2] USB: OHCI: add a name for the platform-private field

2013-05-31 Thread Manjunath Goudar
On 30 May 2013 22:56, Alan Stern wrote: > On Thu, 30 May 2013, Manjunath Goudar wrote: > > > This patch adds an ohci->priv field for private use by OHCI > > platform drivers. > > > > Until now none of the platform drivers has used this private space, > >

[RFC PATCH 1/2] USB: OHCI: make ohci-platform a separate driver

2013-05-30 Thread Manjunath Goudar
This patch splits the ohci-platform code from ohci-hcd out into its own separate driver module.This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig

[RFC PATCH 2/2] USB: OHCI: add a name for the platform-private field

2013-05-30 Thread Manjunath Goudar
This patch adds an ohci->priv field for private use by OHCI platform drivers. Until now none of the platform drivers has used this private space, but that's about to change in the next patch of this series. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan S

[PATCH 0/2] USB: OHCI: Splitting ohci-platform into independent driver

2013-05-30 Thread Manjunath Goudar
ers. Manjunath Goudar (2): USB: OHCI: make ohci-platform a separate driver USB: OHCI: add a name for the platform-private field drivers/usb/host/Kconfig |2 +- drivers/usb/host/Makefile|1 + drivers/usb/host/ohci-hcd.c |6 +-- drivers/usb/host/ohci-platform.c |

Re: [PATCH V8 0/3] USB: OHCI: Start splitting up the driver

2013-05-29 Thread Manjunath Goudar
first patch, as I found later. > > > > I'll try to replicate your result. I don't have my USB audio device > > here today, so it will have to wait until tomorrow. > > Strange enough, it seems to be working now, on a different base. > > The kernel I tried

[PATCH V8 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-28 Thread Manjunath Goudar
l does not dependence on STB03xxx, PPC_MPC52xx and USB_OHCI_HCD_PPC_OF. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig|6 +- drivers/usb/host/Makefile |3 + drivers/usb/host/ohci-hc

[PATCH V8 0/3] USB: OHCI: Start splitting up the driver

2013-05-28 Thread Manjunath Goudar
from V7 to V8 no change. Patch 3/3 separate out ohci-pci into independent driver modules. Change from V7 to V8 USB_OHCI_HCD_PCI symbol no longer dependence on STB03xxx, PPC_MPC52xx and USB_OHCI_HCD_PPC_OF that's what removed. Manjunath Goudar (3): USB: OHCI: prepare to make ohc

[PATCH V8 2/3] USB: OHCI: Generic changes to make ohci-pci a separate driver

2013-05-28 Thread Manjunath Goudar
code. -Passed "device" argument instead of "ohci_hcd" in sb800_prefetch() function to avoid extra include file in pci-quirks.c. V2: -Passed "device" argment instead of "pci_dev", then we use to_pci_dev() to get the "pci_dev"

[PATCH V8 1/3] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-28 Thread Manjunath Goudar
ause it is already called in ohci_restart(). In V8: -ohci_hcd_init() is called by ohci_setup() to make generic ohci initialization in all ohci drivers. Signed-off-by: Manjunath Goudar Acked-by: Alan Stern Cc: Arnd Bergmann Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-hc

[RFC V7 PATCH 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-27 Thread Manjunath Goudar
i pci changes moved in 2/3 patch,now this is complete ohci-pci separation patch. V7: -Unrelated include file has been removed from ohci.h file. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig|

[RFC V7 PATCH 2/3] USB: OHCI: Generic changes to make ohci-pci a separate driver

2013-05-27 Thread Manjunath Goudar
code. -Passed "device" argument instead of "ohci_hcd" in sb800_prefetch() function to avoid extra include file in pci-quirks.c. V2: -Passed "device" argment instead of "pci_dev", then we use to_pci_dev() to get the "pci_dev&quo

[RFC V7 PATCH 1/3] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-27 Thread Manjunath Goudar
ause it is already called in ohci_restart(). Signed-off-by: Manjunath Goudar Acked-by: Alan Stern Cc: Arnd Bergmann Cc: Greg KH Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-hcd.c | 103 +++ drivers/usb/host/ohci-hub.c |1 - drivers/usb/host/

[RFC V7 PATCH 0/3] USB: OHCI: Start splitting up the driver

2013-05-27 Thread Manjunath Goudar
code. Moved sb800_prefetch() function from ohci-pci.c to pci-quirks.c file and EXPORTed, this is part of the effort to move the ohci pci related code to generic pci code. Patch 3/3 separate out ohci-pci into independent driver modules. Manjunath Goudar (3): USB: OHCI: prepare to make ohci-hcd

[RFC PATCH 2/3] USB: OHCI: Generic changes to make ohci-pci a separate driver

2013-05-23 Thread Manjunath Goudar
. -Passed "pci_dev" argument instead of "ohci_hcd" in sb800_prefetch() function to avoid extra include file in pci-quirks.c. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-hcd.c | 11 +---

[RFC V6 PATCH 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-23 Thread Manjunath Goudar
i pci changes moved in 2/3 patch,now this is complete ohci-pci separation patch. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- drivers/usb/host/Kconfig |4 +- drivers/usb/host/Makefile |3 + drivers/usb/host/ohci-

[RFC V6 PATCH 1/3] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-23 Thread Manjunath Goudar
ause it is already called in ohci_restart(). Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-...@vger.kernel.org --- drivers/usb/host/ohci-hcd.c | 103 +++ drivers/usb/host/ohci-hub.c |1 - drivers/usb/host/

[RFC V6 PATCH 0/3] USB: OHCI: Start splitting up the driver

2013-05-23 Thread Manjunath Goudar
code. Moved sb800_prefetch() function from ohci-pci.c to pci-quirks.c file and EXPORTed, this is part of the effort to move the ohci pci related code to generic pci code. Patch 3/3 separate out ohci-pci into independent driver modules. Manjunath Goudar (3): USB: OHCI: prepare to make ohci