> This is specific to the acpi and should be handled in the
> processor_idle.c file instead of the cpuidle core code.
>
> Could be the function 'acpi_processor_cst_has_changed' the right place
> to set a dummy power value for the power in the new C-state ?
Thanks for your feedback. I think it woul
On Wed, 2012-10-17 at 20:53 +0530, Viresh Kumar wrote:
> On 16 October 2012 17:14, hongbo.zhang wrote:
[]
> > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c
> > b/drivers/thermal/db8500_cpufreq_cooling.c
[]
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#in
On 17 October 2012 22:28, Joe Perches wrote:
>> > +#include
>> > +#include
>> > +#include
>> > +#include
>> > +#include
>> > +#include
>>
>> should be in alphabetical order
>
> There's no agreed kernel convention here.
> Some prefer christmas tree (shortest to longest length)
:)
I have see
On 10/17/2012 10:41 AM, Tushar Behera wrote:
On 10/06/2012 02:37 AM, Andrey Konovalov wrote:
Greetings,
Minor change to the plan:
* The current llct is *llct-20121006.0*
* October 9: ll rebuild based on llct-20121006.0
* October 16: ll rebuild based on llct-20121012., ll code freeze (no
On 16 October 2012 17:14, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> This diver is based on the thermal management framework in thermal_sys.c.
> A thermal zone device is created with the trip points to which cooling
> devices can be bound, the current cooling device is cpufreq, e.g. CPU
> fre
On 16 October 2012 17:14, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> The cpufreq works as a cooling device, so the cooling layer should
> check and wait until the cpufreq driver is initialized.
Idea is good.
> Signed-off-by: hongbo.zhang
> ---
> drivers/thermal/cpu_cooling.c | 12
On 16 October 2012 17:14, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> Is is not reliable to check the list entry pointer after
> list_for_each_entry loop, list_empty should be used instead.
>
> Signed-off-by: hongbo.zhang
> ---
> drivers/thermal/cpu_cooling.c | 5 +++--
> 1 file changed, 3 i
On 16 October 2012 17:14, hongbo.zhang wrote:
> From: "hongbo.zhang"
People always like to see a commit log here :)
> Signed-off-by: hongbo.zhang
> ---
> drivers/thermal/cpu_cooling.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/driv
Hi Guys,
Can you please have a look at the below patchset? Your review comments
are very necessary and valuable.Thanks in advance.
> This patchset uses the per-entity-load-tracking patchset which will soon be
> available in the kernel.It is based on the tip/master tree and the first 8
> latest pa
On 10/17/2012 12:31 PM, Daniel Lezcano wrote:
> On 10/17/2012 12:39 AM, Julius Werner wrote:
>> When cpuidle drivers do not supply explicit power_usage values,
>> cpuidle/driver.c inserts dummy values instead. When a running processor
>> dynamically gains new C-states (e.g. after ACPI events), the
On 10/17/2012 12:39 AM, Julius Werner wrote:
> When cpuidle drivers do not supply explicit power_usage values,
> cpuidle/driver.c inserts dummy values instead. When a running processor
> dynamically gains new C-states (e.g. after ACPI events), the power_usage
> values of those states will stay unin
On 17 October 2012 15:28, Sudeep KarkadaNagesha
wrote:
> May be kernel/Documentation/dynamic-debug-howto.txt is more up-to-date.
yes.
>> My usecase is a bit different. I want to see all bootprints with
>> cpufreq pr_debug
>> prints. So, this prefixing will help there.
> The document covers "Deb
On 17/10/12 10:39, Viresh Kumar wrote:
On 17 October 2012 14:55, Sudeep KarkadaNagesha
wrote:
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
Quickly went through this :)
http://www.kernel.org/doc/ols/2009/ols2009-page
On 17 October 2012 14:55, Sudeep KarkadaNagesha
wrote:
> With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
> prints at different levels (file, module, line, function)
Quickly went through this :)
http://www.kernel.org/doc/ols/2009/ols2009-pages-39-46.pdf
My usecase is a bit differ
On Wed, 2012-10-17 at 14:18 +0530, Viresh Kumar wrote:
> On 24 August 2012 16:39, Jon Medhurst (Tixy) wrote:
>
> > Sounds OK from my point of view, except that rather than fixed dates
> > each month the should probably be tied to the release dates. E.g. the
> > Monday of the week before release (
On 17/10/12 06:20, Viresh Kumar wrote:
With debug options on, it is difficult to locate cpufreq core's debug prints.
Fix this by prefixing debug prints with:
"cpufreq:"
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
R
On 17/10/12 06:20, Viresh Kumar wrote:
This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the cpufreq subsystem,
This is pretty useful for developers who want to debug cpufreq subsystem and
don't want to editing the Makefile manually each time they want to debug.
You can easily overcome t
On 10/17/2012 07:49 AM, Rafael J. Wysocki wrote:
> On Thursday 11 of October 2012 00:21:31 Daniel Lezcano wrote:
>> The structure cpuidle_state_kobj is not used anywhere except
>> in the sysfs.c file. The definition of this function is not
>
>
>
On 24 August 2012 16:39, Jon Medhurst (Tixy) wrote:
> Sounds OK from my point of view, except that rather than fixed dates
> each month the should probably be tied to the release dates. E.g. the
> Monday of the week before release (the normal WG cut-of date), and two
> weeks before (or after?) th
On Wed, 2012-10-17 at 12:03 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:56, Joe Perches wrote:
> > Oh good, but please use a space between KBUILD_MODNAME
> > and the quoted ": ".
>
> Anything technical behind it or just for code formatting?
Just code formatting though it makes it easier t
On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
> With debug options on, it is difficult to locate cpufreq core's debug prints.
[]
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
[]
> @@ -15,6 +15,8 @@
> +#define pr_fmt(fmt) "cpufreq: " fmt
I'd prefer that
#define pr_f
On Wed, 2012-10-17 at 11:25 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:09, Joe Perches wrote:
> > On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
> >> With debug options on, it is difficult to locate cpufreq core's debug
> >> prints.
> > []
> >> diff --git a/drivers/cpufreq/cpufreq
On Wed, 2012-10-17 at 11:47 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:34, Joe Perches wrote:
> > I believe you are quoting KBUILD_MODNAME
>
> Yes. :(
> Far better output with this. Thanks.
Oh good, but please use a space between KBUILD_MODNAME
and the quoted ": ".
#define pr_fmt(fmt) K
23 matches
Mail list logo
