Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

Great work! http://codereview.appspot.com/1730044/diff/17001/12002 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/1730044/diff/17001/12002#newcode743 scm/define-markup-commands.scm:743: I think this is EXCELLENT work and has enough shared features with the recently-c

Re: Adds announce-end-grob to engraver-scheme.cc (issue1914043)

http://codereview.appspot.com/1914043/diff/6001/7001 File lily/engraver-scheme.cc (right): http://codereview.appspot.com/1914043/diff/6001/7001#newcode26 lily/engraver-scheme.cc:26: " with give @code{grob_name}, a symbol. @code{cause}" On 2010/08/02 22:56:25, Neil Puttock wrote: with given @cod

Re: Adds scheme binding for Side_position_interface::set_axis (issue1880050)

Reviewers: Neil Puttock, Message: I created a binding for chain_callback in grob-scheme.cc. Please see http://codereview.appspot.com/1890044 . I'm fine using this and then maybe making a scheme version of set_axis (i.e. side-position-interface::set-axis) in the appropriate .scm file. First, le

Re: Create ly:grob-chain-callback from chain_callback (issue1890044)

Reviewers: Neil Puttock, http://codereview.appspot.com/1890044/diff/1/2 File lily/grob-scheme.cc (right): http://codereview.appspot.com/1890044/diff/1/2#newcode407 lily/grob-scheme.cc:407: 3, 0, 0, (SCM grob, SCM proc, SCM sym), On 2010/08/04 18:50:59, Neil Puttock wrote: 0, (SCM grob Done.

Build: fix 1167. (issue1929041)

http://codereview.appspot.com/1929041/diff/1/2 File python/auxiliar/postprocess_html.py (right): http://codereview.appspot.com/1929041/diff/1/2#newcode353 python/auxiliar/postprocess_html.py:353: 'href=\"../../../website/development.html\"') s.replace does a greedy search for strings and replace

Re: Adds ly:define-event-class (issue1867050)

Reviewers: Neil Puttock, http://codereview.appspot.com/1867050/diff/17001/18001 File input/regression/scheme-text-spanner.ly (right): http://codereview.appspot.com/1867050/diff/17001/18001#newcode5 input/regression/scheme-text-spanner.ly:5: texidoc = "uses define-event-class to create a fully f

Re: Gets vertical skylines from grob stencils (issue 5626052)

It's back... The only thing that doesn't the work the way I'd expect it is Skyline::padded. It seems to not be adding the padding correctly (Joe - any ideas)? This causes tighter than desired spacing in alignment-order.ly. Other than that it is all reviewable! For those who were keeping score

Re: Gets vertical skylines from grob stencils (issue 5626052)

http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc#newcode693 lily/skyline.cc:693: Skyline::padded (Real horizon_padding) const On 2012/07/01 23:04:17, Keith wrote: The horizon_padding b

Re: Gets vertical skylines from grob stencils (issue 5626052)

http://codereview.appspot.com/5626052/diff/85004/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/85004/lily/skyline.cc#newcode292 lily/skyline.cc:292: Real p1 = left->end_ * left->slope_ + left->y_intercept_; On 2012/07/14 14:01:08, joeneeman wrote: use

Re: Set indent based on instrument name (issue 6457049)

Hey Phil! First and foremost, congrats on this work. I'm thrilled to see you venturing into the C++ side. You're tackling an issue that, while just a few lines of code, uses a lot of advanced LilyPond structures, so it's not easy. My suggestions don't have to do with the math (all of it is fin

Re: Gets vertical skylines from grob stencils (issue 5626052)

Thanks for the review! http://codereview.appspot.com/5626052/diff/105001/input/regression/text-script-vertical-skylines.ly File input/regression/text-script-vertical-skylines.ly (right): http://codereview.appspot.com/5626052/diff/105001/input/regression/text-script-vertical-skylines.ly#newcode5

Re: Gets vertical skylines from grob stencils (issue 5626052)

http://codereview.appspot.com/5626052/diff/105001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5626052/diff/105001/lily/axis-group-interface.cc#newcode778 lily/axis-group-interface.cc:778: Note we only use 75% of padding and apply the full

Re: Gets vertical skylines from grob stencils (issue 5626052)

I've forgotten why I added the horizontal skyline stuff so I've taken it out in a new version that I'll post after regtests. http://codereview.appspot.com/5626052/diff/106004/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5626052/diff/10600

Re: Gets vertical skylines from grob stencils (issue 5626052)

Thanks for the performance tests! I have no problem changing the function avoid_outside_staff_collisions to be faster - it's just that I haven't wrapped my head around how distance alone can do it. http://codereview.appspot.com/5626052/diff/106004/lily/axis-group-interface.cc File lily/axis-gro

bar-line interface part 2/2 (issue 6498052)

LGTM http://codereview.appspot.com/6498052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ledger-line-spanner: symmetric extents; issue 2493 (issue 6490043)

http://codereview.appspot.com/6490043/diff/7001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): http://codereview.appspot.com/6490043/diff/7001/lily/ledger-line-spanner.cc#newcode50 lily/ledger-line-spanner.cc:50: < Paper_column::get_rank (previous_column))) I'm having trou

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

Reviewers: Keith, Message: On 2012/09/01 23:58:37, Keith wrote: I might have a test case for you at http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1776 It seems you copy each slur into a "slur-stub", and from those keep only the ones with "cross-staff" set. Then when figuring system

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

Thanks for the review! http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc#newcode419 lily/axis-group-interface.cc:419: */ On 2012/09/02 15:59:00, dak wro

Re: Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

Reviewers: dak, Message: Thanks for the review! http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode213 lily/self-alignment-interface.cc

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

On 2012/09/02 20:38:28, Keith wrote: On 2012/09/02 06:25:58, MikeSol wrote: > It's not a copy of the original slur because it is using > pure heights and offsets. I saw you interrogating SlurStub regarding its purity, but did not notice that SlurStub took any different shape based on 'pur

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

On 2012/09/03 13:46:33, mike7 wrote: On 3 sept. 2012, at 07:07, mailto:mts...@gmail.com wrote: > On 2012/09/02 20:38:28, Keith wrote: >> On 2012/09/02 06:25:58, MikeSol wrote: > >>> It's not a copy of the original slur because it is using >>> pure heights and offsets. > >> I saw you interrogat

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

The speed problem was twofold - some cruft in callbacks coupled with the fact that I wasn't doing make cleans, so something about the way that gcc was putting together the old .o files was slowing things down. I learned my lesson: always do make clean before testing a patch. A full make clean bri

Re: Allows user to set ChordName text (issue 6496085)

Reviewers: dak, http://codereview.appspot.com/6496085/diff/1/lily/chord-name-engraver.cc File lily/chord-name-engraver.cc (right): http://codereview.appspot.com/6496085/diff/1/lily/chord-name-engraver.cc#newcode83 lily/chord-name-engraver.cc:83: || ly_is_procedure (chord_name_->get_property ("t

Re: spacing-spanner: rods for non-adjacent paper-columns; issue 1700 (issue 6489107)

LGTM - looking forward to the skyline version, as that'll more accurately reflect where columns are overhanging. http://codereview.appspot.com/6489107/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypo

Re: Corrects beamed cross-staff stems' pure heights (issue 6543046)

Reviewers: Keith, Message: I'm gonna hold off on posting to this one as it evolves constantly with my work on issue 2801, which is revealing several issues in cross-staff stem calculations. Irrespective of how issue 2801 pans out, I'll take all the relevant code from stem.cc and either push it a

Caches grob properties before evaluation. (issue 6573066)

Reviewers: , Message: This slows down LilyPond - I haven't done comprehensive tests of how much. I'm pretty sure it works (the regtest works as expected). Irrespective of how multiple passes are done, this seems like a necessary first step. Note that this patch would not have a time impact if i

Re: Various clean-ups in stems and beams. (issue 6584045)

Reviewers: aleksandr.andreev, Message: I think a user should be able to use Kievan notation and normal stems/flags/beams if she so chooses. I'll define something like startKievanNotation = { %% Set glyph styles. \override NoteHead #'style = #'kievan \override Rest #'style = #'mensural \ove

Re: Better alignment of MetronomeMark to MultiMeasureRest (issue 6972044)

Reviewers: Keith, Message: You're right...it was mostly out of laziness and desperation that I did the quick fix...it worked for a piece I was typesetting. I have a long plane ride on the 28th to fix this correctly. https://codereview.appspot.com/6972044/diff/1/lily/metronome-engraver.cc File

Checks for recursive element behavior (issue 6943072)

Reviewers: , Message: Hey all, I'm ok w/ this on the countdown but can someone check out David's suspicion that this slows stuff down by O(n^3)? I definitely won't push this if it slows LilyPond down to a crawl. Cheers, MS Description: Checks for recursive element behavior Please review this

Eliminates the Hara_kiri_engraver. (issue 7061062)

Reviewers: , Message: This doesn't crash in the test case Keith proposed: \new StaffGroup \with { \RemoveEmptyStaves } << { b1 b1 b1} { b1 b1 \break b1 } >> Description: Eliminates the Hara_kiri_engraver. Uses a haraKiri context property in the Axis_group_engraver to acheive the same

Re: Eliminates the Hara_kiri_engraver. (issue 7061062)

"sneaky callback" is not a real concern...it's a pedantic concern. If we're following the model to a T, grob properties should not be read in engravers, just set. The idea is that the engravers are creating the grobs and fixing them up with properties if need be. I prefer duplicating a context a

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

People can review this if they have time...it is a lot of code, but it is more a progress report than anything else. To resume a bit of what's been said before: once translate_axis is called, the dim_cache of grobs is set and it is very difficult to work with approximations. This makes cross-sta

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

Hey all, After letting this newest round sit for a few days, I'm pretty confident that the patch is ready for review so I'd ask people to review it. First, if anyone needs more comments in the code to let them know what's going on, lemme know where and I'll add it. Second, if people have perform

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

New patch set coming after I finish running the regtests. https://codereview.appspot.com/7310075/diff/10/input/regression/skyline-point-extent.ly File input/regression/skyline-point-extent.ly (right): https://codereview.appspot.com/7310075/diff/10/input/regression/skyline-point-extent.ly#newcod

Re: Spacing with empty contexts; issue 1669 (issue 4515158)

https://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc File lily/align-interface.cc (right): https://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc#newcode222 lily/align-interface.cc:222: dy = max (dy, min_distance); On 2011/06/09 02:55:55, Keith wrote: On 20

Make ly:make-unpure-pure-container accept a single callback (issue 7382046)

LGTM, with one suggestion: the difference between unpure and pure functions in LilyPond is that unpure functions accept n arguments whereas pure functions accept n+2. This shortcut you're proposing only works when n=1, which you document, but it'd be nice if it worked for an arbitrary number of in

Re: Uses only unpure-pure containers to articulate unpure-pure relationships. (issue 7377046)

Some code from my patch for issue 3161 is copied over to this patch. The fact that Grob::pure_height returns Interval (0,0) as default causes point stencils to be placed in the skyline, potentially effecting vertical spacing. Separation_item::boxes uses this (0,0) extent to add extra spacing heig

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

https://codereview.appspot.com/7615043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/7615043/diff/1/scm/output-lib.scm#newcode929 scm/output-lib.scm:929: form. @code{x} is the portion of the width consumed for a given line On 2013/03/08 06:26:29, lemzw

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

Thanks for the review! https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly File input/regression/skyline-point-extent.ly (right): https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly#newcode5 input/regression/skyline-p

Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

Reviewers: lemzwerg, dak, mike7, Message: On 2013/03/11 10:18:59, dak wrote: On 2013/03/10 00:32:43, mike7 wrote: > >> > Why is this override needed for the regtest? The other overrides > > are > >> > obvious user-accessible overrides for triggering the tested > >> > functionality. > >> >

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

On 2013/03/13 21:38:59, thomasmorley65 wrote: Hi Mike, sorry to be such an inch pincher. https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm#newcode1061 scm/output-lib.

Re: Allows slurs to break at barlines. (issue 7424049)

The most recent patch set copies direction from SlurEvents and PhrasingSlurEvents, but this doesn't seem to work as intended (it fails silently). Everything else is operational. https://codereview.appspot.com/7424049/ ___ lilypond-devel mailing list l

Re: report a programming error when trying to align on empty parent (issue 7533046)

LGTM https://codereview.appspot.com/7533046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: don't abort aligning when grob's parent is a PaperColumn (issue 7564044)

https://codereview.appspot.com/7564044/diff/9001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/7564044/diff/9001/lily/self-alignment-interface.cc#newcode130 lily/self-alignment-interface.cc:130: // TODO: should this function be def

Re: reorganize self_alignment_interface (issue 7768043)

https://codereview.appspot.com/7768043/diff/19001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/7768043/diff/19001/lily/self-alignment-interface.cc#newcode128 lily/self-alignment-interface.cc:128: /* LilyPond positions every grob r

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

Hey all, Following up to my comment on the tracker, I'd like to not push this until everyone has had a chance to think through David's e-mails about 2.18. I anticipate this needing 2-3 months of user testing to catch and fix any bugs. Given that this is my first big patch since August, it'll li

Re: Page numbering: first page format only on first page of a book (issue 7974046)

LGTM https://codereview.appspot.com/7974046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Eliminates side poisition calculations for system-start-text grobs. (issue 7574048)

On 2013/03/24 19:59:38, dak wrote: On 2013/03/24 19:06:49, mike7 wrote: > On 24 mars 2013, at 14:59, mailto:d...@gnu.org wrote: > > > > > > https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-name-x-align.ly > > File input/regression/instrument-name-x-align.ly (right):

Re: Removes outside-staff-priority from dynamic-related objects in Dynamic context (issue 7655045)

On 2013/03/27 21:50:02, janek wrote: I see that these overrides solve the problem, but it would be nice to know why this works. Can you write an explanation? What was wrong with the skylines that caused this bug? Maybe this is just one instance of a more general problem. Objects that a

Re: reorganize self_alignment_interface (issue 7768043)

In general, I see a lot of reassigning of parents. What is the goal with this (sorry if you've explained this already)? https://codereview.appspot.com/7768043/diff/38001/lily/fingering-engraver.cc File lily/fingering-engraver.cc (right): https://codereview.appspot.com/7768043/diff/38001/lily/f

Re: rewrite Self_alignment_interface (issue 7768043)

I'd recommend adding a sort of padding property to the self-alignment-interface to get it completely there. That is, imagine that we right align to a grob and we want to be padded by 0.1 We should be able to do that. That'd allow self-alignment-interface to be used for grobs like InstrumentName

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely#newcode153 Documentation/changes.tely:153: @item I would add a note that, if there is too-snug spacin

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

On 2013/04/16 07:51:46, dak wrote: On 2013/04/16 07:40:19, Trevor Daniels wrote: > On 2013/04/16 07:20:59, dak wrote: > > On 2013/04/16 06:05:42, MikeSol wrote: > >> I would add a note that, if there is too-snug spacing > >> for an object, setting its vertical skylines to #'() > >> will generally

Add callback factory grob::inherit-parent-property (issue 8726045)

Hey, I hadn't seen this. I just finished writing an equivalent patch. Yours is better, so keep it. You can use this for the inherit-X-parent-visibility and eliminate the inherit-Y-parent-visibility callback, which is cruft and can be replaced with the X one. https://codereview.appspot.com/872604

Re: Flags cross-staff semi ties. (issue 8857043)

On 2013/04/19 12:40:43, Neil Puttock wrote: Hi Mike, Generally LGTM, but since there's nothing in the code which requires C++ code I favour adding a callback to output-lib.scm: (define-public (semi-tie::calc-cross-staff grob) (let* ((note-head (ly:grob-object grob 'note-head))

Adds StemTremolo to the note column's element list. (issue 5067041)

Reviewers: , Message: Hey all, While working on flags, I noticed that horizontal spacing changes when a grob is part of a NoteColumn's element list. I went back to StemTremolos and tested this out: run the code below with and without this patch: \relative c'' { \time 8/4 \autoBeamOff \ov

Re: Sketch for broken beams with consistent slopes (issue 4961041)

All of the previously-reported bugs are now squashed with this newest patchset: the regtests only show two changes that results in things moving (and one change that shows nothing moving but a lot of green...weird), both of which seem to be welcome side effects of the code consolidation in beam-qu

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

Hey Joe, For some reason, the scm files say "Upload in progress." This may come from a MIME type issue for scm files (upload.py doesn't know that scm files correspond to Scheme language files). I forget how to fix this, but I know the fix has been suggested somewhere on the list. Cheers, MS ht

Re: New alist to replace special characters. (issue 4553056)

Hey Bertrand, Could you show an example, in the regtest, of how one would write: – (or whatever) such that – appeared (meaning the string "–" - not the replacement n-dash). http://codereview.appspot.com/4553056/ ___ lilypond-devel mailing list lilyp

Re: Fix 155: parentheses include accidentals and dots. (issue 5047048)

LGTM. http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm#newcode626 scm/output-lib.scm:626: (foo (display "calculating pure y extent")) ¿Qué es? http://codereview.appspot.com/504

Uses Stem::beam_end_corrective to get tremolo heights right (issue 5133042)

Reviewers: , Message: Hey all, This fixes issue 1929 and gets StemTremolo placement correct for beams. I still need to run regtests on it. Cheers, MS Description: Uses Stem::beam_end_corrective to get tremolo heights right Please review this at http://codereview.appspot.com/5133042/ Affected

Fixes to projecthosting_upload.py (issue 5144045)

Reviewers: , Message: Here are some proposed changes to porjecthosting_upload.py that should help avoid spurious issue creation. Graham - is there a good way to test this code w/o creating issues on the tracker, and is there a way I can have push access to your repo on github so that I can push

Re: Fix 1477: Add (ly:expect-warning msg args) to suppress expected warnings (issue 5037046)

LGTM It'd be great to see the regtests run with -dwarning-as-error now that you've done all this work. Is that possible to incorporate into this patch? Cheers, MS http://codereview.appspot.com/5037046/ ___ lilypond-devel mailing list lilypond-devel@

Re: Removes closeness-factor from the Slur details list. (issue 4825051)

Hey all, I haven't heard anything on this for a bit and wanted to know if people could have a look at it. Cheers, MS http://codereview.appspot.com/4825051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/

Re: Removes closeness-factor from the Slur details list. (issue 4825051)

Hey all, I haven't heard anything on this for a bit and wanted to know if people could have a look at it. Cheers, MS http://codereview.appspot.com/4825051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/

Re: Sketch for broken beams with consistent slopes (issue 4961041)

Hey all, I've already heard back from Neil about this patch - he's gonna have a look at it if/when he has a spare moment (he's busy these days). I would really appreciate some review on this - please give it a look over if you have some time! Cheers, MS http://codereview.appspot.com/4961041/

Re: Sketch for fix of issue 307 (issue 4813048)

On 2011/09/30 12:51:38, J_lowe wrote: Hello, On Fri, Sep 30, 2011 at 12:01 AM, Reinhold Kainhofer wrote: > Am Thursday, 29. September 2011, 23:30:20 schrieb pkx1...@gmail.com: >> Passes make but fails make check >> >> --snip-- >> >> job 4 terminated with signal:

Re: Fixes footnote automatic numbering. (issue 4877041)

Hey Reinhold et al, This newest patch set should do the trick for automatic numbering. Cheers, MS http://codereview.appspot.com/4877041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

First stab at getting bar extents right. (issue 5186049)

Reviewers: , Message: Hey all, I'm trying to use my new pure-from-neighbor functions to get bar extents right. Currently, barlines are able to block ledger lines from trailing over because of extra height added to the horizontal skylines in NonMusicalPaperColumn. However, they do not block acc

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

Reviewers: J_lowe, Message: On 2011/10/06 19:41:26, J_lowe wrote: passes make but I get a programming error show up on make check (as well as half a dozen reg test diffs). See attached http://code.google.com/p/lilypond/issues/detail?id=1956#c1 All these are fixed. Now, the only diffs

First stab at getting script offsets right. (issue 5235052)

Reviewers: , Message: Hey all, This patch fixes issue 1951 but causes other problems (check out accidental-suggestions.ly). Does anyone have any intuition as to where the cyclic dependencies are coming from (I don't see how Scripts would rely on AccidentalSuggestions and vice versa in this patc

Re: First stab at getting script offsets right. (issue 5235052)

Hey all, The newest patchset adds a debug function to bug.cc. I'd push it as a separate commit - it has helped me a lot with this & other patches & I'd like to keep it in the code base. Cheers, MS http://codereview.appspot.com/5235052/ ___ lilypond-

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

This new patch set eliminates all regtest diffs via a mechanism that allows extremal lyrics to be flush with the left edge. It kinda sorta bends LilyPond into doing something it is not designed to do :: returning pureY-extents for items that are dependent on the start and end positions (normally,

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

I got a little ahead of myself...the patch, while it works in the regtest cases, does not work the way I think it did because all Items' pure heights are calculated from 0 to INT_MAX in Separation_item::boxes. Certain NonMusicalPaperColumns' horizontal skylines will change depending on if they be

Sketch for in-notes. (issue 5293053)

Reviewers: , Message: Hey all, As part of project markup & at the suggestion of Nicolas Sceaux by way of Valentin's opera, I've implemented in-notes in LilyPond. These notes hover above systems and come up a fair bit in vocal music. It works, but I have one major and one semi-major snag that I

Re: Sketch for in-notes. (issue 5293053)

The memory management issue is now fixed. A new patch will be coming down the pipe in 2-3 hours with a regtest. Cheers, MS http://codereview.appspot.com/5293053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/list

Re: Sketch for in-notes. (issue 5293053)

Hey all, The patch is now ready to be tested - I got a clean bill of health from the regtests. Cheers, MS http://codereview.appspot.com/5293053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-de

Re: Sketch for in-notes. (issue 5293053)

I'm not sure how to deal with some of the "déBordage" of line lengths - you're right that they're ugly, but I dont' see how to chop them down & stay within good code style. Thanks for the review! ~Mike http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc File lily/page-l

Re: Adds Scheme function for spring constructor. (issue 5306050)

Reviewers: Bertrand Bordage, Neil Puttock, dak, Message: Hey all, I've made all of the requested changes save Spring::equal_p, as I can't see a clear consensus about what changes need to be made here. As this problem is outside the purview of this patch, it may be worth it to propose another pa

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

Thanks for your work on this James! Cheers, MS http://codereview.appspot.com/5315053/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/1/Documentation/notation/input.itely#newcode1025 Documentation/notation/inp

Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

Reviewers: Keith, mike_apollinemike.com, Message: All problems fixed and ready for a review. A few things: 1) please ignore the commented out printf statements. i use them for debugging, and i'll delete them before pushing. 2) the regtest may be a little excessive :) unless people think this

Re: Sketch for broken beams with consistent slopes (issue 4961041)

Thanks for the comments! Just a technical note - this issue was closed after the patch was pushed to current master, but I don't mind opening it again to continue a discussion about what this patch (if Colin has no objections). The code I'm dealing with in beam-quanting and beam is difficult to d

Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

Reviewers: , Message: Hey all, This fixes the SpanBar regression ID'd by Phil. It also fixes a few other things: 1) The research I sent out about accidentals not hanging over barlines (check my e-mails to the list from Oct. 6, Subject: First stab at getting bar extents right) is actualize

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely#newcode1049 Documentation/notation/input.itely:1049: @qq{bottom left} and @qq{t

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

On 2011/11/02 06:10:38, J_lowe wrote: 4th Draft. Thanks Graham. @Mike Solomon: I'd still like an example on how to autofootnote top-level markup if you can, so I can remove that technically inaccurate statement. Just in case you missed it, I'd like to use the same example as I use for

Fixes issue 2005 (too much script padding between certain scripts and accidental) (issue 5328063)

Reviewers: , Message: Hey all, This is my fault - sorry for it. For some reason, the Mozart Horn concerto does not show up in my regtest comparisons - otherwise I would have spotted this. Is this normal/intentional behavior? If the Mozart horn concerto is not supposed to show up, I can add a

Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

On 2011/11/04 07:43:07, Keith wrote: On 2011/11/02 10:19:10, http://mike_apollinemike.com wrote: > http://codereview.appspot.com/5293060/diff/19014/lily/beam-quanting.cc#newcode743 > >>> lily/beam-quanting.cc:743: if (do_initial_slope_calculations_) > >>> Even if we made an earlier pass, and a

Caches pure translations for full score. (issue 5349043)

Reviewers: , Message: Hey all, A small patch to speed up LilyPond for large scores. Some benchmarks: \version "2.15.17" foo = \relative c'' { \repeat unfold 1200 { 8-.^"foo"\pp^\espressivo\glissando[ ( -.^"foo"\p^\espressivo )] } } << \new Staff \foo CURRENT MASTER real0m36.

Re: Caches pure translations for full score. (issue 5349043)

Just tried this out on a real score - the 4th movement of the Eroica on mutopia. CURRENT MASTER real4m30.352s user4m21.088s WITH PATCH real2m4.457s user2m0.148s w00t! http://codereview.appspot.com/5349043/ ___ lilypond-devel mailin

Makes line-breaking possibilities more available to grobs (issue 5353047)

Reviewers: , Message: Hey all, This is the first step in a series of patches that I'm gonna try to develop to create a TextScriptSpanner - a TextScript that automatically word wraps to the end of a line break and thus doesn't cause oddly deformed lines when markups fall towards the end of a line

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc File lily/pure-from-neighbor-interface.cc (right): http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode84 lily/pure-from-neighbor-interface.cc:84: // uses drul array for

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

As always, many thanks for your comments! http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc#newcode72 lily/pure-from-neighbor

Fixes certain undocumented properties. (issue 5412050)

Reviewers: , Message: Should compile clean. My apologies in advance if it breaks the regtests - haven't had a chance to compile it on the road. If miraculously it speeds them up, lemme know! Cheers, MS Description: Fixes certain undocumented properties. Please review this at http://coderevie

Better pure heights for slurs (issue 5431065)

Reviewers: , Message: Hey all, I'm not sure if this patch will make a big difference, but it should help the pure height problem a little bit. Before, pure heights were calculated using the entire height of the slur. For slurs with a slope, this is an overshoot. I thus use an estimate of the

Asserts that footnotes are being numbered correctly. (issue 5433065)

Reviewers: , Message: Hey all, This patch helps make sure that the footnote auto-number regtests actually test what they purport to be testing by allowing a callback to check if footnote grobs are receiving the correct automatic number. Cheers, MS Description: Asserts that footnotes are being

Re: Doc: NR Added new node for Custom Footnotes (issue 5433064)

LGTM. http://codereview.appspot.com/5433064/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5433064/diff/1/Documentation/notation/input.itely#newcode1038 Documentation/notation/input.itely:1038: footnotes (plural) http://

Uses the pure-from-neighbor-interface for NonMusicalPaperColumn horizontal spacing. (issue 5432070)

Reviewers: , Message: This is the second of the three-part pure-from-neighbor-interface code rewrite. It uses extra-spacing-height for certain important non-musical grobs in order to prevent other grobs for passing over or under them via the pure-from-neighbor-interface. The last step, after th

Re: Uses the pure-from-neighbor-interface for NonMusicalPaperColumn horizontal spacing. (issue 5432070)

Sorry, forgot to mention that for the time being this only applies cleanly to the staging branch. It'll apply cleanly to master once master is fast-forwarded. http://codereview.appspot.com/5432070/ ___ lilypond-devel mailing list lilypond-devel@gnu.or

Re: Better pure heights for slurs (issue 5431065)

I've uploaded a new patch set where I've eliminated the 0.5 * height_limit. This will likely make slur pure heights worse (meaning they'll overshoot more), but I cannot find a good rationale for why the 0.5 was there in the first place so I took it out. http://codereview.appspot.com/5431065/ __

Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)

Reviewers: , Message: I'm not sure if this is the best way to go about it, but it seems to get the job done! Cheers, MS Description: Allows for automatic renumbering of measure numbers at volta repeats. Please review this at http://codereview.appspot.com/5440049/ Affected files: M lily/bar-

  1   2   3   4   5   >