On 2013/03/24 19:59:38, dak wrote:
On 2013/03/24 19:06:49, mike7 wrote:
> On 24 mars 2013, at 14:59, mailto:d...@gnu.org wrote:
>
> >
> >
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-name-x-align.ly
> > File input/regression/instrument-name-x-align.ly (right):
> >
> >
>
https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-name-x-align.ly#newcode33
> > input/regression/instrument-name-x-align.ly:33: \set Staff .
> > instrumentName = \markup \right-column {
> > Make no mistake: the previous code looked suspiciously asymmetric.
Is
> > your change a cosmetic one, or is it related to other strange
behaviors
> > like the \left-column/\column mismatch we had noticed elsewhere?
> >
> > https://codereview.appspot.com/7574048/
>
> The latter - I noticed it clashed and have run into problems with
right column
> in the past and decided to get rid of it.
> I can put it in a different commit before pushing this one.
In general, separate issues should be separate commits even if you
don't want to
start a tracker issue of its own for it.
Since one wants to be able to pinpoint stuff by bisection, the regtest
change
should be in a commit before the rest.
Will do - I'll push this as two separate commits.
Cheers,
MS
https://codereview.appspot.com/7574048/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
