Phil Holmes philholmes.net> writes:
> There are a number of significant changes, and 2 or 3 possible regressions.
> Please look and check.
Almost all of these are from the revert of Pál's first attempt at issue 2553.
'arpeggio-no-staff' and other moving time-signatures
all the minor slur change
http://codereview.appspot.com/6422061/diff/1/lily/volta-engraver.cc
File lily/volta-engraver.cc (right):
http://codereview.appspot.com/6422061/diff/1/lily/volta-engraver.cc#newcode159
lily/volta-engraver.cc:159: SCM glyph = endbar ? endbar->get_property
("glyph-name") : SCM_EOL;
This lookup migh
On 2012/08/04 06:34:57, Keith wrote:
I'm pouting a little that this moves further from the ability to write
\violin1mvt3a = { c d }
but it still looks fine to me.
While I agree that allowing digits into identifiers would not make sense
unless one gets them allowed in all modes (or the whole
Keith OHara writes:
> Phil Holmes philholmes.net> writes:
>
>> There are a number of significant changes, and 2 or 3 possible regressions.
>> Please look and check.
>
> Almost all of these are from the revert of Pál's first attempt at
> issue 2553.
Perhaps it would make sense for Phil to do a
On 2012/08/01 06:45:22, MikeSol wrote:
Avoid measuring extents when engraving is happening because they could
be
dependent on other callbacks which could trigger many layout decisions
before
engraving is finished.
This is a case where measuring extents early seems appropriate.
Phil wants
On 2012/08/04 07:28:29, Keith wrote:
On 2012/08/01 06:45:22, MikeSol wrote:
> Avoid measuring extents when engraving is happening because they
could be
> dependent on other callbacks which could trigger many layout
decisions before
> engraving is finished.
>
This is a case where measuri
On Sat, 04 Aug 2012 00:37:21 -0700, wrote:
On 2012/08/04 07:28:29, Keith wrote:
On 2012/08/01 06:45:22, MikeSol wrote:
> Avoid measuring extents when engraving is happening because they
could be
> dependent on other callbacks which could trigger many layout
decisions before
> engraving
On 2012/08/03 09:35:47, dak wrote:
The obvious way would be to reorganize into fewer layers.
No. This is a long and complicated subsubsec and the point
of this issue is to improve clarity. The best way of doing
that is to introduce structure into the very long text. In
particular we need to
On 2012/08/04 08:06:38, Trevor Daniels wrote:
On 2012/08/03 09:35:47, dak wrote:
> The obvious way would be to reorganize into fewer layers.
No. This is a long and complicated subsubsec
Reorganizing into fewer layers would mean reorganizing the containing
structure so that we don't alrea
Am 03.08.2012 21:40, schrieb Marc Hohl:
[...]
Programmierfehler: vertical alignment called before line breaking
Fortsetzung, die Daumen drücken
when I try to compile a score with a span bar:
To answer my own question: the extent for span bars is calculated
elsewhere, so (get-grob-property grob
On 2012/08/04 08:27:10, dak wrote:
But again: the real issue to me seems that we are
hiding a long chapter inside of a subsubsec already.
I agree. But to fix that would require rewriting pretty
well the whole of chapter 1 of the NR. I'm not going to
do that. Let's just fix this simple issue
On 2012/08/04 09:20:57, Trevor Daniels wrote:
On 2012/08/04 08:27:10, dak wrote:
> But again: the real issue to me seems that we are
> hiding a long chapter inside of a subsubsec already.
I agree. But to fix that would require rewriting pretty
well the whole of chapter 1 of the NR. I'm no
Il 24/07/2012 16:56, John Mandereau ha scritto:
Il giorno lun, 16/07/2012 alle 14.57 +0200, Federico Bruni ha scritto:
info manuals are only in english?
I can't see other languages in /usr/share/info
both info and yelp show only the english version of the manual
how can I see another language?
- Original Message -
From: "John Mandereau"
To: "Lily devel"
Sent: Friday, August 03, 2012 11:39 PM
Subject: PATCHES: Brain surgery on the build system, first stage
[big snip]
Hi John - is this patch designed to fix problems like:
http://lists.gnu.org/archive/html/lilypond-devel/2011
- Original Message -
From: "Keith OHara"
To:
Sent: Saturday, August 04, 2012 8:01 AM
Subject: Re: 2.15.42 regtests
Phil Holmes philholmes.net> writes:
There are a number of significant changes, and 2 or 3 possible
regressions.
Please look and check.
Almost all of these are from
Hi Phil,
Le samedi 04 août 2012 à 14:02 +0100, Phil Holmes a écrit :
> Hi John - is this patch designed to fix problems like:
>
> http://lists.gnu.org/archive/html/lilypond-devel/2011-11/msg00360.html
Yes, exactly; the commit that adresses this issue is among the four top
commits in dev/jmanderea
Hi John,
thanks for working on this; it has been long overdue.
Small random comments:
* is there a need for vc-clean at all? People can just git clone the
repo when they want to have a clean tree.
* you may want to reindent this properly and use && for sequential execution
case "$(OUT_
- Original Message -
From: "John Mandereau"
To: "Phil Holmes"
Cc: "Lily devel"
Sent: Saturday, August 04, 2012 2:55 PM
Subject: Re: PATCHES: Brain surgery on the build system, first stage
Hi Phil,
Le samedi 04 août 2012 à 14:02 +0100, Phil Holmes a écrit :
Hi John - is this patch d
On 2012/08/04 09:33:33, dak wrote:
I don't see that ignoring even the proposal to use
a combination of structuring commands with explicit
markup is "the best course available".
I'm sorry - I completely missed this. Probably because
I was hung up by the earlier sneer and didn't take in
much el
Phil Holmes wrote Saturday, August 04, 2012 2:34 PM
> I looked there, but couldn't see the changes. The volta end mark is OK, I
> think, but the extra open repeat is definitely a bug, IMHO. If you agree,
> I'll add it to the tracker.
I, for one, agree the open repeat at the end of the previo
On 2012/08/04 15:11:55, Trevor Daniels wrote:
On 2012/08/04 09:33:33, dak wrote:
I'm sorry - I completely missed this. Probably because
I was hung up by the earlier sneer and didn't take in
much else. Since you ask, the bit that affected me was
> A heading indented as opposed to the follo
Han-Wen Nienhuys writes:
> Hi John,
>
> thanks for working on this; it has been long overdue.
>
> Small random comments:
>
> * is there a need for vc-clean at all? People can just git clone the
> repo when they want to have a clean tree.
git clean -f -X
--
David Kastrup
_
- Original Message -
From: "John Mandereau"
To: "Phil Holmes"
Cc: "Lily devel"
Sent: Saturday, August 04, 2012 2:55 PM
Subject: Re: PATCHES: Brain surgery on the build system, first stage
Hi Phil,
Le samedi 04 août 2012 à 14:02 +0100, Phil Holmes a écrit :
Hi John - is this patch d
On 4 août 2012, at 09:28, k-ohara5...@oco.net wrote:
> On 2012/08/01 06:45:22, MikeSol wrote:
>
>> Avoid measuring extents when engraving is happening because they could
> be
>> dependent on other callbacks which could trigger many layout decisions
> before
>> engraving is finished.
>
>
> This
Hi Felipe,
I got go-enc2ly such that it prints useful output for simple scores (try eg.
http://www.samba-choro.com.br/partituras/porartista/vermusica?mid=8544&pos=156
); there are some installation instructions at
https://github.com/hanwen/go-enc2ly/blob/master/README
Your further exploration
On Sat, Aug 4, 2012 at 3:41 PM, Han-Wen Nienhuys wrote:
> Hi Felipe,
>
> I got go-enc2ly such that it prints useful output for simple scores (try eg.
> http://www.samba-choro.com.br/partituras/porartista/vermusica?mid=8544&pos=156
> ); there are some installation instructions at
>
> https://gith
OK, I think we've arrived at an acceptable solution,
albeit via a somewhat circuitous route, posted as patch
set 2.
I'll wait to see how this looks in the pdf version and
if all is well I'll add this recipe to the CG and change
the couple of other places where this level of structuring
is used.
This is definitely not an elegant approach to the problem at all (and it
does not solve the issue of the warning being given out at stem.cc line
128), but it's the best I can figure out after hacking at the code for a
while.
Perhaps reviewers more familiar with LilyPond internals can provide some
28 matches
Mail list logo
