Re: First-time pushing a patch

2011-11-09 Thread David Kastrup
Ian Hulin writes: > I finally got my ssh access to savannah sorted yesterday, and I've got a > small patch which has just gone in review and which James has marked as > Patch-review. Now *assuming* the patch stands up to review, it would be > ready to push in the next few days. > > I normally li

Re: First-time pushing a patch

2011-11-09 Thread Peekay Ex
David, On Wed, Nov 9, 2011 at 8:58 AM, David Kastrup wrote: ... > > [Diversion: by the way, Phil and Graham?  I have come to the conclusion >  that it is better if Patchy does not attempt any rebases or merges on >  its own.  Can you change that accordingly?  It should quite simplify >  Patchy

Re: First-time pushing a patch

2011-11-09 Thread David Kastrup
Peekay Ex writes: > David, > > On Wed, Nov 9, 2011 at 8:58 AM, David Kastrup wrote: > > ... > >> >> [Diversion: by the way, Phil and Graham?  I have come to the conclusion >>  that it is better if Patchy does not attempt any rebases or merges on >>  its own.  Can you change that accordingly?  It

what should patchy do for staging?

2011-11-09 Thread Graham Percival
On Wed, Nov 09, 2011 at 09:58:56AM +0100, David Kastrup wrote: > [Diversion: by the way, Phil and Graham? I have come to the conclusion > that it is better if Patchy does not attempt any rebases or merges on > its own. Can you change that accordingly? It should quite simplify > Patchy and

Re: what should patchy do for staging?

2011-11-09 Thread David Kastrup
Graham Percival writes: > On Wed, Nov 09, 2011 at 09:58:56AM +0100, David Kastrup wrote: >> [Diversion: by the way, Phil and Graham? I have come to the conclusion >> that it is better if Patchy does not attempt any rebases or merges on >> its own. Can you change that accordingly? It should

Re: Glyphs for Kievan Notation (issue 4951062)

2011-11-09 Thread pkx166h
On 2011/10/18 17:46:23, Bertrand Bordage wrote: LGTM. Two tiny changes and it'll be ready to push. That was three weeks ago. Is this done? I still see the tracker open, Janek owns that http://code.google.com/p/lilypond/issues/detail?id=1873 but he is away so I am chasing the state of this.

Re: what should patchy do for staging?

2011-11-09 Thread Graham Percival
On Wed, Nov 09, 2011 at 01:25:24PM +0100, David Kastrup wrote: > Sorry to be a pest. I am currently queuing up half a dozen of other > issues/patches, and will likely need several releases to get the > respective conversions done in reasonable proximity to their changes. You're not a pest, and we

Re: Glyphs for Kievan Notation (issue 4951062)

2011-11-09 Thread aleksandr . andreev
That is done, but before updating I wanted to resolve a few other issues. However, I cannot figure out how to control the amount of spacing between notes (I need the notes in a phrasing slur to be closer together). Also, I can't get the beams to show properly. http://codereview.appspot.com/495106

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-09 Thread m...@apollinemike.com
On Nov 8, 2011, at 10:16 PM, k-ohara5...@oco.net wrote: > > http://codereview.appspot.com/5323062/diff/39005/lily/pure-from-neighbor-engraver.cc > File lily/pure-from-neighbor-engraver.cc (right): > > http://codereview.appspot.com/5323062/diff/39005/lily/pure-from-neighbor-engraver.cc#newcode60

Re: what should patchy do for staging?

2011-11-09 Thread David Kastrup
Graham Percival writes: > On Wed, Nov 09, 2011 at 09:58:56AM +0100, David Kastrup wrote: >> [Diversion: by the way, Phil and Graham? I have come to the conclusion >> that it is better if Patchy does not attempt any rebases or merges on >> its own. Can you change that accordingly? It should

can't release 2.15.17 due to translators

2011-11-09 Thread Graham Percival
can somebody fix this? and depending on dak, either push directly to master (which means he has to play yet more games with dev/staging), or push to dev/staging and then wait for James to do his stuff and then I'll try making 2.15.17 again then. file from VC not distributed: lilypond-2.15.17/Doc

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-09 Thread pkx166h
passes make and reg test diffs are all here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-9-Nov-2011-td4962666.html James http://codereview.appspot.com/5323062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org h

Re: Fix issue 11 -- beamlet points in wrong direction on tuplet (issue 4941041)

2011-11-09 Thread pkx166h
Carl, I reran the patch again on a new build but still only got that one reg test show up. So running lilypond directly on the reg tests I have attached them here http://code.google.com/p/lilypond/issues/detail?id=11#c31 James http://codereview.appspot.com/4941041/ __

Re: can't release 2.15.17 due to translators

2011-11-09 Thread David Kastrup
Graham Percival writes: > can somebody fix this? and depending on dak, either push directly > to master (which means he has to play yet more games with > dev/staging), dev/staging is in a reasonably calm state right now and would be easy to rebase. But what's the advantage? > or push to dev/s

Re: can't release 2.15.17 due to translators

2011-11-09 Thread Graham Percival
On Wed, Nov 09, 2011 at 10:18:08PM +0100, David Kastrup wrote: > Graham Percival writes: > > > can somebody fix this? and depending on dak, either push directly > > to master (which means he has to play yet more games with > > dev/staging), > > dev/staging is in a reasonably calm state right no

mem leak problem

2011-11-09 Thread m...@apollinemike.com
Hey all, iIm running regtests on a new version of a footnote patch and it's slowing down like craaazzy. This has happened to me before, and the cause is always some sorta memory leak, but i always stumble upon them haphazardly and by luck. Is there a profiling tool i can use to show memory le

Re: Fixes footnote automatic numbering. (issue 4877041)

2011-11-09 Thread dak
http://codereview.appspot.com/4877041/diff/25001/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/4877041/diff/25001/lily/grob.cc#newcode639 lily/grob.cc:639: if (!vag) How is vag supposed to have become false again after being true two lines before? http://codereview.appsp

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-09 Thread k-ohara5a5a
http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc#newcode72 lily/pure-from-neighbor-engraver.cc:72: //first, clump pure_releva

Re: Fixes footnote automatic numbering. (issue 4877041)

2011-11-09 Thread pkx166h
See http://code.google.com/p/lilypond/issues/detail?id=1791#c10 Patch fails make check James http://codereview.appspot.com/4877041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

2011-11-09 Thread k-ohara5a5a
On 2011/08/30 16:28:28, mikesol_ufl.edu wrote: On Aug 30, 2011, at 5:53 PM, mailto:joenee...@gmail.com wrote: > Correct me if I'm wrong, but this is my understanding: wherever there's > a SpanBar, you're creating SpanBarStubs between every relevant pair of > staves. These don't actually ge