Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)

Reviewers: , Message: Hi, This is a try to increase performance, especially under Windows (see http://code.google.com/p/lilypond/issues/detail?id=1926). As I don't use Windows to compile LilyPond, can someone test it? Regards, Bertrand Description: Optimizes note-heads.cc and introduces robus

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

Reviewers: J_lowe, Message: On 2011/10/06 19:41:26, J_lowe wrote: passes make but I get a programming error show up on make check (as well as half a dozen reg test diffs). See attached http://code.google.com/p/lilypond/issues/detail?id=1956#c1 All these are fixed. Now, the only diffs

Re: Improves some parmesan noteheads. (issue 4639065)

http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode855 lily/stem.cc:855: if (attach && !scm_is_eq (style, ly_symbol2scm ("mensural")) I meant: the stem is aligned to the right of the attach

Re: Glyphs for Kievan Notation (issue 4951062)

Here's the second part of my review. I saw that kievan notation has beams, contrary to what I thought. If you're intrepid, you can also try to implement the kievan beaming parameters in you KievanVoice. Hold on, it's the end! Bertrand http://codereview.appspot.com/4951062/diff/64002/mf/parmes

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

- Original Message - From: To: Cc: ; Sent: Friday, October 07, 2011 10:37 AM Subject: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042) Reviewers: , Message: Hi, This is a try to increase performance, especially under Windows (see http://code.google.com

Fw: Issue 1926 in lilypond: 2.15.12 processing speed problems

- Original Message - From: To: Sent: Friday, October 07, 2011 10:40 AM Subject: Re: Issue 1926 in lilypond: 2.15.12 processing speed problems Updates: Labels: Patch-new Comment #9 on issue 1926 by bordage.bertrand: 2.15.12 processing speed problems http://code.google.com/p/lilypon

Re: Fw: Issue 1926 in lilypond: 2.15.12 processing speed problems

On Fri, Oct 07, 2011 at 12:29:03PM +0100, Phil Holmes wrote: > >You received this message because you starred the issue. > >You may adjust your notification preferences at: > >https://code.google.com/hosting/settings > > > >Reply to this email to add a comment or make updates. > > I think the mess

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

On Fri, Oct 07, 2011 at 12:27:52PM +0100, Phil Holmes wrote: > AFAIK, the only way to get a Windows build is with GUB - so it's > pretty much only Graham who can do this. Please correct me if I'm > wrong, and I'll test it if I can get an .exe. Anybody with a fast computer running lilydev can buil

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; Sent: Friday, October 07, 2011 12:52 PM Subject: Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042) On Fri, Oct 07, 2011 at 12:27:52PM +0100, Phil Holmes wrote: AFAIK, the only w

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

On Fri, Oct 07, 2011 at 01:10:56PM +0100, Phil Holmes wrote: > I'm up for it. I can download that. I'd appreciate Unix > newbie-level instructions. git repo is here: https://github.com/janneke/gub github has great docs for starting with git, so look there if you have trouble downloading it. On

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

Graham Percival writes: > On Fri, Oct 07, 2011 at 01:10:56PM +0100, Phil Holmes wrote: >> I'm up for it. I can download that. I'd appreciate Unix >> newbie-level instructions. > > git repo is here: > https://github.com/janneke/gub > > github has great docs for starting with git, so look there i

Re: PATCH: Countdown to 20111006

On 11-10-07 12:56 AM, m...@apollinemike.com wrote: On Oct 5, 2011, at 5:01 AM, Colin Campbell wrote: For 22:00 MDT Thursday October 6th Issue 1952 : Patch: Sketch for broken beams with consistent slopes - R 4961041

Strike 1 music functionization...

Hi, I've tried reworking the syntax such that \mark can become a syntax function. What a nuisance. Here is the short breakdown: \mark has an argument of syntax class scalar. Likely unbeknown to most people, a scalar can include oddities like "A"+"B" (string concatenation). Trying to rework th

Re: Strike 1 music functionization...

On Oct 7, 2011, at 3:51 PM, David Kastrup wrote: > > Hi, > > I've tried reworking the syntax such that \mark can become a syntax > function. What a nuisance. > > Here is the short breakdown: \mark has an argument of syntax class > scalar. > > Likely unbeknown to most people, a scalar can incl

Re: Strike 1 music functionization...

"m...@apollinemike.com" writes: > I don't see this being a problem. Most of the work we'll be doing > will start on the music stream, well after the parser's finished doing > its thing. As long as (markup? "x") and (markup-list? '()) still can sensibly return #t with your changes, things will m

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; Sent: Friday, October 07, 2011 1:41 PM Subject: Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042) On Fri, Oct 07, 2011 at 01:10:56PM +0100, Phil Holmes wrote: I'm up for it. I

Re: Glyphs for Kievan Notation (issue 4951062)

I'm trying to implement beams, but I get this message: "must have Item for spanner bound of Beam" What does this refer to? A On Fri, Oct 7, 2011 at 6:29 AM, wrote: > Here's the second part of my review.  I saw that kievan notation has > beams, contrary to what I thought.  If you're intrepid,

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

On Fri, Oct 07, 2011 at 05:25:54PM +0100, Phil Holmes wrote: > Looks like it's trying to download > http://kernel.org/pub/software/scm/git/git-1.6.4.4.tar.gz and > failing to find it - I don't think it's there now. Agreed... every year or so I delete my downloads/ dir to force it to download ever

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; Sent: Friday, October 07, 2011 5:52 PM Subject: Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042) On Fri, Oct 07, 2011 at 05:25:54PM +0100, Phil Holmes wrote: Looks like it's t

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

On Fri, Oct 07, 2011 at 06:20:01PM +0100, Phil Holmes wrote: > Best more official copy seems to be at > http://code.google.com/p/git-core/downloads/list but this only goes > back to 1.7.6.4 agreed. > Any preference? Is it worth caching a copy ourselves? I don't think it's worth keeping a copy o

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

On 10/7/11 11:29 AM, "Graham Percival" wrote: > On Fri, Oct 07, 2011 at 06:20:01PM +0100, Phil Holmes wrote: >> Best more official copy seems to be at >> http://code.google.com/p/git-core/downloads/list but this only goes >> back to 1.7.6.4 > > agreed. > >> Any preference? Is it worth caching

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

>> Looks like it's trying to download >> http://kernel.org/pub/software/scm/git/git-1.6.4.4.tar.gz and >> failing to find it - I don't think it's there now. There are severe problems with kernel.org since a few weeks (it has been compromised), and just now the maintainers are slowly restoring the

Re: Improves some parmesan noteheads. (issue 4639065)

http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode855 lily/stem.cc:855: if (attach && !scm_is_eq (style, ly_symbol2scm ("mensural")) On 2011/10/07 09:47:24, Bertrand Bordage wrote: stems

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)

http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79 lily/note-head.cc:79: out = fm->find_by_name (idx_either); This performs a second lookup for every note-head. Move this call to

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; Sent: Friday, October 07, 2011 6:29 PM Subject: Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue5233042) On Fri, Oct 07, 2011 at 06:20:01PM +0100, Phil Holmes wrote: Best more official

GUB

On Fri, Oct 07, 2011 at 07:09:57PM +0100, Phil Holmes wrote: > Tail of target/tools/log/perl.log >tar: Unexpected EOF in archive >tar: Unexpected EOF in archive >tar: Error is not recoverable: exiting now >Command barfed: tar -C > /media/IntelSSD/lilypond/git-gub/gub/target

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

LGTM http://codereview.appspot.com/5155045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)

http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79 lily/note-head.cc:79: out = fm->find_by_name (idx_either); Unfortunately, this doesn't work. If the condition line 73 is false,

Re: website.make

On Thu, Oct 06, 2011 at 06:46:40PM +0200, Julien Rioux wrote: > I tested and there is absolutely no diff between the > out-website generated with the old website.make and the new > website.make. Should I upload this to Rietveld for review? Yes please. :) Cheers, - Graham ___

Re: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar. (issue 5201043)

Passes make and make check shows 2 reg test diffs that Mike seems to think are expected attached at: http://code.google.com/p/lilypond/issues/detail?id=1956#c3 http://codereview.appspot.com/5201043/ ___ lilypond-devel mailing list lilypond-devel@gnu.

Re: Removes closeness-factor from the Slur details list. (issue 4825051)

Passes make and make check looks fine too. Graphviz.log does show up (and as I don't know what it means I'll paste it here anyway just in case ...) @@ -15,13 +15,13 @@ rankdir="LR" node [shape=rectangle] 41 [label="caching Stem.stencil\n# -> #"] -40 [label="caching VerticalAxisGroup.stencil\n

Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)

Passes make and make check throws up no reg tests except graphviz.log: --snip-- @@ -14,9 +14,9 @@ Writing graph `#f'...digraph G { rankdir="LR" node [shape=rectangle] -41 [label="caching Stem.stencil\n# -> #"] +41 [label="caching LedgerLineSpanner.stencil\n# -> #"] 40 [label="caching Vertical

Allows NoteColumns to be skipped over by glissandi. (issue 5242041)

passes make and make check only throws out @@ -14,9 +14,9 @@ Writing graph `#f'...digraph G { rankdir="LR" node [shape=rectangle] -41 [label="caching Stem.stencil\n# -> #"] +41 [label="caching LedgerLineSpanner.stencil\n# -> #"] 40 [label="caching VerticalAxisGroup.stencil\n# -> #f"] -39 [lab

Errors when doing 'make' for the first time when building the fonts

Hello, I've always these errors when I 'make' for the first time (i.e. when I have a fresh out of tree build). I expect most of them have always been there, but I wondered if they are problematic or not? --snip-- Internal Error in accidentals.flat.arrowdown: monotonic is both needed and unneeded

Re: Errors when doing 'make' for the first time when building the fonts

> I've always these errors when I 'make' for the first time (i.e. when I > have a fresh out of tree build). > > I expect most of them have always been there, but I wondered if they > are problematic or not? They are problematic, and they have not `always been there' :-) Please use a recent vers

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

Had problems uploading new patch to Rietveld after I ran makelsr.py - there are 60+ files changed (all the comittishes for the translations) - patch applies but my internet connection seems to be flakey and/or Rietveld is unforgiving it seems. I want to check that this is ok (with all those files

Re: Errors when doing 'make' for the first time when building the fonts

Werner On Sat, Oct 8, 2011 at 7:05 AM, Werner LEMBERG wrote: > >> I've always these errors when I 'make' for the first time (i.e. when I >> have a fresh out of tree build). >> >> I expect most of them have always been there, but I wondered if they >> are problematic or not? > > They are problemat

Re: Errors when doing 'make' for the first time when building the fonts

> 'make -j7 --enable-double' or '../configure --enable-double' or > something else? The latter. Sorry for being imprecise. Just to be sure: I'm talking about compilation and configuration of FontForge, not LilyPond. > Can you tell me though what the ramifications are in terms of reg > test che