L pretty GTM.
It would look even better with a little manual adjustment first.
http://codereview.appspot.com/4896043/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):
http://codereview.appspot.com/4896043/diff/1/scm/music-functions.scm#newcode673
scm/music-functions.scm:673:
use separate binding for (/ word-space 2)
Done.
http://codereview.appspot.com/4808074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reinhold Kainhofer:
> Am Sunday, 14. August 2011, 03:36:05 schrieb Karl Hammar:
> > Works here:
> Doesn't work here on a German Kubuntu system:
...
> > $ echo $LANG
> > C
> $ echo $LANG
> de_AT.UTF-8
$ LANG=de_AT.UTF-8
$ echo 'z:/' | egrep '^(/|[A-z]:/)'
egrep: Das Ende des angegebenen Intervalls
Hi Jonathan,
you wrote Sunday, August 14, 2011 1:50 AM
On Sat, Aug 13, 2011 at 5:53 PM, Trevor Daniels
wrote:
The lilynet website still seems to be under construction. In
particular the
lilydev remix iso is not available from the link in the CG. (I
guess this
should be a critical bug under
Pushed as 8d148ea05fa4b34f8cc3407e112363d715b27ad8
Bertrand
http://codereview.appspot.com/4808074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 14 August 2011 01:03, Ricardo Wurmus wrote:
> So ly:glob-property has side effects because of the stem callback?
> How can I make sure to get the final stem direction after all
> dependent properties were calculated?
>
> I want to replace a note head with a triangle, but there is a gap
> betwe
LGTM.
http://codereview.appspot.com/4891044/diff/1/Documentation/lilypond-texi2html.init
File Documentation/lilypond-texi2html.init (right):
http://codereview.appspot.com/4891044/diff/1/Documentation/lilypond-texi2html.init#newcode2076
Documentation/lilypond-texi2html.init:2076: if (defined
($c
David Kastrup writes:
> I don't think that anything close to a sensible implementation can be
> significantly simpler or significantly more efficient. There are some
> things that may be nicer to do in C, and some shortcuts that may be
> taken. But as a functional sketch, this should more or le
> > So ly:glob-property has side effects because of the stem callback?
> > How can I make sure to get the final stem direction after all
> > dependent properties were calculated?
> >
> > I want to replace a note head with a triangle, but there is a gap
> > between note head a stem when the stem poi
> Well David,
>
> I should not want to let you implement this in the current form
> without any feedback from the developer list. [...]
:-)
Unfortunately, I have nothing useful to say.
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.
Werner LEMBERG writes:
>> Well David,
>>
>> I should not want to let you implement this in the current form
>> without any feedback from the developer list. [...]
>
> :-)
>
> Unfortunately, I have nothing useful to say.
Well, there is the code (obviously bound to be streamlined before
implemen
On Sun, Aug 14, 2011 at 05:31:11PM +0200, David Kastrup wrote:
> Werner LEMBERG writes:
>
> > Unfortunately, I have nothing useful to say.
>
> Well, there is the code (obviously bound to be streamlined before
> implementation) and there are the proposed semantics. At least for the
> latter, I w
On Aug 11, 2011, at 11:40 PM, n.putt...@gmail.com wrote:
> Hi Mike,
>
> Have you tested this with broken tuplets? I've tried adding breaks at
> random in tuplet-nest.ly and get collisions in some cases.
>
> Cheers,
> Neil
Thanks Neil!
New patchset uploaded that fixes the line breaking proble
Reviewers: ,
Message:
Hey all,
This patch fixes a bug in LilyPond that has nagged me for some time:
incorrect heights and pure heights for stems.
THE GOOD:
With this patch, heights for stems are correct (they weren't before) and
pure heights are better approximations. There is one new regtest
Graham Percival writes:
> On Sun, Aug 14, 2011 at 05:31:11PM +0200, David Kastrup wrote:
>> Werner LEMBERG writes:
>>
>> > Unfortunately, I have nothing useful to say.
>>
>> Well, there is the code (obviously bound to be streamlined before
>> implementation) and there are the proposed semantic
David
I think we need to clarify a few things first.
You wrote
The semantics can be summarized as follows:
a) a revert will only cancel the last _matching_ override, and the
match
includes the complete specified property path, _and_ the
prospective
use of \once. \revert will not cance
"Trevor Daniels" writes:
> David
>
> I think we need to clarify a few things first.
>
> You wrote
>
>> The semantics can be summarized as follows:
>>
>> a) a revert will only cancel the last _matching_ override, and the
>> match
>> includes the complete specified property path, _and_ the
>> pro
Benchmark done on a book with many beams:
without the patch: 51.8s and 80 pages
with the patch: 52.2s and 83 pages
I also noticed some ugliness's between beams and figured bass. The
figures stay exactly where they were, but the stems are longer and
collide a bit with them.
Bertrand
http://coder
Same remark for fingerings.
See input/regression/fingering-cross-staff.ly
Consecutive ties look better in input/regression/tie-single.ly
http://codereview.appspot.com/4898044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.or
Wow, this is a major rewrite!
I can't comment on the logic, and at present I can't test it, so I've
just made a few nit-picking comments on style.
Trevor
http://codereview.appspot.com/4898044/diff/1/input/regression/stem-length-estimation.ly
File input/regression/stem-length-estimation.ly (rig
On 2011/08/05 00:21:45, MikeSol wrote:
Neil - whenever you get the chance, I'd like to hear more of what you
have to
say about it. If you think that custom engravers would be a better
idea here
(or even non-custom engravers), I'd like to fully discuss it on the
list.
I think an engraver a
http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc#newcode82
lily/axis-group-interface.cc:82:
Axis_group_interface::relative_maybe_bound_group_exten
New comments, and the results of fixing some non-indent spacing issues
in the source file.
http://codereview.appspot.com/4896043/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):
http://codereview.appspot.com/4896043/diff/1/scm/music-functions.scm#newcode752
scm/music-functi
David Kastrup wrote Sunday, August 14, 2011 8:11 PM
"Trevor Daniels" writes:
I think we need to clarify a few things first.
You wrote
I have no clear view about \set yet. It would seem to me that
\unset
should be equivalent to \revert, and \set should be equivalent
to
\revert+\overrid
http://codereview.appspot.com/4819064/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):
http://codereview.appspot.com/4819064/diff/1/scm/music-functions.scm#newcode1267
scm/music-functions.scm:1267: Staff ,(make-accidental-rule 'same-octave
0)
As Carl's pointed out here, http:
Hi Carl,
This latest patch looks great.
I'm not sold on the change to `else', but that's mainly due to being
used to how Emacs does it.
I'll do a bit more testing on other files and report back.
Cheers,
Neil
http://codereview.appspot.com/4896043/
_
Hi Mike,
This looks like a work in progress.
What's going on with the begin/end position methods? You've removed the
grob properties, but kept the exported callbacks plus an entry in
pure-conversions-alist which does nothing.
Cheers,
Neil
http://codereview.appspot.com/4898044/diff/1/scm/flag
Reinhold's recent commit for log-levels will require a git re-base and
probably a merge for scm/lily.scm. Will do this, re-test and upload new
patch-set.
Ian
http://codereview.appspot.com/4849054/
___
lilypond-devel mailing list
lilypond-devel@gnu.or
A fix from Karl. Please test and report back.
Werner
--- Begin Message ---
the first cartouche collides with the heading.
Does this patch (not yet committed) solve the problem in your real file?
(It fixes the test file, thanks much for the reduction.)
k
--- texinfo.tex.~1.347.~
"Trevor Daniels" writes:
> David Kastrup wrote Sunday, August 14, 2011 8:11 PM
>
>
>> "Trevor Daniels" writes:
>>
>>> I think we need to clarify a few things first.
>>>
>>> You wrote
>>>
I have no clear view about \set yet. It would seem to me that
\unset
should be equivalent to
30 matches
Mail list logo
