Wow, this is a major rewrite! I can't comment on the logic, and at present I can't test it, so I've just made a few nit-picking comments on style.
Trevor http://codereview.appspot.com/4898044/diff/1/input/regression/stem-length-estimation.ly File input/regression/stem-length-estimation.ly (right): http://codereview.appspot.com/4898044/diff/1/input/regression/stem-length-estimation.ly#newcode4 input/regression/stem-length-estimation.ly:4: texidoc = "Stems with overridden 'stem-end-position should 'Y-extent http://codereview.appspot.com/4898044/diff/1/lily/include/stem.hh File lily/include/stem.hh (right): http://codereview.appspot.com/4898044/diff/1/lily/include/stem.hh#newcode55 lily/include/stem.hh:55: static Grob* get_reference_head (Grob *); Grob *get_reference_head http://codereview.appspot.com/4898044/diff/1/lily/stem-tremolo.cc File lily/stem-tremolo.cc (right): http://codereview.appspot.com/4898044/diff/1/lily/stem-tremolo.cc#newcode219 lily/stem-tremolo.cc:219: Real ss = Staff_symbol_referencer::staff_space (me); delete http://codereview.appspot.com/4898044/diff/1/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4898044/diff/1/lily/stem.cc#newcode34 lily/stem.cc:34: The only exception to this is ::pure_height, whcih calls internal_pure_height which http://codereview.appspot.com/4898044/diff/1/lily/stem.cc#newcode141 lily/stem.cc:141: if (stemlet && !lh && beam) All three conditions include !lh; better test !lh outside http://codereview.appspot.com/4898044/diff/1/lily/stem.cc#newcode149 lily/stem.cc:149: + beam_translation * max (0, (beam_count - 1)) indent http://codereview.appspot.com/4898044/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
