LGTM, but I'd prefer longer names for o, m and tg
(especially tg!).
Trevor
http://codereview.appspot.com/4810042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Trevor Daniels writes:
>> Not much response from the previous GOP-PROP 5 (update); I'm not
>> certain if "silence is a form of consent" [1] in this context.
>
> In my case it's because I have difficulty in understanding precisely
> what the effect of this change will be on any work I do.
+1
I pr
Does anyone building on Mac plan on upgrading to Lion and, if so, can they
report back what happens when they try a build?
Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 7/20/11 10:41 PM, "Graham Percival" wrote:
> On Wed, Jul 20, 2011 at 09:40:01PM -0700, Graham Percival wrote:
>> Can somebody check if
>> make test
>> works on stable/2.14, and if not, fix it? The GUB build died,
>> apparently on
>> input/regression/rest-polyphonic-2.ly
>
> aha, of co
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42
lily/stem-tremolo.cc:42: style = ly_symbol2scm ("constant");
You can remove these two lines and use
style == ly
On 2011/07/21 06:16:27, mike_apollinemike.com wrote:
On Jul 20, 2011, at 10:22 PM, mailto:pkx1...@gmail.com wrote:
> It passes make, but I get a lot of reg test issues
>
> Mainly I can see:
> +programming error: Improbable offset for stencil: -nan staff space
> +Setting to zero.
> +continuing,
Hello,
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Colin Campbell
)Sent: 21 July 2011 03:24
)To: lilypond-devel@gnu.org
)Subject: PATCH: 48-hour countdown
)
)New today, for
Han-Wen Nienhuys:
...
> Werner, can you have a look at http://codereview.appspot.com/4819041 ?
/draw_round_box % width height x y blot
{
- setlinewidth % w h x y
- 0 setlinecap
- 1 setlinejoin
+dup
+ 0.0 gt {
+ setlinewidth % w h x y
On Thu, Jul 21, 2011 at 8:11 AM, Karl Hammar wrote:
> Han-Wen Nienhuys:
> ...
>> Werner, can you have a look at http://codereview.appspot.com/4819041 ?
>
> /draw_round_box % width height x y blot
> {
> - setlinewidth % w h x y
> - 0 setlinecap
> - 1 setlinejoin
> +
Han-Wen Nienhuys:
> On Thu, Jul 21, 2011 at 8:11 AM, Karl Hammar wrote:
> > Han-Wen Nienhuys:
> >> Werner, can you have a look at http://codereview.appspot.com/4819041 ?
> > There is no blot on the stack below (as indicated by the comment),
> there is; the dup puts it on the stack. The comment in
On Thu, Jul 21, 2011 at 10:07:29AM +0200, Jan Nieuwenhuizen wrote:
> I proposed to adopt the linux/git/automake convention of using silent
> rules so that you get something like
>
> make
> CC lily/foo.c
> ..
> LB Documentation/web.texi
> LB Documentation/notation.texi
>
> or what you cu
If you do
\set #'foo = #1
c
\once \set #'foo = #2
c
\once \set #'foo = #3
c
then the final value of foo should be 1. But with this code, I think it
will be 2.
http://codereview.appspot.com/4810042/
___
lilypond-devel mailing list
lilypond-devel@gnu.o
On Wed, Jul 20, 2011 at 12:42 PM, Federico Bruni wrote:
> Il giorno mar, 19/07/2011 alle 18.19 -0600, Colin Campbell ha scritto:
>> I'm pretty sure the stuff you need is in the guile-1.8-dev package,
>> Federico. On my Ubuntu 11.04, the package contains files such as
>> debug.h and debug-malloc.h
On 2011/07/21 16:15:41, joeneeman wrote:
If you do
\set #'foo = #1
c
\once \set #'foo = #2
c
\once \set #'foo = #3
c
then the final value of foo should be 1. But with this code, I think
it will be
2.
The \once finalization occurs before the new \once \set is processed, so
it always retu
Reviewers: Trevor Daniels, joeneeman, Neil Puttock,
Message:
On 2011/07/21 16:15:41, joeneeman wrote:
If you do
\set #'foo = #1
c
\once \set #'foo = #2
c
\once \set #'foo = #3
c
then the final value of foo should be 1. But with this code, I think
it will be
2.
Why should it be 2? The f
LGTM.
http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly
File input/regression/set-once.ly (right):
http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode1
input/regression/set-once.ly:1: \version "2.15.5"
2.15.6
http://codereview.appspot
On 2011/07/16 05:42:36, Keith wrote:
Works good for me.
Thanks, pushed: 14632519690052980d19fc75e4dbc759c480aac2
Cheers,
Neil
http://codereview.appspot.com/4693046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailma
http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-methods.scm
File scm/define-music-display-methods.scm (right):
http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-methods.scm#newcode867
scm/define-music-display-methods.scm:867: ;; nested properties a
On 2011/07/20 17:02:02, Reinhold wrote:
On 2011/07/18 20:24:43, Neil Puttock wrote:
> lily/system-start-delimiter.cc:117: staffspace =
> Staff_symbol_referencer::staff_space (sp);
> A mostly theoretical gripe, I guess: what about collapse-height
comparisons
> where multiple staves are involved?
LGTM.
http://codereview.appspot.com/4757043/diff/1/lily/staff-performer.cc
File lily/staff-performer.cc (right):
http://codereview.appspot.com/4757043/diff/1/lily/staff-performer.cc#newcode69
lily/staff-performer.cc:69: // For now, ask the last Staff_performer
clean up during its finalize()
fin
On Wed, Jul 20, 2011 at 08:24:07PM -0600, Colin Campbell wrote:
> Countdown done, but still open/not fixed:
>
> 21:00 MST Wednesday July 13
> Reitveld Issue 4664060: Adds redirect-lilypond-output option to
> lilypond-book
sorry, that one was pushed but I forgot to update the google
track
On Thu, Jul 21, 2011 at 07:49:01AM +0100, Trevor Daniels wrote:
>
> Graham Percival wrote Thursday, July 21, 2011 6:37 AM
>
> >Not much response from the previous GOP-PROP 5 (update); I'm not
> >certain if "silence is a form of consent" [1] in this context.
>
> In my case it's because I have dif
Will also correct those spacing issues pointed out by Neil before I'll
push.
http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly
File input/regression/set-once.ly (right):
http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode6
input/regres
Reviewers: Neil Puttock, J_lowe,
http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-methods.scm
File scm/define-music-display-methods.scm (right):
http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-methods.scm#newcode867
scm/define-music-display-metho
On 21 July 2011 19:27, wrote:
> Really? The NR (section 5.3.6 "Modifying alists" as well as 4.4.1
> "Flexible vertical spacing within systems") only gives examples of the
> form #'staff-staff-spacing #'basic-distance... I didn't even know that
> the list syntax was there, let alone that it is th
http://codereview.appspot.com/4630070/diff/17001/input/regression/dynamics-alignment-breaker-linebreak.ly
File input/regression/dynamics-alignment-breaker-linebreak.ly (right):
http://codereview.appspot.com/4630070/diff/17001/input/regression/dynamics-alignment-breaker-linebreak.ly#newcode5
inpu
We've had almost a day to recover from the C++ formatting issue,
so let's dive into the next massively contentious issue.
http://lilypond.org/~graham/gop/gop_6.html
** Proposal summary
What should we do with potentially sensitive or private matters in
lilypond? I see two possible solutions:
n.putt...@gmail.com writes:
> http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly
> File input/regression/glissando-stem.ly (right):
>
> http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10
> input/regression/glissando-stem.ly:
Reviewers: ,
Message:
Addresses Reinhold's comment re issue 1762
Description:
DOC: fix NR 1.6.3 Formatting Cue Notes
Moves comment about explicitly creating a Voice, to the proper example.
Please review this at http://codereview.appspot.com/4808051/
Affected files:
M Documentation/notation/
On Thu, Jul 21, 2011 at 12:31 PM, Karl Hammar wrote:
> Han-Wen Nienhuys:
>> On Thu, Jul 21, 2011 at 8:11 AM, Karl Hammar wrote:
>> > Han-Wen Nienhuys:
>> >> Werner, can you have a look at http://codereview.appspot.com/4819041 ?
>> > There is no blot on the stack below (as indicated by the comment
On Thu, Jul 21, 2011 at 11:27 PM, Han-Wen Nienhuys wrote:
>> After "dup" there is two "blot"s, "gt" consumes one and "setlinewidth"
>> the other.
>
> I'm sorry - I misunderstood; I thought you saw a problem with the code
> rather than the comments.
>
> pushed as 5291daf785cd215145473781612732de948
On Thu, Jul 21, 2011 at 10:01 PM, David Kastrup wrote:
> Anyway, this is not particularly complex either. Could possibly pave
> the way for a nicer function for setting up strings for tabulatures.
> Also stuff like \transpose can be implemented by users with a
> straightforward syntax accepting j
On Thu, Jul 21, 2011 at 11:45:51PM -0300, Han-Wen Nienhuys wrote:
>
> This should be backported. Do we have a special procedure for that nowadays?
Yes, add "backport" to a google tracker issue about it. But I
think you just missed the deadline for 2.14.3, and I'm not certain
if we'll have any m
Could somebody try to make doc in stable/2.14, and fix whatever's
necessary to fix? I don't know exactly what the problem is, but
since it's a doc build problem, the problem is hidden somewhere in
a 49480-line logfile, but I'm not going to dig through an 8-thread
build on a computer that's behind
Il giorno gio, 21/07/2011 alle 23.26 +0700, Joe Neeman ha scritto:
> If the debugging information were installed, there would be more
> information inside the (). Since Debian doesn't seem to have a package
> for it, the easiest way to get debugging information may be to compile
> guile yourself.
Han-Wen Nienhuys writes:
> On Thu, Jul 21, 2011 at 10:01 PM, David Kastrup wrote:
>> Anyway, this is not particularly complex either. Could possibly pave
>> the way for a nicer function for setting up strings for tabulatures.
>> Also stuff like \transpose can be implemented by users with a
>> s
On Fri, Jul 22, 2011 at 1:32 PM, Federico Bruni wrote:
> Il giorno gio, 21/07/2011 alle 23.26 +0700, Joe Neeman ha scritto:
>> If the debugging information were installed, there would be more
>> information inside the (). Since Debian doesn't seem to have a package
>> for it, the easiest way to ge
37 matches
Mail list logo
