On Wed, 29 Jun 2011 21:05:51 -0700, Carl Sorensen wrote:
Do you have the ability to easily test a change that doesn't pad a
parenthesis if it's following the same character, ie. (( won't get an extra
space?
It turns out to be very easy to modify astyle so as to skip the padding between
(( an
Michael Welsh Duggan wrote Thursday, June 30, 2011 5:34 AM
Graham Percival writes:
http://lilypond.org/~graham/gop/gop_4.html
Could I please ask, for my sanity, that we use ISO 8601 dates?
+1 (and thanks for reworking the list)
Oh, and thank you, Graham, for putting so much effort into
Hi,
it's been a while since I had time to work with LilyPond but coming
back to it I'm trying to make one tiny adjustment to MIDI output:
specify exact channel (staff/voice contexts).
I need this because, like was mentioned here:
http://lists.gnu.org/archive/html/lilypond-user/2011-05/msg00165.
Reviewers: ,
Message:
I have a functional version of this feature up with a regtest.
I think the input syntax works, but it could be cleaner.
All suggestions are welcome! Off now to typeset crazy glissandi...
Cheers,
MS
Description:
Adds glissando stems to Lilypond.
Please review this at htt
hello,
I'm in no way qualified to comment on code, but am uncomfortable with
the function name:
\startGStems
It has two caps in the middle and is 'plural'.
\startGlissandoStem
while quite long, isn't that long. I realise this is not GLISS but
thought it worth mentioning now.
http://coderev
On Thu, Jun 30, 2011 at 09:21:21AM +, pkx1...@gmail.com wrote:
> \startGlissandoStem
>
> while quite long, isn't that long.
+1
> I realise this is not GLISS but thought it worth mentioning now.
Long-term, I'll be pushing for a different naming scheme, but I
have no objection to \startGlissa
On Thu, Jun 30, 2011 at 05:01:36AM -0400, David Santamauro wrote:
>
> it's been a while since I had time to work with LilyPond but coming
> back to it I'm trying to make one tiny adjustment to MIDI output:
> specify exact channel (staff/voice contexts).
Interesting idea! Janek will help you with
Long-term, I'll be pushing for a different naming scheme, but I
have no objection to \startGlissandoStem for the next few months.
Cheers,
- Graham
New patchset up w/ changed names.
Cheers,
MS
http://codereview.appspot.com/4661061/
___
lilypond-d
On Thu, Jun 30, 2011 at 09:00:48AM +0100, Trevor Daniels wrote:
>
> Michael Welsh Duggan wrote Thursday, June 30, 2011 5:34 AM
>
> >Graham Percival writes:
> >
> >>http://lilypond.org/~graham/gop/gop_4.html
> >
> >Could I please ask, for my sanity, that we use ISO 8601 dates?
Sorry, and done.
Hi,
General question about Staff_performer::acknowledge_audio_element()
given:
Context* c = inf.origin_contexts (this)[0];
string voice;
if (c->is_alias (ly_symbol2scm ("Voice")))
voice = c->id_string ();
... when does
if (c->is_alias (ly_symbol2scm ("Voice")))
e
I made a "private" (actually public) git repository for various
administrative stuff in lilypond, because I'm too lazy to make a
proper backup of this material:
https://github.com/gperciva/lilypond-extra
It probably won't be of interest, but it's there if you want to
take a look. I'll migrate ma
On Thu 30 Jun 2011, 13:31 Graham Percival wrote:
> Dmytro: I ended up including the bug-squad scrape.py in there
> after all; I'll apply whatever patches or pull requests you make,
> if you feel like playing with git. Or you can just send me
> updated files and I'll dump them there myself. No rus
Official regtests: pretty clean. Not sure about:
+warning: MIDI channel wrapped around
+warning: remapping modulo 16
warning: MIDI channel wrapped around
warning: remapping modulo 16
warning: MIDI channel wrapped around
in midi-volume-equaliser.log and
-warning: MIDI channel wrapped around
-wa
LGTM
(I am assuming the glyphs don't change)
http://codereview.appspot.com/4625067/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Wed 29 Jun 2011, 10:38 Xavier Scheuer wrote:
> %% DynamicTextSpanner inside a Dynamics context are shifted to the left
> %% if there is a Pedal inside another Dynamics context.
> %% That leads to really poor output of the DynamicTextSpanner, which
> %% are shifted left (compared to when they are
On Wed, Jun 29, 2011 at 7:26 PM, Graham Percival
wrote:
> http://lilypond.org/~graham/gop/gop_4.html
>
> ** Proposal summary
>
> What went well, what went badly? This is a discussion only; it
> will be summarized, and we will refer back to it in future policy
> decisions, but no new policies will
- Original Message -
From: "Graham Percival"
To:
Sent: Wednesday, June 15, 2011 12:11 AM
Subject: GOP-PROP 1: python formatting - probable decision
Unless anybody has a compelling reason against it, this is the
proposal which will be adopted on 22 June 2011:
http://lilypond.org/~grah
Reviewers: ,
Message:
Hey all,
This patch simplifies a lot of code duping I'm doing to get spanner
lengths in various scheme functions. Please lemme know if it's OK!
Cheers,
MS
Description:
Sets spanner length as a spanner property.
Please review this at http://codereview.appspot.com/4641085
On Thu, Jun 30, 2011 at 02:59:10PM +0100, Phil Holmes wrote:
> "use 4 spaces per indentation level"
> "a text editor could be used to replace \t with 8 spaces"
>
> Unless we have only ever used tabs to represent double indents, this
> isn't self consistent.
That is exactly what happened.
- python
On 2011/06/30 14:21:00, MikeSol wrote:
Hey all,
This patch simplifies a lot of code duping I'm doing to get spanner
lengths in
various scheme functions. Please lemme know if it's OK!
Cheers,
MS
And it breaks the build of internals.texi on my machine...does anyone
have any ideas as to w
On Jun 30, 2011, at 4:17 PM, Han-Wen Nienhuys wrote:
> On Wed, Jun 29, 2011 at 7:26 PM, Graham Percival
> wrote:
>> http://lilypond.org/~graham/gop/gop_4.html
>>
>> ** Proposal summary
>>
>> What went well, what went badly? This is a discussion only; it
>> will be summarized, and we will refer
On 30 June 2011 14:40, Phil Holmes wrote:
> Official regtests: pretty clean. Not sure about:
>
> +warning: MIDI channel wrapped around
> +warning: remapping modulo 16
> warning: MIDI channel wrapped around
> warning: remapping modulo 16
> warning: MIDI channel wrapped around
>
> in midi-volume-eq
On 2011/06/30 14:32:36, MikeSol wrote:
On 2011/06/30 14:21:00, MikeSol wrote:
> Hey all,
>
> This patch simplifies a lot of code duping I'm doing to get spanner
lengths in
> various scheme functions. Please lemme know if it's OK!
>
> Cheers,
> MS
And it breaks the build of internals.texi on
On 30 June 2011 12:18, David Santamauro wrote:
> ... when does
>
> if (c->is_alias (ly_symbol2scm ("Voice")))
>
> ever return false?
When it acknowledges an Audio_key. The Key_performer is the only
other performer contained by a Staff context in midi; see
ly/performer-init.ly for the context d
http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc
File lily/spanner.cc (right):
http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc#newcode551
lily/spanner.cc:551: "length "
this conflicts with the current usage for Stem
http://codereview.appspot.com/4641085/
__
LGTM, but needs a rebase to remove the changes in
Documentation/contributor/issues.itexi.
http://codereview.appspot.com/4527086/diff/30001/input/regression/glissando-broken-multiple.ly
File input/regression/glissando-broken-multiple.ly (right):
http://codereview.appspot.com/4527086/diff
On Thu, Jun 30, 2011 at 12:21 PM, Graham Percival
wrote:
>> On a tangent: at Google I am working on a side-project that
>> essentially is distcc on steroids; it will allow any compilation
> ...
>> It could speed up GUB and regtest checking for those that have access
>> to several machines.
>
> Coo
On Thu, Jun 30, 2011 at 11:17:36AM -0300, Han-Wen Nienhuys wrote:
> On Wed, Jun 29, 2011 at 7:26 PM, Graham Percival
> wrote:
> > http://lilypond.org/~graham/gop/gop_4.html
> >
> > What went well, what went badly? This is a discussion only; it
> > will be summarized, and we will refer back to it i
On Jun 30, 2011, at 5:07 PM, n.putt...@gmail.com wrote:
> LGTM, but needs a rebase to remove the changes in
> Documentation/contributor/issues.itexi.
>
>
> http://codereview.appspot.com/4527086/diff/30001/input/regression/glissando-broken-multiple.ly
> File input/regression/glissando-broke
can you show png examples of what you're trying to do?
I think this patch has serious issues.
http://codereview.appspot.com/4661061/diff/13/lily/music-sequence.cc
File lily/music-sequence.cc (right):
http://codereview.appspot.com/4661061/diff/13/lily/music-sequence.cc#newcode118
lily/music-seq
On 30 June 2011 16:10, Phil Holmes wrote:
> I knew about that - just wasn't sure why an extra warning was added to
> volume-equaliser and one removed from -dynamics.
It's the same thing that causes the festival regtests to switch
between builds: it depends on the order of compilation when
lilypo
Hi Mike,
The interface is an improvement on the patch you originally posted, but
it still leaves a lot to be desired. :)
I don't like the way you flag the glissando stems; ideally they'd be a
separate grob which doesn't require noteheads and legers to be removed.
Cheers,
Neil
http://coderevie
On Jun 30, 2011, at 5:20 PM, Han-Wen Nienhuys wrote:
> On Thu, Jun 30, 2011 at 11:21 AM, wrote:
>> Reviewers: ,
>>
>> Message:
>> Hey all,
>>
>> This patch simplifies a lot of code duping I'm doing to get spanner
>> lengths in various scheme functions. Please lemme know if it's OK!
>
> Why i
On Jun 30, 2011, at 5:29 PM, hanw...@gmail.com wrote:
> can you show png examples of what you're trying to do?
>
PastedGraphic-1.pdf
Description: Adobe PDF document
> I think this patch has serious issues.
>
>
> http://codereview.appspot.com/4661061/diff/13/lily/music-sequence.cc
> File lil
- Original Message -
From: "Neil Puttock"
To: "Phil Holmes"
Cc:
Sent: Thursday, June 30, 2011 3:57 PM
Subject: Re: Regtests for 2.15.3
On 30 June 2011 14:40, Phil Holmes wrote:
> Official regtests: pretty clean. Not sure about:
>
> +warning: MIDI channel wrapped around
> +warning:
On 2011/06/30 14:56:25, Neil Puttock wrote:
http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc
File lily/spanner.cc (right):
http://codereview.appspot.com/4641085/diff/1/lily/spanner.cc#newcode551
lily/spanner.cc:551: "length "
this conflicts with the current usage for Stem
Fixed
On Thu, Jun 30, 2011 at 11:21 AM, wrote:
> Reviewers: ,
>
> Message:
> Hey all,
>
> This patch simplifies a lot of code duping I'm doing to get spanner
> lengths in various scheme functions. Please lemme know if it's OK!
Why is length not computed as a callback? You should avoid
set_property()
On Thu, Jun 30, 2011 at 12:34:56PM -0300, Han-Wen Nienhuys wrote:
> On Thu, Jun 30, 2011 at 12:21 PM, Graham Percival
> wrote:
> > Daily tests would be awesome:
> > http://code.google.com/p/lilypond/issues/detail?id=933
>
> We used to have this, but it was rather fragile, so it only caught
> comp
On Jun 30, 2011, at 5:29 PM, n.putt...@gmail.com wrote:
> Hi Mike,
>
> The interface is an improvement on the patch you originally posted, but
> it still leaves a lot to be desired. :)
>
If it didn't, my patch wouldn't have potential, and who likes a patch without
potential?
> I don't like th
On Thu, Jun 30, 2011 at 04:23:23PM +0100, Neil Puttock wrote:
> On 30 June 2011 16:10, Phil Holmes wrote:
>
> > I knew about that - just wasn't sure why an extra warning was added to
> > volume-equaliser and one removed from -dynamics.
>
> It's the same thing that causes the festival regtests to
Hey Han-Wen,
I see the to_spanner of which you speak in gdb.cc, but I'm not sure how to
access it. Should a gdb.hh be put in include/ so that it can be included and
used?
Cheers,
MS
On Jun 30, 2011, at 5:29 PM, hanw...@gmail.com wrote:
> can you show png examples of what you're trying to do?
New patch-set uploaded addressing all minor concerns so far. The
biggest change is that, as per Han-Wen's suggestion, the glissando-stem
stuff no longer happens courtesy of after-line-breaking but rather in
response to a callback for glissando-stem.
http://codereview.appspot.com/4661061/
__
- Original Message -
From: "Graham Percival"
To:
On a tangent: at Google I am working on a side-project that
essentially is distcc on steroids; it will allow any compilation
...
It could speed up GUB and regtest checking for those that have access
to several machines.
Cool project
On Thu, Jun 30, 2011 at 05:33:08PM +0100, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
>
> To:
>
> >Cool project, but I don't think our limitation is processing
> >power. My desktop is idle at least 95% of the time, so I could
> >dedicate a lot more horsepower to GU
On 2011/06/30 15:22:18, mike_apollinemike.com wrote:
On Jun 30, 2011, at 5:07 PM, mailto:n.putt...@gmail.com wrote:
> LGTM, but needs a rebase to remove the changes in
>Documentation/contributor/issues.itexi.
>
>
>
http://codereview.appspot.com/4527086/diff/30001/input/regression/glissan
On 6/30/11 9:21 AM, "Graham Percival" wrote:
> On Thu, Jun 30, 2011 at 11:17:36AM -0300, Han-Wen Nienhuys wrote:
>> We should examine other reasons for the delay of the 1st candidate
>> appearing, and the delay between the 1st and last release candidate,
>> and figure out if there is a way to prev
On 11-06-30 03:31 AM, mts...@gmail.com wrote:
Long-term, I'll be pushing for a different naming scheme, but I
have no objection to \startGlissandoStem for the next few months.
Cheers,
- Graham
New patchset up w/ changed names.
Cheers,
MS
http://codereview.appspot.com/4661061/
Added is
Added issue 1727 for tracking
http://codereview.appspot.com/4661061/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Added issue 1728 to tracker
http://codereview.appspot.com/4527086/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Addewd as issue 1729
http://codereview.appspot.com/4641085/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 11-06-30 08:21 AM, mts...@gmail.com wrote:
Reviewers: ,
Message:
Hey all,
This patch simplifies a lot of code duping I'm doing to get spanner
lengths in various scheme functions. Please lemme know if it's OK!
Cheers,
MS
Added issue 1729 for tracking
Colin
--
The human race has one real
51 matches
Mail list logo
