Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)

Janek Warchoł wrote Tuesday, May 10, 2011 6:11 AM I remember that someone once told me that such canges should be done separately from the actual coding stuff - that's why i thought your changes were accidental (i didn't examine them closely indeed). Honestly i'm not sure if this policy of s

Re: Where to merge Translations now?

Well. Here is my list. Carl, please, cherry-pick these commits from lilypond/translation to stable/2.14. There is a potential problem in a single commit: the 'LSR update' commit could contain 2.15-only material. If you think it could break the build or the dist, please ignore it. Is there anythi

Versioning problems in trunk

When installing the Python scripts, those contain references to directories /usr/local/lib/lilypond/2.13.58 and /usr/local/share/lilypond/2.13.58 which are outdated. What's up with that? ./autogen.sh does not help. I am now doing "make clean all info" which would appear to put sensible directo

Re: Implements beam collision rest avoidance. (issue4465049)

On May 5, 2011, at 7:51 PM, m...@apollinemike.com wrote: > On May 5, 2011, at 1:50 PM, n.putt...@gmail.com wrote: > >> On 2011/05/05 20:44:36, Neil Puttock wrote: >>> On 2011/05/05 16:30:28, MikeSol wrote: >> (a) People to confirm that the circular dependency I fear (beam >> placement

Re: Bugfix for issue 1630 (issue4490045)

2011/5/9 : > http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc > File lily/completion-note-heads-engraver.cc (right): > > http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc#newcode204 > lily/completion-note-heads-engraver.cc:204:

Re: Versioning problems in trunk

On Tue, May 10, 2011 at 12:28:54PM +0200, David Kastrup wrote: > > Any possibility of fixing the dependencies in a manner that a changed > version will lead to appropriately changed python scripts? No, I do not envision any realistic possibility. To cut through to the heart of the matter: buildi

[Patch] Fattened braces

Hi, I recently noticed that small braces are too thin to be read. This patch gently increases the thickness of the 256 first braces : http://codereview.appspot.com/4518052/ It prepares a future patch that will implement in-staves braces especially used in organ music. Several examples in these sc

Re: [Patch] Fattened braces

Comparison between original and fattened braces attached. Bertrand <><>___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fattens the 256 first braces. (issue4518052)

LGTM, with a small nitpick. I like the new braces better. Carl http://codereview.appspot.com/4518052/diff/1/mf/feta-braces.mf File mf/feta-braces.mf (right): http://codereview.appspot.com/4518052/diff/1/mf/feta-braces.mf#newcode148 mf/feta-braces.mf:148: fatten_factor := 1.5; I think that go

[PATCH] Doc - NR 1.6.3 - edit eg.s in quoting other voices

http://codereview.appspot.com/4518053 Initially suggested by Keith with a more 'real world' example - the current ones did make it ambiguous. I have (I hope) improved on Keith's suggestions but also took some time to better phrase some of the explanatory text. James _

Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1022 Documentation/notation/staff.itely:1022: @cindex quote, voices could we kee

Re: Fattens the 256 first braces. (issue4518052)

Reviewers: carl.d.sorensen_gmail.com, Message: Thanks for the review ! Patch updated. I don't know if there's a better way to solve this issue. As big braces look good, I decided to limit the changes to the smallest ones. Description: Fattens the 256 first braces. Please review this at http://c

Re: Fattens the 256 first braces. (issue4518052)

LGTM, apart from one nitpick. I much prefer your redesigned braces! Trevor http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf File mf/feta-braces.mf (right): http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode150 mf/feta-braces.mf:150: save fatten; I don'

Re: Fattens the 256 first braces. (issue4518052)

http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf File mf/feta-braces.mf (right): http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode150 mf/feta-braces.mf:150: save fatten; That's what I thought at first. Then I saw "save number;" line 129, so I decided to p

Better width functions for the current arpeggio print functions. (issue4517051)

Reviewers: , Message: I had added a Rietveld issue about this, but the example on my Rietveld issue was bunk so I pulled it. The current width function in arpeggio.cc does not give the correct width for chord brackets or chord slurs, nor does it give the correct width for arpeggios with arrows (

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

My suggestion was tiny compared to this patch. http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (left): http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#oldcode1086 Documentation/notation/staff