RE: Font: Including the jazz font for chords (issue3972048)

2011-01-26 Thread James Lowe
Marc, > -Original Message- > From: Marc Hohl [mailto:m...@hohlart.de] > Sent: 25 January 2011 20:59 > To: Carl Sorensen > Cc: James Lowe; carl.d.soren...@gmail.com; lilypond-devel@gnu.org; > re...@codereview.appspotmail.com > Subject: Re: Font: Including the jazz font for chords (issue3972

[PATCH] removed unused macro "classname" , unused funcion "demangle_classname", unneccessary file "flower/rtti.cc"

2011-01-26 Thread Bernard Hurley
The definition of the function "demangle_classname" is the only content of flower/rtti.cc. This is only referenced in flower/include/virtual-methods.hh, where it is used in the definition of the macro "classname". Hence the references to "demangle_classname" in virtual-methods.hh can be deleted al

Re: Font: Including the jazz font for chords (issue3972048)

2011-01-26 Thread Simon Tatham
[re...@codereview.appspotmail.com removed from cc-list on the grounds that I doubt this is any longer on-topic for any actual code review] James Lowe wrote: [Gonville] > I'd contact the author directly. Last year when I helped write what > documentation we have on it in our NR, and he was very he

[PATCH] Re: PDF hyperlinks

2011-01-26 Thread Reinhold Kainhofer
Am Montag, 27. Dezember 2010, um 17:53:13 schrieb Dan Eble: > On 2010-12-27, at 11:11 , Reinhold Kainhofer wrote: > > I forgot to add that the link itself would then be implemented completely > > similar to \with-url. So, the only non-trivial thing is really how to get > > the information about whe

Re: [PATCH] Re: PDF hyperlinks

2011-01-26 Thread Carl Sorensen
On 1/26/11 6:08 AM, "Reinhold Kainhofer" wrote: > Am Montag, 27. Dezember 2010, um 17:53:13 schrieb Dan Eble: >> On 2010-12-27, at 11:11 , Reinhold Kainhofer wrote: >>> I forgot to add that the link itself would then be implemented completely >>> similar to \with-url. So, the only non-trivial thi

Re: MIDI remapping

2011-01-26 Thread Benkő Pál
> Your example of comma tuning was indeed the ticket I needed!! great to hear! > I've adapted your file to 31 equal temperament. (The files are > attached for anyone who is interested.) I don't know whether it's common knowledge, but I notate the 31-step octave with conventional accidentals: c d

Re: MIDI remapping

2011-01-26 Thread c.m.bryan
Dear Benkő and list, Your example of comma tuning was indeed the ticket I needed!! I knew about the makam example in the lilypond manual for ages, but it didn't click in my brain that it was actually specifying the pitch bends in the midi output, and that I could tie any glyphs to any pitch shift

PATCHES: 48-hour notice for mensural and bar-extent

2011-01-26 Thread Graham Percival
Unless I hear objections, I will push these two patches: mensural notation improvements http://codereview.appspot.com/3797046/ remove bar-size and replace its usage by bar-extent http://codereview.appspot.com/4025044/ on Friday, 3pm Scotland time. I am aware that the mensural notation

markup to string function?

2011-01-26 Thread Reinhold Kainhofer
I'm currently implementing PDF metadata (DOCINFO extracted from the \header fields) as well as PDF hyperlinks to given labels in the score. For both I would need to extract a pure-string representation of a given markup. E.g., the title header field might be a markup: \header{ title = \markup

Re: remove bar-size and replace its usage by bar-extent (issue4025044)

2011-01-26 Thread Benkő Pál
> Why is the french version of the chords.itely in this patch and none of > the other languanges? I grepped for bar-size, was surprised too, but didn't investigate further. I'll do it again before sending the patches (and if I find anything new, I'll upload it to Rietveld). p ___

Re: remove bar-size and replace its usage by bar-extent (issue4025044)

2011-01-26 Thread pkx166h
Just a nit-pick. Why is the french version of the chords.itely in this patch and none of the other languanges? James http://codereview.appspot.com/4025044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/l

Re: remove bar-size and replace its usage by bar-extent (issue4025044)

2011-01-26 Thread Graham Percival
On Wed, Jan 26, 2011 at 02:58:44PM +, pkx1...@gmail.com wrote: > Why is the french version of the chords.itely in this patch and none of > the other languanges? If the other languages didn't translate that part of chords.itely, or if the translations are out of date, then they wouldn't have "b

[PATCH] Extract PDF metadata from \header block (Fix Issue #1463)

2011-01-26 Thread Reinhold Kainhofer
Here is a patch that extracts metadata from the \header block and writes it out as PDF metadata (most notable the title, which is also shown in the PDF viewer's title bar, the composer and the keywords): http://codereview.appspot.com/4094045 Cheers, Reinhold -- -

Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)

2011-01-26 Thread percival . music . ca
On 2011/01/25 04:47:23, Carl wrote: This patch seems to have some very good benefits. Neil has identified a potential downside to this patch. Some kind of additional work is required -- maybe adding some special case to avoid changing clefs in this way, or possibly just an argument that the ch

Parser error with self-defined predicate symbol-or-markup? in markup function

2011-01-26 Thread Reinhold Kainhofer
I'm defining my own predicate symbol-or-markup? for the argument of a markup function. #(define-public (symbol-or-markup? x) (or (symbol? x) (markup? x))) #(define-markup-command (mytest layout props label arg) (symbol-or-markup? markup?) (let* ((s (if (symbol? label)

Re: Parser error with self-defined predicate symbol-or-markup? in markup function

2011-01-26 Thread David Kastrup
Reinhold Kainhofer writes: > I'm defining my own predicate symbol-or-markup? for the argument of a markup > function. > > #(define-public (symbol-or-markup? x) > (or (symbol? x) (markup? x))) > > #(define-markup-command (mytest layout props label arg) > (symbol-or-markup? ma

Re: Add the Instrument_name_engraver also to all group contexts (issue4031043)

2011-01-26 Thread percival . music . ca
LGTM. http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly File input/regression/instrument-name-groups.ly (right): http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode32 input/regression/instrument-name-groups.

Re: PartCombine: Keep track of the state in the Part_combine_engraver (issue3334043)

2011-01-26 Thread percival . music . ca
Nothing obviously wrong in a regtest comparison, and the code style looks fine to me. http://codereview.appspot.com/3334043/diff/1/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (right): http://codereview.appspot.com/3334043/diff/1/lily/part-combine-iterator.cc#newcode69 lily/

Re: Files to edit to add a new language

2011-01-26 Thread Graham Percival
On Tue, Jan 25, 2011 at 12:53:09PM +0100, Francisco Vila wrote: > I have successfully added a Chinese webpage from the files that Ben > Luo sent. What the CG says about adding a new language, is not by far > all that is needed to do. One or more of the following are only > necessary to add manual

Re: Japanese website

2011-01-26 Thread Graham Percival
On 1/25/11, Francisco Vila wrote: > Hello. The japanese website looks in a fairly good shape; this patch > completes and enables it. ok, pushed, but it adds a warning: Initializing settings for web site: [ja] ** Unknown command with braces `@contactUsAbout' (in out-website/others-did.itexi l. 2

ily gui in guile: schikkers-list binary 0.0.1-1

2011-01-26 Thread Jan Nieuwenhuizen
Hi, I've put up a new GUB installer for linux-x86 http://lilypond.org/schikkers-list/download/ version 0.0.1-1 should work ootb. Jan. -- Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.nl __

Re: PATCHES: 48-hour notice for mensural and bar-extent

2011-01-26 Thread Ian Hulin
Hi Graham, I'm replying off-list and slightly off-topic. I think Benkö Pál's given name is actually Pál (pron. almost exactly like English Paul). I think he's doing the Hungarian thing of signing his name with the surname first like Bartók Béla. Cheers, Ian __

Re: PATCHES: 48-hour notice for mensural and bar-extent

2011-01-26 Thread Benkő Pál
> I am aware that the mensural notation patch does not contain a > regtest.  I am arbitrarily and unilaterally deciding that this doesn't > matter in this specific case.  We pretty much abandoned ancient music > a few years ago; Benko is a very good contributor; he can make (or > modify) a regtest

Issue 37 - new work

2011-01-26 Thread Mike Solomon
Hey all, I have a new Issue 37 fix. The attached patch set implements a 2-pass approach through the quanting that is potentially a huge time drain in scores with lots of collisions, but likely not a time drain for most scores. The problem is that the quanting algorithm, by fixing a region siz