Re: sustainable development in LilyPond

2010-08-04 Thread Trevor Daniels
Graham Percival wrote Tuesday, August 03, 2010 3:31 AM As you might recall, I gave a talk at RMLL 2010 about sustainable development in F/OSS. Nice talk. It prompted me to think about my own involvement with LilyPond. I volunteered for doc development due to the guilt pressure at the start

Re: sustainable development in LilyPond

2010-08-04 Thread Graham Percival
On Wed, Aug 04, 2010 at 09:10:25AM +0100, Trevor Daniels wrote: > > 1) There is no architectural overview and no program logic manual to > guide new developers through the early stages. > This has the advantage that No; there's no advantage to this. It's simply due to an imbalance of high skill,

Re: sustainable development in LilyPond

2010-08-04 Thread Trevor Daniels
Graham Percival wrote Wednesday, August 04, 2010 9:41 AM On Wed, Aug 04, 2010 at 09:10:25AM +0100, Trevor Daniels wrote: 1) There is no architectural overview and no program logic manual to guide new developers through the early stages. This has the advantage that No; there's no advant

Re: sustainable development in LilyPond

2010-08-04 Thread David Kastrup
"Trevor Daniels" writes: > 1) There is no architectural overview and no program logic manual to > guide new developers through the early stages. > This has the advantage that only experienced and expert > coders able to deduce the design from the source code are > able to contribute significantly

Re: sustainable development in LilyPond

2010-08-04 Thread Trevor Daniels
David Kastrup wrote Wednesday, August 04, 2010 11:27 AM "Trevor Daniels" writes: 1) There is no architectural overview and no program logic manual to guide new developers through the early stages. This has the advantage that only experienced and expert coders able to deduce the design from

Which css file should the new web be using?

2010-08-04 Thread Trevor Daniels
Graham While looking into the @help in download.itexi (the font size used for smallexample) I noticed that the css file currently being used to build the web is css/lilypond-web.css. Is this correct? The css title is "Patrick McCarty's design" and there is a beautifully-laid out css file call

patch-reviewing and the i-ching (was Re: sustainable development in LilyPond)

2010-08-04 Thread Mike Solomon
On 8/4/10 1:25 PM, "Trevor Daniels" wrote: > > David Kastrup wrote Wednesday, August 04, 2010 11:27 AM > > >> "Trevor Daniels" writes: >> >>> 1) There is no architectural overview and no program logic manual >>> to >>> guide new developers through the early stages. >>> This has the advantage

Re: Which css file should the new web be using?

2010-08-04 Thread Graham Percival
On Wed, Aug 04, 2010 at 12:45:09PM +0100, Trevor Daniels wrote: > While looking into the @help in download.itexi (the font size used for > smallexample) Only if you're certain that it shouldn't be fixed in the texinfo, btw. I mean, it might be better to rewrite something, or end the itemized lis

Re: patch-reviewing and the i-ching (was Re: sustainable development in LilyPond)

2010-08-04 Thread Graham Percival
On Wed, Aug 04, 2010 at 02:33:30PM +0200, Mike Solomon wrote: > I am a bit lost with respect to what has to be done and who's working on > what, but I've been chipping away as best I can on issues that, to me, seem > under-commented-upon. In theory, the Status:Started, Owner:foo indicates that. I

Re: Which css file should the new web be using?

2010-08-04 Thread Patrick McCarty
On Wed, Aug 4, 2010 at 4:45 AM, Trevor Daniels wrote: > > While looking into the @help in download.itexi (the font size used for > smallexample) I > noticed that the css file currently being used to > build the web is css/lilypond-web.css.  Is this > correct? The css title is "Patrick McCarty's d

Re: Adds announce-end-grob to engraver-scheme.cc (issue1914043)

2010-08-04 Thread n . puttock
LGTM, pushed to master. Cheers, Neil http://codereview.appspot.com/1914043/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCH] Scheme binding for announce_end_grob

2010-08-04 Thread Neil Puttock
On 2 August 2010 13:35, Mike Solomon wrote: > http://codereview.appspot.com/1914043 Applied: http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=4ed35e481389eaddd6e07002f0b5ccad31994169 ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Adds scheme binding for Side_position_interface::set_axis (issue1880050)

2010-08-04 Thread n . puttock
On 2010/08/03 09:57:27, MikeSol wrote: I created a binding for chain_callback in grob-scheme.cc. Please see http://codereview.appspot.com/1890044 . I'm fine using this and then maybe making a scheme version of set_axis (i.e. side-position-interface::set-axis) in the appropriate .scm file.

Create ly:grob-chain-callback from chain_callback (issue1890044)

2010-08-04 Thread n . puttock
http://codereview.appspot.com/1890044/diff/1/2 File lily/grob-scheme.cc (right): http://codereview.appspot.com/1890044/diff/1/2#newcode407 lily/grob-scheme.cc:407: 3, 0, 0, (SCM grob, SCM proc, SCM sym), 0, (SCM grob http://codereview.appspot.com/1890044/diff/1/2#newcode415 lily/grob-scheme.cc

joining the frogs?

2010-08-04 Thread William Bajzek
Hello. I'd like to join the Frogs but my mailing list subscription hasn't gone through. Is it just a matter of waiting for someone's manual input, or is something wrong with the listserv? - William Bajzek williambaj...@gmail.com ___ lilypond-devel

Re: Create ly:grob-chain-callback from chain_callback (issue1890044)

2010-08-04 Thread mtsolo
Reviewers: Neil Puttock, http://codereview.appspot.com/1890044/diff/1/2 File lily/grob-scheme.cc (right): http://codereview.appspot.com/1890044/diff/1/2#newcode407 lily/grob-scheme.cc:407: 3, 0, 0, (SCM grob, SCM proc, SCM sym), On 2010/08/04 18:50:59, Neil Puttock wrote: 0, (SCM grob Done.

Re: joining the frogs?

2010-08-04 Thread William Bajzek
nevermind, it seems to be working now. On Aug 4, 2010, at 12:54 PM, William Bajzek wrote: > Hello. I'd like to join the Frogs but my mailing list subscription hasn't > gone through. Is it just a matter of waiting for someone's manual input, or > is something wrong with the listserv? > > - Wi

Fix for issue 1173 to fails when asked to showLastLength on partial measures. (issue1741060)

2010-08-04 Thread n . puttock
Reviewers: , Message: Hi Mike, Here are some general comments following testing: -) showFirstLength still doesn't work -) probably related to the above, but the combination of showFirstLength and showLastLength doesn't work -) if there's no time signature, showLastLength is ignored; this brea

Re: Fix for issue 1173 to fails when asked to showLastLength on partial measures. (issue1741060)

2010-08-04 Thread n . puttock
http://codereview.appspot.com/1741060/diff/1/4 File scm/music-functions.scm (right): http://codereview.appspot.com/1741060/diff/1/4#newcode534 scm/music-functions.scm:534: (set! (ly:music-property m 'den) den) These should come from the music (which means you'll be needing a fix for issue #1198:

Enhancement: Internal ledger lines. (issue1855056)

2010-08-04 Thread hanwenn
what's the plan for this patch/functionality ? the code looks a bit out of style. would it be possible to group all the internal-ledger code together? Without wanting to trample on feet, this looks like a feature that could easily bitrot due to lack of use, so it's good to make it easy to remove

Re: Enhancement: Internal ledger lines. (issue1855056)

2010-08-04 Thread n . puttock
Reviewers: hanwenn, Message: On 2010/08/04 21:44:58, hanwenn wrote: what's the plan for this patch/functionality ? the code looks a bit out of style. It's an old patch which Kevin Dalley posted ages ago: http://lists.gnu.org/archive/html/lilypond-devel/2007-03/msg00038.html I've removed th

Fix 442. (issue1888042)

2010-08-04 Thread n . puttock
Hi Joe, LGTM. I'd be quite happy with this method, even though it loses a bit of flexibility in comparison with your original patch. Cheers, Neil http://codereview.appspot.com/1888042/diff/1/5 File lily/keep-alive-together-engraver.cc (right): http://codereview.appspot.com/1888042/diff/1/5#n

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-04 Thread Ian Hulin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, On 01/08/10 22:37, Patrick McCarty wrote: > On Sun, Aug 1, 2010 at 2:02 PM, Neil Puttock wrote: >> On 1 August 2010 21:49, Patrick McCarty wrote: >> >>> I think I found the problem. >>> >>> With Guile 1.9, `module-public-interface' doesn't r

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-04 Thread Han-Wen Nienhuys
On Wed, Aug 4, 2010 at 8:13 PM, Ian Hulin wrote: > On 01/08/10 22:37, Patrick McCarty wrote: >> On Sun, Aug 1, 2010 at 2:02 PM, Neil Puttock wrote: >>> On 1 August 2010 21:49, Patrick McCarty wrote: >>> I think I found the problem. With Guile 1.9, `module-public-interface' doesn't