http://codereview.appspot.com/1741060/diff/1/4 File scm/music-functions.scm (right):
http://codereview.appspot.com/1741060/diff/1/4#newcode534 scm/music-functions.scm:534: (set! (ly:music-property m 'den) den) These should come from the music (which means you'll be needing a fix for issue #1198: \time requires a synthetic music object to generate the context property settings). We already have two music properties called `numerator' and `denominator' which could be used (it even appears that they might originally have had this purpose, judging by the docstrings, even though they're currently used for \times) http://codereview.appspot.com/1741060/diff/1/4#newcode932 scm/music-functions.scm:932: (define (generate-timing-alist music) needs a docstring (+ others below) http://codereview.appspot.com/1741060/diff/1/4#newcode936 scm/music-functions.scm:936: (define (time-helper music) Following a fix for #1198, this could be simplified http://codereview.appspot.com/1741060/diff/1/4#newcode1035 scm/music-functions.scm:1035: (integrated-measures This looks rather costly, since it will be called for all scores, even if show(First|Last)Length isn't set (skip-as-needed is a top-level music function, so it's applied automatically whenever the parser encounters music) http://codereview.appspot.com/1741060/show _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
