Re: random music

2010-07-21 Thread Martin Tarenskeen
On Tue, 20 Jul 2010, Graham Percival wrote: On Tue, Jul 20, 2010 at 06:17:51PM +0200, Martin Tarenskeen wrote: But thinking about this little project I was wondering: Would it be possible to write a lilypond input file, using just pure Lilypond syntax and some Scheme magick, that would produc

Font metric unused variable

2010-07-21 Thread Mike Solomon
Hey all, In compiling lilypond this morning, I saw this: font-metric.cc:82: warning: unused parameter 'k' Checking out the function in question, I saw this: Box Font_metric::get_indexed_char_dimensions (size_t k) const { return Box (Interval (0, 0), Interval (0, 0)); } Not knowing what th

Re: Font metric unused variable

2010-07-21 Thread Patrick McCarty
On Wed, Jul 21, 2010 at 4:51 AM, Mike Solomon wrote: > Hey all, >    In compiling lilypond this morning, I saw this: > > font-metric.cc:82: warning: unused parameter 'k' > > Checking out the function in question, I saw this: > > Box > Font_metric::get_indexed_char_dimensions (size_t k) const > { >

Re: Font metric unused variable

2010-07-21 Thread Patrick McCarty
On Wed, Jul 21, 2010 at 11:43 AM, Patrick McCarty wrote: > On Wed, Jul 21, 2010 at 4:51 AM, Mike Solomon wrote: >> Hey all, >>    In compiling lilypond this morning, I saw this: >> >> font-metric.cc:82: warning: unused parameter 'k' >> >> Checking out the function in question, I saw this: >> >> B

Re: Optimizations for pure-height approximations. (issue1817045)

2010-07-21 Thread joeneeman
On 2010/07/14 23:15:13, lemzwerg wrote: http://codereview.appspot.com/1817045/diff/1/4 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/1817045/diff/1/4#newcode1059 scm/define-grob-properties.scm:1059: Since the properties in this file are sorted alphabetically, this

Re: Optimizations for pure-height approximations. (issue1817045)

2010-07-21 Thread joeneeman
Reviewers: lemzwerg, Neil Puttock, Message: On 2010/07/15 22:04:58, Neil Puttock wrote: http://codereview.appspot.com/1817045/diff/1/2 File lily/axis-group-interface.cc (right): http://codereview.appspot.com/1817045/diff/1/2#newcode125 lily/axis-group-interface.cc:125: pure_height_cache = sc

Re: Optimizations for pure-height approximations. (issue1817045)

2010-07-21 Thread n . puttock
On 2010/07/21 20:16:56, joeneeman wrote: I can change it to 100, but it's still a bit worrying that a few measly hash tables end up taking so much memory (there should only be one per staff). Ah, don't worry, I think I see what's going on. It's creating a new hash table whenever the method'

Re: Optimizations for pure-height approximations. (issue1817045)

2010-07-21 Thread n . puttock
On 2010/07/21 21:04:38, Neil Puttock wrote: Ah, don't worry, I think I see what's going on. It's creating a new hash table whenever the method's called: + if (!to_boolean (scm_hash_table_p (pure_height_cache))) This is always true. I think it should be if (scm_hash_table_p (pure_h

[PATCH] Fix #1192 - System separator positioning

2010-07-21 Thread Neil Puttock
Hi everybody, Please review this patch here: http://codereview.appspot.com/1665053/show Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel