Keith OHara writes:
> David Kastrup gnu.org> writes:
>
>> "Keith OHara" oco.net> writes:
>>
>> > 'cross-staff' marks grobs whose positioning (relative to their parent)
>> > depends on the spacing of staves on the page. These grobs have to be
>> > positioned last, after all grobs moving with t
David Kastrup gnu.org> writes:
> "Keith OHara" oco.net> writes:
>
> > 'cross-staff' marks grobs whose positioning (relative to their parent)
> > depends on the spacing of staves on the page. These grobs have to be
> > positioned last, after all grobs moving with their parent Staff are
> > posi
"Keith OHara" writes:
> The various functions labeled pure do not all keep this promise. (My
> struggle today was using pure_vertical_stencil_from_extents on a
> note-column, and finding it set the cross-staff beam position, through
> various paths.) The code before Mike's two big commits does
On 22 août 2013, at 11:19, "Keith OHara" wrote:
> Positioning properties like 'Y-offset' are often linked to callback
> functions. When it is time to place a grob, LilyPond calls that function and
> stores the result in the property 'Y-offset', overwriting the link to the
> callback function
Positioning properties like 'Y-offset' are often linked to callback functions.
When it is time to place a grob, LilyPond calls that function and stores the
result in the property 'Y-offset', overwriting the link to the callback
function.
Sometimes, most notably during line/page-breaking, we w
On 14 août 2013, at 09:58, Keith OHara wrote:
>
>
> Mike posted three patches to issue 3385 that attempted to go halfway
> backwards, partially restoring the pure-relevant? test, but these
> ran into regressions.
>
> Going forward would be to make the pure versions of these functions,
> actua
David Kastrup gnu.org> writes:
> > (1) The positioning of fingerings using the outline of the note-column
> > (the last patch under issue 2527) is a user-visible improvement, so it
> > would be nice to keep it. I have posted patches to solve two issued
> > (3465 and 3363) were caused by the fing
Mike Solomon writes:
> On 13 août 2013, at 12:41, David Kastrup wrote:
>
>> We don't need a
>> whole reimplementation of old code for the sole purpose of temporarily
>> masking bugs with the new implementation by retro-fitting a distant
>> clone of the old implementation on top of the unfixed ne
On 13 août 2013, at 12:41, David Kastrup wrote:
> We don't need a
> whole reimplementation of old code for the sole purpose of temporarily
> masking bugs with the new implementation by retro-fitting a distant
> clone of the old implementation on top of the unfixed new
> implementation.
I put up
Mike Solomon writes:
> On 13 août 2013, at 11:59, David Kastrup wrote:
>
>> It's window dressing on bugs if the design does actually work properly,
>
> That's exactly what this is, but it allows us to isolate the bug and
> put a big TODO.
I don't see that it allows us "to isolate the bug" and i
On 13 août 2013, at 11:59, David Kastrup wrote:
> Mike Solomon writes:
>
>> The short term solution may be to create an internal property called
>> "pure-relevant", set it to #t as default for all grobs in the
>> Grob::Grob constructor and set to false only when necessary in
>> define-grobs.cc
Mike Solomon writes:
> The short term solution may be to create an internal property called
> "pure-relevant", set it to #t as default for all grobs in the
> Grob::Grob constructor and set to false only when necessary in
> define-grobs.cc. Then, write a big fat comment saying that the goal
> eve
"Keith OHara" writes:
> When solving regressions we have the choice to go forward or to retreat --
> to repair, or revert, the change that caused the regression.
>
> (1) The positioning of fingerings using the outline of the note-column
> (the last patch under issue 2527) is a user-visible improv
On 13 août 2013, at 11:33, "Keith OHara" wrote:
> When solving regressions we have the choice to go forward or to retreat --
> to repair, or revert, the change that caused the regression.
>
> (1) The positioning of fingerings using the outline of the note-column (the
> last patch under issue 25
When solving regressions we have the choice to go forward or to retreat --
to repair, or revert, the change that caused the regression.
(1) The positioning of fingerings using the outline of the note-column (the
last patch under issue 2527) is a user-visible improvement, so it would be nice
to
15 matches
Mail list logo
