Re: two patches for lilypad: accept?

2014-09-06 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: Cc: "Phil Holmes" Sent: Saturday, September 06, 2014 9:27 AM Subject: two patches for lilypad: accept? Hi guys, I see that there's two patches for lilypad: https://github.com/gperciva/lilypad/pull/4 ht

two patches for lilypad: accept?

2014-09-06 Thread Graham Percival
Hi guys, I see that there's two patches for lilypad: https://github.com/gperciva/lilypad/pull/4 https://github.com/gperciva/lilypad/pull/3 Are these good? I think that Phil Holmes (and Christian Hitz) can accept them with the github interface, but if not, please let me know if I should a

Re: Two patches

2012-02-24 Thread Marc Hohl
Am 24.02.2012 10:19, schrieb David Kastrup: Marc Hohl writes: Am 24.02.2012 09:30, schrieb David Kastrup: Marc Hohl writes: Hello list, there are two tiny patches concerning open strings and harmonics in tablature: http://lists.gnu.org/archive/html/lilypond-devel/2012-02/msg00541.html

Re: Two patches

2012-02-24 Thread David Kastrup
Marc Hohl writes: > Am 24.02.2012 09:30, schrieb David Kastrup: >> Marc Hohl writes: >> >>> Hello list, >>> >>> there are two tiny patches concerning open strings and harmonics in >>> tablature: >>> >>> >>> http://lists.gnu.org/archive/html/lilypond-devel/2012-02/msg00541.html >> "touching the s

Re: Two patches

2012-02-24 Thread Marc Hohl
Am 24.02.2012 09:30, schrieb David Kastrup: Marc Hohl writes: Hello list, there are two tiny patches concerning open strings and harmonics in tablature: http://lists.gnu.org/archive/html/lilypond-devel/2012-02/msg00541.html "touching the strings above fret" is misleading. You mean "at fre

Re: Two patches

2012-02-24 Thread David Kastrup
Marc Hohl writes: > Hello list, > > there are two tiny patches concerning open strings and harmonics in > tablature: > > > http://lists.gnu.org/archive/html/lilypond-devel/2012-02/msg00541.html "touching the strings above fret" is misleading. You mean "at fret". And "thanks to address@hidden" m

Two patches

2012-02-24 Thread Marc Hohl
Hello list, there are two tiny patches concerning open strings and harmonics in tablature: http://lists.gnu.org/archive/html/lilypond-devel/2012-02/msg00541.html http://lists.gnu.org/archive/html/lilypond-devel/2012-02/msg00451.html I am not allowed to push to dev/staging, so what is the fo

Re: two patches

2009-05-28 Thread John Mandereau
Carl D. Sorensen a écrit : So, in this particular case, changing Lilypond to LilyPond qualifies as a simple text subtitution, I guess? Yes. My confusion came from not understanding that the proposed patch constituted "General maintenance." All historical developers and contributors have n

Re: two patches

2009-05-27 Thread Carl D. Sorensen
On 5/27/09 5:51 PM, "John Mandereau" wrote: > Carl D. Sorensen a écrit : >> OK, so to make sure I understand correctly, >> >> a) The changes to Documentation/de/* that move Lilypond -> LilyPond are OK >> to commit, even though the commitish in the header of this file won't be >> updated. >>

Re: two patches

2009-05-27 Thread John Mandereau
John Mandereau a écrit : I thought all this policy was explained in the CG for a) and in po/README for b). BTW we should probably create a section in the CG for Git committers who apply patches in areas they understand but are not used to their policies, which would reference specific paragra

Re: two patches

2009-05-27 Thread John Mandereau
Carl D. Sorensen a écrit : OK, so to make sure I understand correctly, a) The changes to Documentation/de/* that move Lilypond -> LilyPond are OK to commit, even though the commitish in the header of this file won't be updated. b) the changes to po/* are NOT Ok to commit. Is this right? Yes

Re: [PATCHES] Re: FW: two patches

2009-05-27 Thread John Mandereau
Carl D. Sorensen a écrit : And I do believe that the po/* files need to change, because the english is being changed, but I'm not sure of the detailed process to make that happen. Again, see po/README. When you estimate the strings are not going to change too soon, bug me and I'll trigger the

Re: two patches

2009-05-27 Thread Francisco Vila
2009/5/27 Carl D. Sorensen : > a) The changes to Documentation/de/* that move Lilypond -> LilyPond are OK > to commit, even though the commitish in the header of this file won't be > updated. In particular, updating the committish for a file that is not up to date, would mark it as updated. Bad fo

Re: [PATCHES] Re: FW: two patches

2009-05-27 Thread Carl D. Sorensen
Mark, I have pushed 0001, 0002, 0003, and 0008. I modified 0007 and pushed it as well (I wanted to avoid the possessive ', as it can cause difficulty for non-native speakers, so I changed "fot" to "for" in the patch). I have *not* pushed patches 0004, 0005, or 0006, because they contain change

Re: two patches

2009-05-27 Thread Carl D. Sorensen
On 5/27/09 11:11 AM, "John Mandereau" wrote: > Carl D. Sorensen a écrit : >> Mark, >> >> I appreciate your good work on these patches. >> > > So do I :-) > > >> 2) I'm not sure how to handle patches to translated documents. I know that >> the translations need to follow a particular com

[PATCHES] Re: FW: two patches

2009-05-27 Thread Mark Polesky
0001-Lilypond-LilyPond.patch Description: Binary data 0002-Typos.patch Description: Binary data 0003-betweenLilypondSystem-betweenLilyPondSystem.patch Description: Binary data 0004-Lilypond-LilyPond-in-translated-docs.patch Description: Binary data 0005-betweenLilypondSystem-bet

Re: FW: two patches

2009-05-27 Thread John Mandereau
Carl D. Sorensen a écrit : Mark, I appreciate your good work on these patches. So do I :-) 2) I'm not sure how to handle patches to translated documents. I know that the translations need to follow a particular commit of the english docs. If the change in the translated documents refle

FW: two patches

2009-05-27 Thread Carl D. Sorensen
-- Forwarded Message From: Mark Polesky Date: Tue, 26 May 2009 02:46:02 -0600 To: "Carl D. Sorensen" Conversation: two patches Subject: two patches Carl, here are two more patches. By the way, *nobody* replied to my nifty proposal on -devel. Boo hoo. - Mark -- End of