Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-15 Thread dak
https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly#newcode1376 ly/music-functions-init.ly:1376: On 2013/01/15 05:09:46, Keith wrote: Perfect Comment

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-14 Thread k-ohara5a5a
https://codereview.appspot.com/7094044/diff/11001/lily/tuplet-iterator.cc File lily/tuplet-iterator.cc (right): https://codereview.appspot.com/7094044/diff/11001/lily/tuplet-iterator.cc#newcode139 lily/tuplet-iterator.cc:139: } lgtm https://codereview.appspot.com/7094044/diff/11001/ly/music-fun

Re: How should tupletSpannerDuration actually work?

2013-01-13 Thread Benkő Pál
2013/1/12 Phil Holmes : > - Original Message - From: "David Kastrup" > To: > Sent: Saturday, January 12, 2013 10:25 AM > Subject: How should tupletSpannerDuration actually work? > > > >> >> I

Re: How should tupletSpannerDuration actually work?

2013-01-13 Thread Hans Åberg
On 12 Jan 2013, at 12:53, David Kastrup wrote: > "Phil Holmes" writes: > >>> I have a hard time considering the output of >> >>> \version "2.16.0" >>> >>> \relative c' { >>> \set tupletSpannerDur

Re: How should tupletSpannerDuration actually work?

2013-01-13 Thread Hans Aberg
On 12 Jan 2013, at 12:53, David Kastrup wrote: > "Phil Holmes" writes: > >>> I have a hard time considering the output of >> >>> \version "2.16.0" >>> >>> \relative c' { >>> \set tupletSpannerDur

Re: How should tupletSpannerDuration actually work?

2013-01-13 Thread Hans Aberg
;>> >>>>> \version "2.16.0" >>>>> >>>>> \relative c' { >>>>> \set tupletSpannerDuration = #(ly:make-moment 1 2) >>>>> \times 2/3 { c8 d e f g a g f e d c d } >>>>> \set tupletSpannerDuration = #(ly:make-m

Re: How should tupletSpannerDuration actually work?

2013-01-13 Thread David Kastrup
Hans Åberg writes: > On 12 Jan 2013, at 12:53, David Kastrup wrote: > >> "Phil Holmes" writes: >> >>>> I have a hard time considering the output of >>> >>>> \version "2.16.0" >>>> >>>> \relative

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread ianhulin44
LGTM https://codereview.appspot.com/7094044/diff/4003/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/7094044/diff/4003/ly/music-functions-init.ly#newcode1372 ly/music-functions-init.ly:1372: ") LGTM https://codereview.appspot.com/7094044/ __

Re: How should tupletSpannerDuration actually work?

2013-01-12 Thread Keith OHara
David Kastrup gnu.org> writes: > I have a hard time considering the output of > > Attachment (xxx.ly): text/x-lilypond, 226 bytes > > useful: \relative c' { \set tupletSpannerDuration = #(ly:make-moment 1 2) \times 2/3 { c8 d e f g a g f e d c d } % % The tupl

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread dak
On 2013/01/12 16:43:42, Ian Hulin (gmail) wrote: tuplets specified by the current \tuplet command are to be subdivided. To unset it, use @code{\tupletSpan \default}. Doing this will ensure the spanner for the music on the current \tuplet command spans all the music, rather than the value

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread tdanielsmusic
On 2013/01/12 16:35:17, dak wrote: On 2013/01/12 16:16:55, Trevor Daniels wrote: > I prefer \tupletSpan \default too, but I don't think we should > advise users not to use \tupletSpan. The disadvantage of \tupletSpan is that it makes a non-local change. That's not copy&paste friendly and

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread ianhulin44
Thanks Trevor, good catch. Have re-drafted the doc-string accordingly. Cheers, Ian https://codereview.appspot.com/7094044/diff/2001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/7094044/diff/2001/ly/music-functions-init.ly#newcode1365 ly/mu

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread dak
On 2013/01/12 16:16:55, Trevor Daniels wrote: I prefer \tupletSpan \default too, but I don't think we should advise users not to use \tupletSpan. The disadvantage of \tupletSpan is that it makes a non-local change. That's not copy&paste friendly and leads to non-self-contained code pieces. T

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread tdanielsmusic
On 2013/01/12 15:49:56, Ian Hulin (gmail) wrote: tuplets specified by the current \tuplet command are to be subdivided. To unset, use @code{\tupletSpan \default}. Doing this will ensure the spanner for the music on the current \tuplet command spans all the music, rather than the value set

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread ianhulin44
OK, let's go with keeping \tupletSpan with a statement that it's not the preferred way of doing things, and use \tupletSpan \default as the unset. I know \tupletSpanOff may be less typing, but the name kind of implies it accepts #t/#f values. I've only commented on the doc-text for the \tupletSp

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread dak
ork was to make "easy triplets and tuplets", i.e. make handling of all the triplets and *uplets less daunting and a bit more readable by humans. Here is the NR example for tupletSpannerDuration and \times: > > { > \set tupletSpannerDuration = #(ly:make-moment 1 4)

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

2013-01-12 Thread ianhulin44
mand had a companion \tupletSpannerDuration command to allow a different length of spanner bracket from the total length of music "tupleted" music. \tupletSpannerDuration was implemented as a property for \times. Here is the NR example for tupletSpannerDuration and \times: { \set t

Re: How should tupletSpannerDuration actually work?

2013-01-12 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: > Sent: Saturday, January 12, 2013 10:25 AM > Subject: How should tupletSpannerDuration actually work? > > >> >> I have a hard time considering the output of

Re: How should tupletSpannerDuration actually work?

2013-01-12 Thread Phil Holmes
laced where they lie musically. -- Phil Holmes - Original Message - From: James To: Phil Holmes Cc: lilypond-devel@gnu.org ; David Kastrup Sent: Saturday, January 12, 2013 11:23 AM Subject: Re: How should tupletSpannerDuration actually work? Phil, On 12 January 2013

Re: How should tupletSpannerDuration actually work?

2013-01-12 Thread James
Phil, On 12 January 2013 11:20, Phil Holmes wrote: > - Original Message - From: "David Kastrup" > To: > Sent: Saturday, January 12, 2013 10:25 AM > Subject: How should tupletSpannerDuration actually work? > > > > >> I ha

Re: How should tupletSpannerDuration actually work?

2013-01-12 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: Sent: Saturday, January 12, 2013 10:25 AM Subject: How should tupletSpannerDuration actually work? I have a hard time considering the

How should tupletSpannerDuration actually work?

2013-01-12 Thread David Kastrup
I have a hard time considering the output of \version "2.16.0" \relative c' { \set tupletSpannerDuration = #(ly:make-moment 1 2) \times 2/3 { c8 d e f g a g f e d c d } \set tupletSpannerDuration = #(ly:make-moment 1 4) \times 2/3 { c4 d e f g a g f e d c d } } useful

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-11 Thread dak
eeds the tupletSpannerDuration property. Do it all in-line using the optional @var{duration} parameter. (Maybe call this spanner-duration). See comments below. See current patch: tupletSpannerDuration is not touched. It is only used when the optional duration argument is not given. If one wanted t

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-11 Thread ianhulin44
I don't think \tuplet needs the tupletSpannerDuration property. Do it all in-line using the optional @var{duration} parameter. (Maybe call this spanner-duration). See comments below. Cheers, Ian https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly File ly/music-func

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-11 Thread ianhulin44
Hi David, Please ignore most of my last post. It looks like you're doing stage one of what the [talk] [proposal] stuff was about. Many thanks, Ian https://codereview.appspot.com/7058068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https:/

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-11 Thread ianhulin44
Hi David, Thanks for spotting this may get lost. Actually getting this one finished after all the [talk] and [proposal] discussions was first on my list of things to do, but I have had to spend the holiday period in hospital, with access to only half of of my e-mails etc. I've only got access to

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread tdanielsmusic
On 2013/01/10 22:40:03, dak wrote: No good idea how to work this one reasonably since tupletSpannerDuration is being set permanently. Maybe one should scrap tupletSpannerDuration altogether and just encode the duration straight into the event? That's where it ends up anyway. Hu

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread dak
c } } No good idea how to work this one reasonably since tupletSpannerDuration is being set permanently. Maybe one should scrap tupletSpannerDuration altogether and just encode the duration straight into the event? That's where it ends up anyway. Huh, or keep tupletSpannerDuration aroun

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread benko . pal
good for a start but I have some problems with the duration parameter: 1. { \tuplet 3/2 { c8 c c c c c } \tuplet 3/2 4 { c8 c c c c c } \tuplet 3/2 { c8 c c c c c } } I found it ugly that the first and last input line are engraved differently (i.e. duration has an effect outside of its tup

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread tdanielsmusic
LGTM https://codereview.appspot.com/7058068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-09 Thread lemzwerg
LGTM. https://codereview.appspot.com/7058068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: tupletSpannerDuration

2002-12-20 Thread Guido Amoruso
On Fri, 2002-12-20 at 21:28, Han-Wen Nienhuys wrote: > > Hi, > > > > I'd like to know whether this is a bug or a no more supported feature in > > Lilypond 1.7.9. When I try to compile > > http://lilypond.org/stable/input/test/out-www/lily-54763654.ly, I get: > > Try running convert-ly on the .ly

tupletSpannerDuration

2002-12-20 Thread Han-Wen Nienhuys
[EMAIL PROTECTED] writes: > I resend this message as my mail-server has had some problems. > I haven't received it from the list and I don't know whether you have; > sorry for the mess! > > > > Hi, > > I'd like to know whether this is a bug or a no more supported feature in > Lilypond 1.7.9. W

tupletSpannerDuration

2002-12-20 Thread Guido Amoruso
Hi, I'd like to know whether this is a bug or a no more supported feature in Lilypond 1.7.9. When I try to compile http://lilypond.org/stable/input/test/out-www/lily-54763654.ly, I get: = Parsing...Backtrace: In /home/guido/Lily

tupletSpannerDuration

2002-12-20 Thread Guido Amoruso
I resend this message as my mail-server has had some problems. I haven't received it from the list and I don't know whether you have; sorry for the mess! Hi, I'd like to know whether this is a bug or a no more supported feature in Lilypond 1.7.9. When I try to compile http://lilypond.org/stable