Re: tabs vs. spaces in source code

2009-07-29 Thread Graham Percival
On Wed, Jul 29, 2009 at 11:13:52PM +0100, Neil Puttock wrote: > 2009/7/29 Graham Percival : > > > 6)  If we want to use this, the patch needs to be examined > > carefully.  There aren't many problems, but we definitely > > shouldn't apply it blindly.  (we'd have lost that good comment > > otherwis

Re: tabs vs. spaces in source code

2009-07-29 Thread Neil Puttock
2009/7/29 Graham Percival : > Let's tackle the cc files first.  I tried running it on everything > lily/*.cc, and ended up with a 126K diff. > > 1) many changes were simply moving */ to the left by 1 char. >   That's fine. I've amended these myself a few times, but it's just occurred to me the ex

Re: tabs vs. spaces in source code

2009-07-29 Thread Francisco Vila
2009/7/29 Graham Percival : > On Wed, Jul 29, 2009 at 10:12:11AM +0200, Francisco Vila wrote: >> $ emacs -batch vertically-spaced-context-engraver.cc --eval >> '(indent-region (point-min) (point-max) nil)' -f save-buffer >> >> (tested on cc files, seems to leave them as they currently are) > Is th

Re: tabs vs. spaces in source code

2009-07-29 Thread Graham Percival
On Wed, Jul 29, 2009 at 10:12:11AM +0200, Francisco Vila wrote: > Those two copyPasteable lines do work. Thanks, added to the CG. > $ emacs -batch vertically-spaced-context-engraver.cc --eval > '(indent-region (point-min) (point-max) nil)' -f save-buffer > > (tested on cc files, seems to leave t

Re: tabs vs. spaces in source code

2009-07-29 Thread Francisco Vila
Those two copyPasteable lines do work. 2009/7/29 Francisco Vila : >> If somebody could post command-line copy&paste for: >>  1) apply texinfo-all-menus-update to a file $ emacs -batch my-texinfo-file.tely -f texinfo-all-menus-update -f save-buffer (tested) or possibly $ emacs -batch my-texinfo

Re: tabs vs. spaces in source code

2009-07-29 Thread Francisco Vila
2009/7/29 Graham Percival : > As an aside, could somebody (Francisco?) post a copy&pasteable > line to use emacs for the source code formatting?  Yes, I could > read the emacs man page and try to figure out how to use the emacs > -batch command myself, but there's other things that are more > impor

Re: tabs vs. spaces in source code

2009-07-28 Thread Graham Percival
On Tue, Jul 28, 2009 at 09:19:43PM -0300, Han-Wen Nienhuys wrote: > On Tue, Jul 28, 2009 at 7:08 PM, Graham > Percival wrote: > > Seriously?  I'm *amazed* at all the work that Mark has been doing. > > Despite the handicap of using windows (can't compile lilypond, > > doesn't have the handy developm

Re: tabs vs. spaces in source code

2009-07-28 Thread Han-Wen Nienhuys
On Tue, Jul 28, 2009 at 7:08 PM, Graham Percival wrote: > On Tue, Jul 28, 2009 at 03:56:53PM +, Han-Wen Nienhuys wrote: >> On a larger scale, I am somewhat disappointed that a lot of the latest >> lilypond efforts seem to be centered around janitorial work.   While >> janitorial work is often u

Re: tabs vs. spaces in source code

2009-07-28 Thread Graham Percival
On Tue, Jul 28, 2009 at 03:56:53PM +, Han-Wen Nienhuys wrote: > On a larger scale, I am somewhat disappointed that a lot of the latest > lilypond efforts seem to be centered around janitorial work. While > janitorial work is often useful and a good way to introduce yourself > to a code base,

Re: tabs vs. spaces in source code

2009-07-28 Thread Han-Wen Nienhuys
On Tue, Jul 28, 2009 at 1:05 PM, Jan Nieuwenhuizen wrote: > Same for our Class_naming_scheme.  Now every project with classes has > their own naming scheme; while we were one of the first in GNU.  We > could(should) have made a point of standardizing that (or at least > pressing for a standard) fo

Re: tabs vs. spaces in source code

2009-07-28 Thread Jan Nieuwenhuizen
On ma, 2009-07-27 at 18:50 -0300, Han-Wen Nienhuys wrote: > On Mon, Jul 27, 2009 at 4:25 PM, Jan > Nieuwenhuizen wrote: > > > Maybe we can start a repository at savannah that collects snippets > > like this for all types of editor and all projects that decide to > > add a little enhancement over t

Re: tabs vs. spaces in source code

2009-07-28 Thread Peter Chubb
> "Carl" == Carl Sorensen writes: Carl> On 7/25/09 10:58 AM, "Mark Polesky" Carl> wrote: >> >> >> ...tabs in the source code... >> >> Werner Lemberg wrote: >>> I dislike them, too, but there are many editors which handle them >>> just fine. I don't see a problem here. >> But would you b

Re: tabs vs. spaces in source code

2009-07-27 Thread Han-Wen Nienhuys
On Mon, Jul 27, 2009 at 4:25 PM, Jan Nieuwenhuizen wrote: > Maybe we can start a repository at savannah that collects snippets > like this for all types of editor and all projects that decide to > add a little enhancement over the standard coding settings?  What > do you think?  That would make it

Re: tabs vs. spaces in source code

2009-07-27 Thread Jan Nieuwenhuizen
On ma, 2009-07-27 at 19:13 +0200, Nicolas Sceaux wrote: > Le 27 juil. 09 à 17:16, Han-Wen Nienhuys a écrit : > > > On Sat, Jul 25, 2009 at 5:30 AM, Graham > > Percival wrote: > >> On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: > > Sure - just include a .emacs snippet in the appropr

Re: tabs vs. spaces in source code

2009-07-27 Thread Nicolas Sceaux
Le 27 juil. 09 à 17:16, Han-Wen Nienhuys a écrit : On Sat, Jul 25, 2009 at 5:30 AM, Graham Percival wrote: On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: Thanks, Neil. My editor does confusing things with tabs. I hate them. Who would object if I just started running tabs->space

Re: tabs vs. spaces in source code

2009-07-27 Thread Han-Wen Nienhuys
On Sat, Jul 25, 2009 at 5:30 AM, Graham Percival wrote: > On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: >> Thanks, Neil. My editor does confusing things with tabs. >> I hate them. Who would object if I just started running >> tabs->spaces on the source docs? I think we should have >

Re: tabs vs. spaces in source code

2009-07-25 Thread John Mandereau
Le samedi 25 juillet 2009 à 09:58 -0700, Mark Polesky a écrit : > But even in such cases, as long as my tab-width matches the > tab-widths in the source, tabs2spaces should be fine. Is it > correct to say that git (or savannah) translates all tabs to 8 > spaces without exception? Git doesn't trans

Re: tabs vs. spaces in source code

2009-07-25 Thread Carl Sorensen
On 7/25/09 11:47 AM, "Mark Polesky" wrote: > > > Carl Sorensen wrote: >> No, Jan was not in favor of it unless it became a standard for >> GNU coding. Hence the comment on "first making it a standard" >> (i.e., a GNU standard) and "sending a patch to emacs-devel". >> >> The current standard

Re: tabs vs. spaces in source code

2009-07-25 Thread Hans Aberg
On 25 Jul 2009, at 19:39, Patrick McCarty wrote: One thing you could do right now, without awaiting approval, is to check for lines that have tabs *after* spaces at the beginning. These should be converted to tabs *followed* by spaces. This is not correct, as if tabs are set to 8 spaces, 2 sp

Re: tabs vs. spaces in source code

2009-07-25 Thread Mark Polesky
Carl Sorensen wrote: > No, Jan was not in favor of it unless it became a standard for > GNU coding. Hence the comment on "first making it a standard" > (i.e., a GNU standard) and "sending a patch to emacs-devel". > > The current standard is to let tabs and spaces be handled as > emacs handles them

Re: tabs vs. spaces in source code

2009-07-25 Thread Patrick McCarty
On Sat, Jul 25, 2009 at 09:58:26AM -0700, Mark Polesky wrote: > > Also, can we list all of the possible situations where we need to > retain tabs? Ian mentioned .make files; the last time this came up > Patrick McCarty mentioned something about demarcating syllables in > lyrics, which I don't thin

Re: tabs vs. spaces in source code

2009-07-25 Thread Carl Sorensen
On 7/25/09 10:58 AM, "Mark Polesky" wrote: > > > ...tabs in the source code... > > Werner Lemberg wrote: >> I dislike them, too, but there are many editors which handle >> them just fine. I don't see a problem here. > > But would you be *opposed* to a strict no-tab rule? > > Carl Sorense

Re: tabs vs. spaces in source code

2009-07-25 Thread Mark Polesky
Joe Neeman wrote: > I like spaces just fine, but I'd prefer it if you could hold off > on this for a little while. I have a big patch that I'd like to > merge and I'm not so keen on resolving a bunch of whitespace > conflicts... Okay, I'll make a note: I'll wait for Han-Wen, Jan, and Joe. Thanks

Re: tabs vs. spaces in source code

2009-07-25 Thread Joe Neeman
On Sat, 2009-07-25 at 09:58 -0700, Mark Polesky wrote: > ...tabs in the source code... > > Werner Lemberg wrote: > > I dislike them, too, but there are many editors which handle > > them just fine. I don't see a problem here. > > But would you be *opposed* to a strict no-tab rule? I like spaces

Re: tabs vs. spaces in source code

2009-07-25 Thread Mark Polesky
...tabs in the source code... Werner Lemberg wrote: > I dislike them, too, but there are many editors which handle > them just fine. I don't see a problem here. But would you be *opposed* to a strict no-tab rule? Carl Sorensen wrote: > The last communication we had about it, Han-Wen was > cond

Re: tabs vs. spaces in source code

2009-07-25 Thread Carl Sorensen
On 7/24/09 11:32 PM, "Mark Polesky" wrote: > > > Graham Percival wrote: > >> On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: >>> Thanks, Neil. My editor does confusing things with tabs. >>> I hate them. Who would object if I just started running >>> tabs->spaces on the source

Re: tabs vs. spaces in source code

2009-07-25 Thread Werner LEMBERG
>> Thanks, Neil. My editor does confusing things with tabs. Then use a different editor. >> I hate them. I dislike them, too, but there are many editors which handle them just fine. I don't see a problem here. Werner ___ lilypond-devel mailing

Re: tabs vs. spaces in source code

2009-07-25 Thread Ian Hulin
Hi Graham, Graham Percival wrote: On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: Thanks, Neil. My editor does confusing things with tabs. I hate them. Who would object if I just started running tabs->spaces on the source docs? I think we should have a strict no-tabs rule. And I'm

Re: tabs vs. spaces in source code

2009-07-24 Thread Patrick McCarty
On Fri, Jul 24, 2009 at 10:30:30PM -0700, Graham Percival wrote: > On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: > > Thanks, Neil. My editor does confusing things with tabs. > > I hate them. Who would object if I just started running > > tabs->spaces on the source docs? I think we s

Re: tabs vs. spaces in source code

2009-07-24 Thread Mark Polesky
Graham Percival wrote: > On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: > > Thanks, Neil. My editor does confusing things with tabs. > > I hate them. Who would object if I just started running > > tabs->spaces on the source docs? I think we should have > > a strict no-tabs rule. An

tabs vs. spaces in source code

2009-07-24 Thread Graham Percival
On Fri, Jul 24, 2009 at 06:15:31PM -0700, Mark Polesky wrote: > Thanks, Neil. My editor does confusing things with tabs. > I hate them. Who would object if I just started running > tabs->spaces on the source docs? I think we should have > a strict no-tabs rule. And I'm in good company: > http://lis