Re: fix representation switching from line-position to staff-space (issue 6778050)

On 2012/10/30 18:59:49, benko.pal wrote: 2012/10/30 David Kastrup : > Benkő Pál writes: > >> 2012/10/27 : >>> On 2012/10/27 20:34:35, benko.pal wrote: >>> I want staves with line-positions like (-2 0 2 4) work. >> >>> Why would somebody specify (-2 0 2 4) with t

Re: fix representation switching from line-position to staff-space (issue 6778050)

LGTM thanks! http://codereview.appspot.com/6778050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: fix representation switching from line-position to staff-space (issue 6778050)

Just two things that are not quite clear to me. http://codereview.appspot.com/6778050/diff/9001/lily/breathing-sign.cc File lily/breathing-sign.cc (right): http://codereview.appspot.com/6778050/diff/9001/lily/breathing-sign.cc#newcode83 lily/breathing-sign.cc:83: high/low enough. i have no idea

Re: fix representation switching from line-position to staff-space (issue 6778050)

2012/10/30 David Kastrup : > Benkő Pál writes: > >> 2012/10/27 : >>> On 2012/10/27 20:34:35, benko.pal wrote: >>> I want staves with line-positions like (-2 0 2 4) work. >> >>> Why would somebody specify (-2 0 2 4) with the expectation that the >>> results should be identical to (-3 -1 1 3)?

Re: fix representation switching from line-position to staff-space (issue 6778050)

Benkő Pál writes: > 2012/10/27 : >> On 2012/10/27 20:34:35, benko.pal wrote: >> >>> I want staves with line-positions like (-2 0 2 4) work. > >> Why would somebody specify (-2 0 2 4) with the expectation that the >> results should be identical to (-3 -1 1 3)? Why would he not specify >> (-3 -1

Re: fix representation switching from line-position to staff-space (issue 6778050)

http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc File lily/breathing-sign.cc (left): http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc#oldcode85 lily/breathing-sign.cc:85: ydim.widen (-0.25 * ydim.delta ()); Use ydim.length() so the reader does not wond

Re: fix representation switching from line-position to staff-space (issue 6778050)

2012/10/27 : > On 2012/10/27 20:34:35, benko.pal wrote: > >> I want staves with line-positions like (-2 0 2 4) work. > Why would somebody specify (-2 0 2 4) with the expectation that the > results should be identical to (-3 -1 1 3)? Why would he not specify > (-3 -1 1 3) in the first place then?

Re: fix representation switching from line-position to staff-space (issue 6778050)

On 2012/10/27 20:34:35, benko.pal wrote: I want staves with line-positions like (-2 0 2 4) work. Why would somebody specify (-2 0 2 4) with the expectation that the results should be identical to (-3 -1 1 3)? Why would he not specify (-3 -1 1 3) in the first place then? How is something "wor

Re: fix representation switching from line-position to staff-space (issue 6778050)

Reviewers: Keith, dak, http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc File lily/breathing-sign.cc (left): http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc#oldcode88 lily/breathing-sign.cc:88: int const int_dim = (int) ydim[i]; On 2012/10/27 19:36:21

Re: fix representation switching from line-position to staff-space (issue 6778050)

http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc File lily/breathing-sign.cc (left): http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc#oldcode88 lily/breathing-sign.cc:88: int const int_dim = (int) ydim[i]; On 2012/10/27 19:36:21, Keith wrote: If you w

fix representation switching from line-position to staff-space (issue 6778050)

The regression tester looks for changed X/Y-extents, but gregorian.ly enlarges the extents of the BreathingSign so it can be used for these bar-line-like-things without letting notes overlap, so the regression tester does not notice these changes. http://codereview.appspot.com/6778050/diff/1001/