Re: exact inversion (issue4173065)

2011-02-22 Thread Benkő Pál
> Pushed to git/origin/master 22 Feb 11 > d245674e0266cde01a425317fa28aeb792ce589d > 7230509dd005d9bbc7b2a7f0a064abc2de3b0ce6 > > plus doc changes > 28c797d550d5557e75842c59a459aa48349e7ad5 > 94cce45d444cd6700d3f4df84cda68fb7de96cd7 thanks again! p ___

Re: exact inversion (issue4173065)

2011-02-22 Thread tdanielsmusic
Pushed to git/origin/master 22 Feb 11 d245674e0266cde01a425317fa28aeb792ce589d 7230509dd005d9bbc7b2a7f0a064abc2de3b0ce6 plus doc changes 28c797d550d5557e75842c59a459aa48349e7ad5 94cce45d444cd6700d3f4df84cda68fb7de96cd7 Trevor http://codereview.appspot.com/4173065/ _

Re: exact inversion (issue4173065)

2011-02-22 Thread Benkő Pál
>> should I move retrograde into its own section now or is there a >> volunteer who can improve the documentation on transpose and >> inversion as well after pushing as is? > > I'm happy to fix up the documentation, so I will > apply this as-is if I hear nothing contrary in the > near future. than

Re: exact inversion (issue4173065)

2011-02-22 Thread Trevor Daniels
Benkő Pál wrote Tuesday, February 22, 2011 10:56 AM should I move retrograde into its own section now or is there a volunteer who can improve the documentation on transpose and inversion as well after pushing as is? I'm happy to fix up the documentation, so I will apply this as-is if I hear n

Re: exact inversion (issue4173065)

2011-02-22 Thread Benkő Pál
> The patch works fine, but the documentation could be improved. agreed. > Expanding the example in a different section to show \inversion is not > optimal. sorry, I don't get that. > We need an @lilypond{} immediately after the @example showing > the syntax in the Inversion section. > > Also,

Re: exact inversion (issue4173065)

2011-02-22 Thread tdanielsmusic
The patch works fine, but the documentation could be improved. Expanding the example in a different section to show \inversion is not optimal. We need an @lilypond{} immediately after the @example showing the syntax in the Inversion section. Also, with this addition, it would be sensible to take

Re: exact inversion (issue4173065)

2011-02-21 Thread percival . music . ca
LTGM, passes regtests. http://codereview.appspot.com/4173065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: exact inversion (issue4173065)

2011-02-21 Thread pkx166h
NR edits LGTM - can't comment on the other .ly files. Sorry. http://codereview.appspot.com/4173065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: exact inversion (issue4173065)

2011-02-20 Thread benko . pal
Just minor stuff for the NR. all implemented. http://codereview.appspot.com/4173065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: exact inversion (issue4173065)

2011-02-19 Thread pkx166h
Just minor stuff for the NR. James http://codereview.appspot.com/4173065/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4173065/diff/1/Documentation/notation/pitches.itely#newcode823 Documentation/notation/pitches.it

exact inversion (issue4173065)

2011-02-19 Thread benko . pal
Reviewers: , Message: following up on modal transformation Description: exact inversion Please review this at http://codereview.appspot.com/4173065/ Affected files: M Documentation/notation/pitches.itely M input/regression/modal-transforms.ly M ly/music-functions-init.ly M scm/modal-tr