Re: When cloning a lexer/parser, don't copy the scopes. (issue 6460064)

2012-08-10 Thread dak
On 2012/08/10 16:20:30, hanwenn wrote: On 2012/08/10 16:16:47, dak wrote: > > and #{ ... #} looks for "parser", and you don't want to change the name of the > first argument of music functions. the first name of the music function argument is irrelevant, as it locally scoped. Wrong. #{

Re: When cloning a lexer/parser, don't copy the scopes. (issue 6460064)

2012-08-10 Thread hanwenn
On 2012/08/10 16:16:47, dak wrote: On 2012/08/10 16:14:55, hanwenn wrote: > http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc > File lily/lily-parser.cc (right): > > http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc#newcode160 > lily/lily-parser.cc:160: // TO

Re: When cloning a lexer/parser, don't copy the scopes. (issue 6460064)

2012-08-10 Thread dak
On 2012/08/10 16:14:55, hanwenn wrote: http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc File lily/lily-parser.cc (right): http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc#newcode160 lily/lily-parser.cc:160: // TODO: use $parser On 2012/08/10 07:13:58, dak

Re: When cloning a lexer/parser, don't copy the scopes. (issue 6460064)

2012-08-10 Thread hanwenn
http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc File lily/lily-parser.cc (right): http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc#newcode160 lily/lily-parser.cc:160: // TODO: use $parser On 2012/08/10 07:13:58, dak wrote: On 2012/08/10 06:58:57, Trevor Da

Re: When cloning a lexer/parser, don't copy the scopes. (issue 6460064)

2012-08-10 Thread dak
Reviewers: Trevor Daniels, http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc File lily/lily-parser.cc (right): http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc#newcode160 lily/lily-parser.cc:160: // TODO: use $parser On 2012/08/10 06:58:57, Trevor Daniels wr

When cloning a lexer/parser, don't copy the scopes. (issue 6460064)

2012-08-09 Thread tdanielsmusic
http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc File lily/lily-parser.cc (right): http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc#newcode160 lily/lily-parser.cc:160: // TODO: use $parser Either this comment should be removed, or the earlier one should be l