http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc File lily/lily-parser.cc (right):
http://codereview.appspot.com/6460064/diff/4001/lily/lily-parser.cc#newcode160 lily/lily-parser.cc:160: // TODO: use $parser On 2012/08/10 07:13:58, dak wrote:
On 2012/08/10 06:58:57, Trevor Daniels wrote: > Either this comment should be removed, or the > earlier one should be left in. Sorry, I don't > understand enough of this to know which.
There is not enough context to figure out what the author of the
comment was
aiming for. That's why I took the other comment out. Will remove
this one as
well but not submit a separate review.
If memory serves, this is about changing the name for this variable to indicate it is internal. I'm also not sure how badly things will break (eg. in safe mode), if someone does parser = "foo" http://codereview.appspot.com/6460064/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
