Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-10-22 Thread Ian Hulin
Hi Patrick, Patch is attached. Cheers, Ian On 18/10/10 21:31, pnor...@gmail.com wrote: > LGTM. > > Ian, please send me the git patch, and I'll apply it for you. > > Thanks, > Patrick > > http://codereview.appspot.com/2204044/ >From a12cb1e44df280a1f4320d2be1ebb34711f979f4 Mon Sep 17 00:00:00

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-10-19 Thread Patrick McCarty
On Tue, Oct 19, 2010 at 11:31 AM, Ian Hulin wrote: >  Hi Patrick, > > Patch is attached. Thanks, I've pushed it. Regards, Patrick ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-10-18 Thread pnorcks
LGTM. Ian, please send me the git patch, and I'll apply it for you. Thanks, Patrick http://codereview.appspot.com/2204044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-10-18 Thread ianhulin44
http://codereview.appspot.com/2204044/diff/14001/flower/include/guile-compatibility.hh File flower/include/guile-compatibility.hh (right): http://codereview.appspot.com/2204044/diff/14001/flower/include/guile-compatibility.hh#newcode28 flower/include/guile-compatibility.hh:28: #define scm_to_uns

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-10-07 Thread pnorcks
Hi Ian, Just a few more comments for you. I am okay with using scm_to_uint(); that looks like a safe route for us to take. Thanks, Patrick http://codereview.appspot.com/2204044/diff/14001/flower/include/guile-compatibility.hh File flower/include/guile-compatibility.hh (right): http://coderev

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-10-03 Thread ianhulin44
New patch-set uploaded. I've added changes to dispatcher.cc as suggested by Patrick. scm_to_uint32 --> scm_to_int in guile-compatibility.hh and grob-array-scheme.cc, #else // comments changed as requested. Cheers, Ian http://codereview.appspot.com/2204044/diff/7001/flower/include/guile-compati

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-09-30 Thread pnorcks
Ian, One more thing: There are two more instances of scm_int2num in lily/dispatcher.cc that you can replace with scm_from_int. Thanks, Patrick http://codereview.appspot.com/2204044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-09-30 Thread pnorcks
Hi Ian, Looks good mostly, though I haven't compiled anything yet. I just have a few comments for you. Thanks, Patrick http://codereview.appspot.com/2204044/diff/7001/flower/include/guile-compatibility.hh File flower/include/guile-compatibility.hh (right): http://codereview.appspot.com/22040

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-09-26 Thread ianhulin44
Reviewers: Neil Puttock, Patrick McCarty, carl.d.sorensen_gmail.com, hanwenn, Message: On 2010/09/25 22:07:53, Neil Puttock wrote: Hi Ian, Can you upload a revised patchset without all the tab->space changes please? Working ... I'm not sure about gutting guile-compatibility.hh: as part

T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-09-25 Thread n . puttock
Hi Ian, Can you upload a revised patchset without all the tab->space changes please? I'm not sure about gutting guile-compatibility.hh: as part of LilyPond at one remove from the core code, I don't see any harm in keeping it. Besides, there are a few macros in there which are required if compili