Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Janek Warchoł
2011/7/11 Neil Puttock : > Thanks, pushed to master. Thanks, issue closed. cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Neil Puttock
2011/7/11 Janek Warchoł : > Sorry, i didn't notice. > Attached is a nicely described patch. Thanks, pushed to master. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Janek Warchoł
2011/7/11 Neil Puttock : > 2011/7/11 Janek Warchoł : >> 2011/7/11 Graham Breed : >>> Is that me?  I'm supposed to do something?  Here's a patch >> >> Perfect! >> >> Mike: please push this. > > Please don't push without adding a commit message. Sorry, i didn't notice. Attached is a nicely described

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Neil Puttock
2011/7/11 Janek Warchoł : > 2011/7/11 Graham Breed : >> Is that me?  I'm supposed to do something?  Here's a patch > > Perfect! > > Mike: please push this. Please don't push without adding a commit message. Thanks, Neil ___ lilypond-devel mailing list

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Janek Warchoł
2011/7/11 Graham Breed : > Is that me?  I'm supposed to do something?  Here's a patch Perfect! Mike: please push this. Colin: sorry for overlooking that the countdown was over. We definately need an integrated patch/issue tracker! cheers, Janek From 54d259942dd3a7d0c5461ca71b111796be2f59ec Mon

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Graham Breed
lemniskata.bernoull...@gmail.com wrote: > Graham, > > I'm worried that i don't hear anything from you since 2 > weeks! Do you experience any problems with fixing code > style issues pointed to by Neil? Is that me? I'm supposed to do something? Here's a patch Graham >From 2d6bc54fa0

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-10 Thread lemniskata . bernoullego
Graham, I'm worried that i don't hear anything from you since 2 weeks! Do you experience any problems with fixing code style issues pointed to by Neil? If you are very busy, i can fix them myself, but i'd prefer that you fix them and send me the collection of all patches, up-to-date (this will mi

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-04 Thread Carl . D . Sorensen
LGTM, with Neil's comments taken Carl http://codereview.appspot.com/4654063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Small pitch bends correct and tested. (issue4654063)

2011-06-26 Thread n . puttock
LGTM. http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc File lily/midi-item.cc (right): http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc#newcode202 lily/midi-item.cc:202: + audio_->transposing_.tone_pitch ()) * Rational (2)); indent: ((audio_ + audio http://codere

Re: Small pitch bends correct and tested. (issue4654063)

2011-06-26 Thread Graham Breed
Colin Campbell wrote: > Thanks for this, Graham! I've added this to the tracker > as issue 1711. Can you also provide a test file which > would demonstrate the problem? I recognise this may not > be all that easy to do, but it would help in verifying > the fix. Here's an example based on one Ri

Re: Small pitch bends correct and tested. (issue4654063)

2011-06-25 Thread k-ohara5a5a
Looks, and sounds, good to me. http://codereview.appspot.com/4654063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Small pitch bends correct and tested. (issue4654063)

2011-06-25 Thread Colin Campbell
On 11-06-25 02:13 PM, lemniskata.bernoull...@gmail.com wrote: Graham Breed wrote: I've found and patched two problems with the pitch bend tuning code: 1) The pitch isn't always rounded to the nearest equally tempered value, so the result looks strange in a sequencer, and artifacts caused by the

Small pitch bends correct and tested. (issue4654063)

2011-06-25 Thread lemniskata . bernoullego
Reviewers: gbreed, Message: Graham Breed wrote: I've found and patched two problems with the pitch bend tuning code: 1) The pitch isn't always rounded to the nearest equally tempered value, so the result looks strange in a sequencer, and artifacts caused by the pitch bends are more severe. 2)