Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-27 Thread n . puttock
On 2010/06/23 01:51:10, Carl wrote: As far as the indentation on the alist goes, did you reindent the whole list, or just the beam-settings part? I ask this, because the sample you gave has different indentation for beam-settings than for the time signature. It's indented from the start o

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-23 Thread Kieren MacMillan
Hi all, >>> Let me summarize: >>> >>> OLD NEW >>> 3/4 >>> f4 r8 f8[ f f]f4 r8 f8 f8[ f] >>> f4. f8[ b8. a16] f4. f8 b8.[ a16] >>> >>> 4/4 >>> r8 f8[ f f] f8[ f f f] r8 f8 f8[ f] f8[ f f f] >>> >>> So are these beaming rules correct, or at least bett

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-23 Thread Carl Sorensen
On 6/23/10 2:55 AM, "Trevor Daniels" wrote: >> On 6/16/10 3:18 AM, "Trevor Daniels" >> wrote: >>> Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM > Well, I'm no expert either. My snippet above is based > on Ross, p 92, which says "Do not notate a 3/4 measure > that looks like a measure

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-23 Thread Trevor Daniels
Carl, you wrote Monday, June 21, 2010 10:10 PM Sorry for the delay - I've been away and it took a while to catch up with my mail. On 6/16/10 3:18 AM, "Trevor Daniels" wrote: Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM Description: Revised autobeam settings patch -- cleaned up deb

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-22 Thread Carl . D . Sorensen
THanks for the review, Neil. As far as the indentation on the alist goes, did you reindent the whole list, or just the beam-settings part? I ask this, because the sample you gave has different indentation for beam-settings than for the time signature. Thanks, Carl http://codereview.appspot.

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-22 Thread n . puttock
Hi Carl, Here are some preliminary comments. I'll try to give the patch a more thorough going over at the weekend. The indentation for the alist in time-signature-settings.scm is a bit compressed (particularly for beam-settings). Here's a sample of how it looks after reindentation: (define-pu

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-21 Thread Carl Sorensen
On 6/16/10 3:18 AM, "Trevor Daniels" wrote: > > > Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM > >> Description: >> Revised autobeam settings patch -- cleaned up debug comments >> in code and eliminated the irrelevant changes in >> Documentation/snippets just due to running makelsr.py

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-20 Thread n . puttock
On 2010/06/19 04:55:25, Carl wrote: Both versions can be used, according to Ross. The reason we have 2/8 standing alone is to prevent 2/8, 3/8, and 4/8 from being beamed together in 3/4 time, where that would be an error. I don't consider that an error; it's traditional typesetting style.

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-18 Thread Carl . D . Sorensen
Oh, I forgot to mention that a new version of the patch has been posted for review. THanks, Carl http://codereview.appspot.com/1667044/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-18 Thread Carl . D . Sorensen
On 2010/06/16 23:31:23, Neil Puttock wrote: Carl, have you looked at the regtest output? Yes, but I made a mistake when I did so. I've now got the regtest output all working right except for one beam in measure 5 of slur-scoring.ly. In the baseline, notes 2/8, 3/8, and 4/8 are all beamed toge

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-16 Thread n . puttock
Carl, have you looked at the regtest output? I've copied time-signature-settings.scm from the other set (I assume it's correct) and run `make check'; there's a significant number of changed tests showing up. In particular, 6/8, 9/8 and 12/8 tests are mostly unbeamed. There's some weirdness goin

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-16 Thread n . puttock
Hi Carl, There's a file missing from this set: time-signature-settings.scm. Cheers, Neil http://codereview.appspot.com/1667044/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-16 Thread Carl Sorensen
On 6/16/10 3:18 AM, "Trevor Daniels" wrote: > > > Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM > >> Description: >> Revised autobeam settings patch -- cleaned up debug comments >> in code and eliminated the irrelevant changes in >> Documentation/snippets just due to running makelsr.p

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-16 Thread Carl Sorensen
On 6/16/10 3:18 AM, "Trevor Daniels" wrote: > > > Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM > >> Description: >> Revised autobeam settings patch -- cleaned up debug comments >> in code and eliminated the irrelevant changes in >> Documentation/snippets just due to running makelsr

Re: Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-16 Thread Trevor Daniels
Carl.D.Sorensen wrote Tuesday, June 15, 2010 11:27 PM Description: Revised autobeam settings patch -- cleaned up debug comments in code and eliminated the irrelevant changes in Documentation/snippets just due to running makelsr.py Please review this at http://codereview.appspot.com/1667044/sho

Revised autobeam settings patch -- cleaned up debug comments (issue1667044)

2010-06-15 Thread Carl . D . Sorensen
Reviewers: , Message: I've posted a revised patch under a new issue, because I was working with my git branches to get the patch to only include the changed files. I've eliminated the leftover debug code, fixed up the mistakes in ly/bagpipe.ly, and adjusted the description of timeSignatureSettin