Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-17 Thread dak
On 2013/03/18 00:00:13, aleksandr.andreev wrote: Sorry, I should have checked the output more carefully. (Then again, Pál said above that the changes "didn't matter"). Ancient music usually tries very hard to avoid ledger lines which is one of the reasons for its multitude of clefs. So bein

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-17 Thread aleksandr . andreev
On 2013/03/16 09:09:29, dak wrote: So many pitches are wrong in this patch that I think we should revert it and have it redone carefully. I do not have push access, so I cannot do much at this point. Can you revert it then? Possibly using some automatism (like Frescobaldi's absolute/relati

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-16 Thread dak
So many pitches are wrong in this patch that I think we should revert it and have it redone carefully. Possibly using some automatism (like Frescobaldi's absolute/relative conversions, making sure that one gets the starting pitch right). As it stands, this just changes too much. https://codere

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-12 Thread janek . lilypond
LGTM Janek PS i dedicate all my code reviews to Graham Percival. +1 for Graham! https://codereview.appspot.com/7538043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-11 Thread graham
LGTM https://codereview.appspot.com/7538043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-07 Thread dak
On 2013/03/07 21:25:04, benko.pal wrote: https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely#newcode952 Documentation/not

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-07 Thread benko . pal
https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely#newcode952 Documentation/notation/ancient.itely:952: @c @end example On 2

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-07 Thread aleksandr . andreev
https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely#newcode952 Documentation/notation/ancient.itely:952: @c @end example On 2

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-07 Thread benko . pal
some white mensural examples change, but that doesn't matter (if anybody prefers not changing an example, I can fix those). I hope Greogrian examples don't change - I don't know whether it would matter. https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely File D

Re: Change \transpose to \relative in ancient.itely (issue 7538043)

2013-03-06 Thread tdanielsmusic
LGTM, apart from a couple of nitpicks. Thanks! Trevor https://codereview.appspot.com/7538043/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/7538043/diff/1/Documentation/notation/ancient.itely#newcode1686 Documenta