Re: [PATCH] Fix crash when output-preview-framework is missing

2009-06-07 Thread Neil Puttock
2009/6/4 Patrick McCarty : > Any comments for this revised patch?  The only things I changed were > the warning messages. Reinhold's suggestion for the message is an improvement, so I'm happy to apply the revised patch. Regards, Neil ___ lilypond-dev

Re: [PATCH] Fix crash when output-preview-framework is missing

2009-06-04 Thread Patrick McCarty
On Thu, May 28, 2009 at 4:51 PM, Patrick McCarty wrote: > On Thu, May 28, 2009 at 4:45 PM, Patrick McCarty wrote: >> On Thu, May 28, 2009 at 10:46:11PM +0200, Reinhold Kainhofer wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> Am Donnerstag, 28. Mai 2009 22:18:23 schrieb Neil

Re: [PATCH] Fix crash when output-preview-framework is missing

2009-05-28 Thread Patrick McCarty
On Thu, May 28, 2009 at 4:45 PM, Patrick McCarty wrote: > On Thu, May 28, 2009 at 10:46:11PM +0200, Reinhold Kainhofer wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Am Donnerstag, 28. Mai 2009 22:18:23 schrieb Neil Puttock: >> > +   warning (_f ("the `%s' backend does not suppor

Re: [PATCH] Fix crash when output-preview-framework is missing

2009-05-28 Thread Patrick McCarty
On Thu, May 28, 2009 at 10:46:11PM +0200, Reinhold Kainhofer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am Donnerstag, 28. Mai 2009 22:18:23 schrieb Neil Puttock: > > + warning (_f ("the `%s' backend does not support -dprint-pages", > > +get_output_backend_name

Re: [PATCH] Fix crash when output-preview-framework is missing

2009-05-28 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Donnerstag, 28. Mai 2009 22:18:23 schrieb Neil Puttock: > + warning (_f ("the `%s' backend does not support -dprint-pages", > + get_output_backend_name ())); > > + warning (_f ("the `%s' backend does not support -dpreview",

Re: [PATCH] Fix crash when output-preview-framework is missing

2009-05-28 Thread Neil Puttock
2009/5/28 Patrick McCarty : > Attached is a revised patch. That was quick. :) LGTM. + warning (_f ("the `%s' backend does not support -dprint-pages", +get_output_backend_name ())); + warning (_f ("the `%s' backend does not support -dpreview", +

Re: [PATCH] Fix crash when output-preview-framework is missing

2009-05-28 Thread Patrick McCarty
On Wed, May 27, 2009 at 6:04 PM, Patrick McCarty wrote: > Hello, > > This patch fixes a crash that occurs when the specified backend does > not have an output-preview-framework (used for -dpreview). > > I also added a similar check for output-framework just in case a user > tries to add a new back