Re: Piano pedalling patch

2002-03-18 Thread Han-Wen Nienhuys
[EMAIL PROTECTED] writes: > On Fri, Mar 15, 2002 at 02:24:26PM +0100, Han-Wen Nienhuys wrote: > > > /* Hmm. TODO: This should be set in grob-description.scm, but > > side-positioning of consecutive brackets only seems to work if > > direction is +1 within the engraver */ > > I sho

Re: Piano pedalling patch

2002-03-18 Thread Chris Jackson
On Fri, Mar 15, 2002 at 02:24:26PM +0100, Han-Wen Nienhuys wrote: > /* Hmm. TODO: This should be set in grob-description.scm, but > side-positioning of consecutive brackets only seems to work if > direction is +1 within the engraver */ I should explain my confusion about directi

Re: Piano pedalling patch

2002-03-15 Thread Jan Nieuwenhuizen
Han-Wen Nienhuys <[EMAIL PROTECTED]> writes: > it is, angle-{left,right} should go, and edge-width should be renamed > to something like "bracket-edge-flare", or "edge-flare" a flare is something of a bulb or circle, why not edge-line or edge-serif or so. -- Jan Nieuwenhuizen <[EMAIL PROTECTED

Re: Piano pedalling patch

2002-03-15 Thread Han-Wen Nienhuys
[EMAIL PROTECTED] writes: > Han-Wen Nienhuys <[EMAIL PROTECTED]> writes: > > > it is, angle-{left,right} should go, and edge-width should be renamed > > to something like "bracket-edge-flare", or "edge-flare" > > a flare is something of a bulb or circle, why not edge-line or > edge-serif or so.

Re: Piano pedalling patch

2002-03-15 Thread Rune Zedeler
Citat Chris Jackson <[EMAIL PROTECTED]>: > There's a couple of TODOs, regarding Rune's comments about pedals > extending to the end of notes, and support for __| |__ or __| Ped. > instead of __/\__. It is quite easy to hack temporary solutions if you accepts small spacing bugs - but ofcourse i

Re: Piano pedalling patch

2002-03-15 Thread Han-Wen Nienhuys
[EMAIL PROTECTED] writes: > Attached is a new version of the piano pedal stuff, which puts > pedal-specific text spanner properties in a new grob > (PianoPedalBracket), replaces gh_scm2bool with to_boolean, and > adds some conditionals for undefined properties. > > There's a couple of TODOs, reg

Re: Piano pedalling patch

2002-03-15 Thread Chris Jackson
Attached is a new version of the piano pedal stuff, which puts pedal-specific text spanner properties in a new grob (PianoPedalBracket), replaces gh_scm2bool with to_boolean, and adds some conditionals for undefined properties. There's a couple of TODOs, regarding Rune's comments about pedals ex

Re: Piano pedalling patch

2002-03-13 Thread Juergen Reuter
> The spacing is pretty much finished for now; the reg test for .39 > comes out cleanly (except for spacing-factor, but I haven't decided > how to make the spacing tweakable yet). Nice to hear. Mensural notation will need a spacing algorithm of its own (basically, something similar to TeX's \rag

Re: Piano pedalling patch

2002-03-13 Thread Han-Wen Nienhuys
[EMAIL PROTECTED] writes: > > the existing code for Ped. *. I also had trouble coding the length of > > the line so that it lasted to the end of the note and no further. > > I understand the problem... Hmm, perhaps it is also an unwise thing to do while > Han-Wen is still hacking in the spacing r

Re: Piano pedalling patch

2002-03-13 Thread Rune Zedeler
Citat Chris Jackson <[EMAIL PROTECTED]>: > That's odd. I seem to remember finding this problem once and fixing > it. Okay, it seems like the problem is only in 'mixed style (and not in 'bracket style). So you fixed the bug but forgot that the fix should apply in both modes. :-) > > - how do yo

Re: Piano pedalling patch

2002-03-13 Thread Chris Jackson
On Tue, Mar 12, 2002 at 12:52:21PM +0100, Han-Wen Nienhuys wrote: > >s->set_grob_property ("direction", gh_int2scm(-1)); > >+ s->set_grob_property ("width-correct", gh_double2scm(0)); > >+ s->set_grob_property ("type", ly_symbol2scm ("line")); > >+ s->set_grob_property ("outer", gh_bool2scm (t

Re: Piano pedalling patch

2002-03-13 Thread Chris Jackson
On Wed, Mar 13, 2002 at 01:18:11AM +0100, Han-Wen Nienhuys wrote: > [EMAIL PROTECTED] writes: > > On Tue, Mar 12, 2002 at 12:52:46AM +0100, Rune Zedeler wrote: > > > Chris Jackson wrote: > > > > > > > I've been hacking around with piano pedalling, to try to implement > > > > bracketed pedals, and

Re: Piano pedalling patch

2002-03-12 Thread Han-Wen Nienhuys
[EMAIL PROTECTED] writes: > On Tue, Mar 12, 2002 at 12:52:46AM +0100, Rune Zedeler wrote: > > Chris Jackson wrote: > > > > > I've been hacking around with piano pedalling, to try to implement > > > bracketed pedals, and my patch is now ready to be tested. > > > > And a bug: The horisontal line i

Re: Piano pedalling patch

2002-03-12 Thread Chris Jackson
On Tue, Mar 12, 2002 at 12:52:46AM +0100, Rune Zedeler wrote: > Chris Jackson wrote: > > > I've been hacking around with piano pedalling, to try to implement > > bracketed pedals, and my patch is now ready to be tested. > > And a bug: The horisontal line is too long - by a factor 72/72.27 I > gu

[chris@fluffhouse.org.uk: Re: Piano pedalling patch]

2002-03-12 Thread Chris Jackson
On Tue, Mar 12, 2002 at 12:01:31AM +0100, Rune Zedeler wrote: > Some comments, though: > - when doing a up-down-tick, the two diagonal lines line up to each > other instead of overlapping. The result is > > X X > XX > XXX XXX >XXXXXX > X X >

Piano pedalling patch

2002-03-12 Thread Han-Wen Nienhuys
[EMAIL PROTECTED] writes: > I've been hacking around with piano pedalling, to try to implement > bracketed pedals, and my patch is now ready to be tested. > > the dynamic engraver. The actual dimensions of the brackets are set > using a new function in text-spanner.cc. Please let me know how

Re: Piano pedalling patch

2002-03-11 Thread Rune Zedeler
Chris Jackson wrote: > I've been hacking around with piano pedalling, to try to implement > bracketed pedals, and my patch is now ready to be tested. And a bug: The horisontal line is too long - by a factor 72/72.27 I guess (problem with points vs. bigpoints) \version "1.5.38.chj1" \score{ \no

Re: Piano pedalling patch

2002-03-11 Thread Rune Zedeler
Chris Jackson wrote: > I've been hacking around with piano pedalling, to try to implement > bracketed pedals, and my patch is now ready to be tested. They look really good Some comments, though: - when doing a up-down-tick, the two diagonal lines line up to each other instead of overlapping.

Re: Piano pedalling patch

2002-03-11 Thread Rune Zedeler
Tim Nowaczyk wrote: > I believe it's gziped. I downloaded the file to lilypond-1.5.38.chj1.diff.gz and >`gunzip`ed it and it looks fine Silly me. Sorry. -Rune ___ Lilypond-devel mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo

Re: Piano pedalling patch

2002-03-11 Thread Tim Nowaczyk
On Mon, Mar 11, 2002 at 11:12:05PM +0100, Rune Zedeler wrote: >Chris Jackson wrote: > >> bracketed pedals, and my patch is now ready to be tested. > >I couldn't unpack the patch. The result looks like this: > ><°ø?<lilypond-1.5.38.chj1.diffÄÂû Õ1~S¼ßóæaàsýî~w÷°·aùm×?þ»o<Ø?0.

Re: Piano pedalling patch

2002-03-11 Thread Rune Zedeler
Chris Jackson wrote: > bracketed pedals, and my patch is now ready to be tested. I couldn't unpack the patch. The result looks like this: <°ø?<lilypond-1.5.38.chj1.diffÄhttp://mail.gnu.org/mailman/listinfo/lilypond-devel

Piano pedalling patch

2002-03-11 Thread Chris Jackson
I've been hacking around with piano pedalling, to try to implement bracketed pedals, and my patch is now ready to be tested. Firstly, all pedal symbols (Ped. * texts, and brackets) are now horizontally aligned, using a line spanner. I think this looks much neater than having them attached to n