2011/9/13 :
> On 2011/09/12 21:35:03, janek wrote:
>>
>> can you tell me what needs work in this patch? I've read Mike's
>
> comments, but i
>>
>> don't understand what should be done.
>
> This patch contains many copy/paste from the arpeggio engraver. We
> obviously need a new grob, since the br
On 2011/09/12 21:35:03, janek wrote:
can you tell me what needs work in this patch? I've read Mike's
comments, but i
don't understand what should be done.
This patch contains many copy/paste from the arpeggio engraver. We
obviously need a new grob, since the braces need some special grob
par
Hi Bertrand,
can you tell me what needs work in this patch? I've read Mike's
comments, but i don't understand what should be done. I have a strong
feeling that it should be patch-review.
It's a nice work and i'd like to see it implemented.
cheers,
Janek
http://codereview.appspot.com/4807053/
Most of my comments below resemble each other, but up here I want to
suggest that if you go down the road of generalizing the arpeggio grob,
the places you'd have to do work are in the rhythmic column engraver and
in the several NoteColumn functions that look for an arpeggio. Instead,
this would
That wasn't working 'cause I forgot to add some files to git...
This is now fixed.
Bertrand
http://codereview.appspot.com/4807053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
