Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-11 Thread Graham Percival
On Fri, Nov 11, 2011 at 06:15:04PM +0100, David Kastrup wrote: > Graham Percival writes: > > > (the below is NOT directed at David, who is an absolutely > > fantastic developer) ... > this misbegotten hobby horse not belonging in Lilypond. I agree. > Mind you, it is not like I was enthused at

Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-11 Thread David Kastrup
Graham Percival writes: > On Fri, Nov 11, 2011 at 02:42:55PM +0100, Jan Nieuwenhuizen wrote: >> David Kastrup writes: >> >> > The patch in its current state does not affect a working test suite, and >> > it lets "make check" finish with slightly less readable output when >> > cxxabi.h breaks g++

Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-11 Thread Graham Percival
On Fri, Nov 11, 2011 at 02:42:55PM +0100, Jan Nieuwenhuizen wrote: > David Kastrup writes: > > > The patch in its current state does not affect a working test suite, and > > it lets "make check" finish with slightly less readable output when > > cxxabi.h breaks g++ 4.6. So it is _strictly_ an imp

Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-11 Thread Jan Nieuwenhuizen
David Kastrup writes: > Issue 1875. Ah, that's the bit I missed. Just an artifact of our non-integrated SCM/Bug-tracker/Patch tracker. > The patch in its current state does not affect a working test suite, and > it lets "make check" finish with slightly less readable output when > cxxabi.h brea

Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-11 Thread David Kastrup
Reinhold Kainhofer writes: > On 2011-11-11 09:31, d...@gnu.org wrote: >>> Remember that yaffut is a cross platform test suite, are things >>> like c++filt available for MSVC, for example? >> >> Huh? What concern are the platforms yaffut runs on? Don't tell me that >> Lilypond is one of its main

Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-11 Thread Reinhold Kainhofer
On 2011-11-11 09:31, d...@gnu.org wrote: Remember that yaffut is a cross platform test suite, are things like c++filt available for MSVC, for example? Huh? What concern are the platforms yaffut runs on? Don't tell me that Lilypond is one of its main distribution points. If it is, so much the

Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-11 Thread dak
Reviewers: J_lowe, jan.nieuwenhuizen, Message: On 2011/11/11 06:48:28, jan.nieuwenhuizen wrote: On 2011/11/10 20:07:34, J_lowe wrote: > Passes make and no reg test diffs +// Modified to omit demangling, filter through c++filt -t instead Please, do not add changelogs to source files; we hav

Re: Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-10 Thread jan . nieuwenhuizen
On 2011/11/10 20:07:34, J_lowe wrote: Passes make and no reg test diffs +// Modified to omit demangling, filter through c++filt -t instead Please, do not add changelogs to source files; we have Git for that. Also, what I miss in this description is *why* you made the change, I can see that you

Keep yaffut from attempting to demangle. (issue 5375051)

2011-11-10 Thread pkx166h
Passes make and no reg test diffs james http://codereview.appspot.com/5375051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel