http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode855
lily/stem.cc:855: if (attach && !scm_is_eq (style, ly_symbol2scm
("mensural"))
On 2011/10/07 09:47:24, Bertrand Bordage wrote:
stems
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode855
lily/stem.cc:855: if (attach && !scm_is_eq (style, ly_symbol2scm
("mensural"))
I meant: the stem is aligned to the right of the attach
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode855
lily/stem.cc:855: if (attach && !scm_is_eq (style, ly_symbol2scm
("mensural"))
On 2011/10/03 08:52:27, Bertrand Bordage wrote:
By def
Thanks Keith, I'll quickly fix that in a new issue.
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4639065/diff/42001/lily/stem.cc#newcode853
lily/stem.cc:853: extract_grob_set (me, "note-heads", heads);
... OK.
http://cod
http://codereview.appspot.com/4639065/diff/42001/lily/note-head.cc
File lily/note-head.cc (right):
http://codereview.appspot.com/4639065/diff/42001/lily/note-head.cc#newcode49
lily/note-head.cc:49: }
Yuck. The decision tree is complex enough that two tests of font
capability seem to be required
Bertrand, It looks like the additional font lookups are significantly
slowing down the Windows build,
http://code.google.com/p/lilypond/issues/detail?id=1926
Mabye it is the multiple calls to find_by_name(). It seems the logic
that chooses the glyph could be simpler, and more efficient.
... or b
Pushed as:
0dcc93c0a5a97d048db2f7631966f41ae0059ab5
and
0e31cd90e44673eca7ac59705ce4bed33dd8e80e
Thank you all for this review!
Bertrand
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.or
> Passes make and new reg test differences (look ok) attached here
in all four .png's I can see empty rectangles instead of longae.
p
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Passes make and new reg test differences (look ok) attached here
http://code.google.com/p/lilypond/issues/detail?id=1839#c17
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/li
hi Bertrand,
> Ok Pal, I removed the left-stemmed longa.
thanks, mensural-ligatures.ly is now ok.
p
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Ok Pal, I removed the left-stemmed longa.
I don't know where you could put these rules.
Maybe we should start a new doc part that references the established
engraving rules?
Bertrand
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing li
hi Bertrand,
sorry, I messed up my build last time, and the mensural-ligatures.ly
regtest is still bad. look at the first row: the last LB and last SS
are indistinguishable. 2.14 is right.
all: what would be the good place for the ligature description in the
second attachment of
http://lists.
>> > * Use the left-stemmed longa in ligatures.
>
>> exactly what is this last one?
>
> When note_shape is MLP_LONGA and the direction of the stem is UP, then
> the left-stemmed longa is used.
oh, indeed. I must have messed up my build, now I see it.
unfortunately this is bad.
look at the first r
New patch set (inspired by Janek's ideas).
On 2011/09/14 21:05:28, benko.pal wrote:
> * Use the left-stemmed longa in ligatures.
exactly what is this last one?
When note_shape is MLP_LONGA and the direction of the stem is UP, then
the left-stemmed longa is used.
I know, this should be Mensu
hi Bertrand,
What has been done for Petrucci/mensural/neomensural:
* Stems centered around the attachment point.
* Attachment point lowered.
* Brevis/longa/maxima pointing downward.
* Use the left-stemmed longa in ligatures.
exactly what is this last one?
p
http://codereview.appspot.com/4639
2011/9/14 Francisco Vila :
>> have you seen the facsimiles in the message
>> http://lists.gnu.org/archive/html/lilypond-devel/2010-12/msg00398.html
>> ?
>
> The attached file in that message must be a joke!
aargh, my bad. as I look at it now,
it's actually a gzip-compressed tar archive,
you can
2011/9/14 Benkő Pál :
> hi all,
>
> the patch is ok from my point of view. a minor question: the only change
> in mensural-ligatures.ly is the version bump - is that needed?
>
>>> Do you know what neomensural and mensural styles are inspired of?
>
> I believe it uses the shapes of noteheads found
hi all,
the patch is ok from my point of view. a minor question: the only change
in mensural-ligatures.ly is the version bump - is that needed?
>> Do you know what neomensural and mensural styles are inspired of?
I believe it uses the shapes of noteheads found in manuscript,
but scales them to
2011/9/13 :
> http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly#newcode1063
>>
>> ly/engraver-init.ly:1063: \override Stem #'thickness = #2
>> I'd make them just a bit thinner, perhaps 1.8. I think that 2 might
>> get too thick with smaller font-size (as font-size decreases,
>>
Thought I'd commented on this one but see
http://code.google.com/p/lilypond/issues/detail?id=1839#c13
There are the reg test differences.
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.
Thought I'd commented on this one but see
http://code.google.com/p/lilypond/issues/detail?id=1839#c13
There are the reg test differences.
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.
On 2011/09/12 22:37:05, janek wrote:
i've looked at latest screenshot attached to tracker issue and... wow!
It looks
really great!
Thanks a lot :)
http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly#newcode1063
ly/engraver-init.ly:1063: \override Stem #'thickness = #2
I'd
On 2011/09/12 22:37:05, janek wrote:
i've looked at latest screenshot attached to tracker issue and... wow!
It looks
really great!
Thanks a lot :)
http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly#newcode1063
ly/engraver-init.ly:1063: \override Stem #'thickness = #2
I'd
hi Bertrand,
> I am a total ligature newbie. But I see some stemmed notes in
> input/regression/mensural-ligatures.ly .
initial and middle stems are drawn separately (see later if-blocks
of MLP_STEM and add-join), final ones are part of a longa notehead.
> Of course, I agree that there's a bug.
Hi,
i've looked at latest screenshot attached to tracker issue and... wow!
It looks really great!
I have only small suggestions about some sizes.
You've put a lot of work into this!
thanks,
Janek
http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly
File ly/engraver-init.ly (rig
Thanks for your reviews!
On 2011/09/12 19:16:26, benko.pal wrote:
http://codereview.appspot.com/4639065/diff/13002/lily/mensural-ligature.cc#newcode147
lily/mensural-ligature.cc:147: Direction stem_dir = stem ?
get_grob_direction
(stem) : CENTER;
this is unneeded: there are no stemmed notes w
there are problems: the patch as is fails the mensural-ligatures
regtest. see below.
p
http://codereview.appspot.com/4639065/diff/13002/lily/mensural-ligature.cc
File lily/mensural-ligature.cc (right):
http://codereview.appspot.com/4639065/diff/13002/lily/mensural-ligature.cc#newcode147
lily/
LGTM
Werner
http://codereview.appspot.com/4639065/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
Hi everyone,
This patch is finally ready for review!
What has been done for Petrucci/mensural/neomensural:
* Stems centered around the attachment point.
* Attachment point lowered.
* Brevis/longa/maxima pointing downward.
* Use the left-stemmed longa in ligatures.
* A larg
29 matches
Mail list logo
