Hi, i've looked at latest screenshot attached to tracker issue and... wow! It looks really great! I have only small suggestions about some sizes. You've put a lot of work into this!
thanks, Janek http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/4639065/diff/13002/ly/engraver-init.ly#newcode1063 ly/engraver-init.ly:1063: \override Stem #'thickness = #2 I'd make them just a bit thinner, perhaps 1.8. I think that 2 might get too thick with smaller font-size (as font-size decreases, the relative thickness increases). http://codereview.appspot.com/4639065/diff/13002/mf/parmesan-noteheads.mf File mf/parmesan-noteheads.mf (right): http://codereview.appspot.com/4639065/diff/13002/mf/parmesan-noteheads.mf#newcode272 mf/parmesan-noteheads.mf:272: nm_red_holeheight := 2.5 linethickness; I'd make this 3 linethickness. http://codereview.appspot.com/4639065/diff/13002/mf/parmesan-noteheads.mf#newcode329 mf/parmesan-noteheads.mf:329: nm_width := staff_space#; if i'm not mistaken and these are the height and width of half and quarter noteheads, i'd make them very slightly bigger - something like nm_height := 1.1 noteheight#; 329 nm_width := 1.05 staff_space#; http://codereview.appspot.com/4639065/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
