Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-21 Thread Han-Wen Nienhuys
Thanks, I'll sit tight and wait for the email. On Tue, May 20, 2014 at 10:37 PM, James wrote: > On 20/05/14 20:58, David Kastrup wrote: >> Han-Wen Nienhuys writes: >> >>> what's the procedure for pushing this after the LGTM? Can I just push >>> the commit onto master? >>> >>> On Sun, May 18, 201

Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-20 Thread James
On 20/05/14 20:58, David Kastrup wrote: > Han-Wen Nienhuys writes: > >> what's the procedure for pushing this after the LGTM? Can I just push >> the commit onto master? >> >> On Sun, May 18, 2014 at 6:38 PM, wrote: >>> LGTM now, thanks. >>> >>> https://codereview.appspot.com/93430043/ > LGTM is

Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-20 Thread David Kastrup
Han-Wen Nienhuys writes: > what's the procedure for pushing this after the LGTM? Can I just push > the commit onto master? > > On Sun, May 18, 2014 at 6:38 PM, wrote: >> LGTM now, thanks. >> >> https://codereview.appspot.com/93430043/ LGTM is just a thumbs-up from one reviewer. If the review

Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-20 Thread Han-Wen Nienhuys
what's the procedure for pushing this after the LGTM? Can I just push the commit onto master? On Sun, May 18, 2014 at 6:38 PM, wrote: > LGTM now, thanks. > > https://codereview.appspot.com/93430043/ -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen __

Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-18 Thread lemzwerg
LGTM now, thanks. https://codereview.appspot.com/93430043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-18 Thread hanwenn
On 2014/05/17 15:13:20, lemzwerg wrote: https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile#newcode119 mf/GNUmakefile:119: true Does this really work? I've never seen a make rule like

Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-17 Thread lemzwerg
https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile#newcode119 mf/GNUmakefile:119: true Does this really work? I've never seen a make rule like that, and my gut feeling says that it coul

Re: Generate a .pe script for one design size at a time. (issue 93430043)

2014-05-17 Thread hanwenn
please review. https://codereview.appspot.com/93430043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel