Han-Wen Nienhuys <hanw...@gmail.com> writes: > what's the procedure for pushing this after the LGTM? Can I just push > the commit onto master? > > On Sun, May 18, 2014 at 6:38 PM, <lemzw...@googlemail.com> wrote: >> LGTM now, thanks. >> >> https://codereview.appspot.com/93430043/
LGTM is just a thumbs-up from one reviewer. If the review looks favorably, the patch will be promoted to Patch-push status by the Patch meister eventually. That's when one can rebase and push the patch to staging (never! master) and mark the issue as fixed. Automated procedures will do a complete check of staging regularly (every few hours) and push it to master when it passes all of a number of checks. -- David Kastrup _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel