This has now been pushed
ly: Updates to predefined Ukulele fretboards master staging
author Davide Bonetti
Fri, 18 Jan 2019 11:34:37 + (11:34 +)
committer James Lowe
Fri, 18 Jan 2019 11:36:47 + (11:36 +)
commit
Patch on countdown for January 17th
https://codereview.appspot.com/367880043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Passes make, make check and a full make doc.
Please review
https://codereview.appspot.com/367880043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hello Davide,
On 06/01/2019 5:02 pm, Davide Bonetti wrote:
Hello everyone.
I worked on ukulele fretboards, fixing errors and adding new
predefined fretboards.
Here the result of my work.
Regards
Davide
Thank you for your time on this.
I will submit a patch on your behalf and it will go
Hello everyone.
I worked on ukulele fretboards, fixing errors and adding new predefined
fretboards.
Here the result of my work.
Regards
Davide
---
Questa e-mail è stata controllata per individuare virus con Avast antivirus.
https://www.avast.com/antivirus
\version "2.18.0"
\include &
d...@faithful.be writes:
> On 2015-10-31 12:49, pls wrote:
>> d...@faithful.be writes:
>>
>>> On 2015-10-31 11:39, pls wrote:
>>>> Thomas Morley writes:
>>>>> Personally, I don't like any of those and lean towards excluding
>>>&
On 2015-10-31 12:49, pls wrote:
d...@faithful.be writes:
On 2015-10-31 11:39, pls wrote:
Thomas Morley writes:
Personally, I don't like any of those and lean towards excluding
quarter-tones from FretBoards at all and let output the warning
about
"Missing fret for pitch ~a on str
Thomas Morley writes:
> Personally, I don't like any of those and lean towards excluding
> quarter-tones from FretBoards at all and let output the warning about
> "Missing fret for pitch ~a on string ~a" as before.
> Letting only TabStaff display quarter-tones.
I&
Hi all,
I'm working on "quarter tones in tablature"
https://sourceforge.net/p/testlilyissues/issues/4643/
I've locally some code which does it by modifying `determine-frets'
from translation-functions.scm
Though automatic fret-diagrams in FretBoards rely on it as well.
Reviewers: ,
Description:
Fretboards: markup strings in dot positions
Issue 4120
Fixes disappeared strings, restores the behaviour before the fix
for Issue 2752
Does not scale those strings, though, in order to fix the regression
first
and do other feature requests for issue 4120 in a follow
Am 04.07.2014 09:46, schrieb Marc Hohl:
Hi list,
sorry, wrong list ... I re-posted this question on -user, sorry for the
noise.
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi list,
in the following example, I want to align the FretBoards to the
bar lines. Now they are centered over the first beat in each measure.
TIA,
Marc
---
\version "2.19.0"
\paper {
indent = 0
ragged-right = ##f
}
frets = {
< d'\3 g'\2 b'\1 >1 | <
On Mon, Apr 25, 2011 at 04:43:45PM +0200, Marc Hohl wrote:
> Am 25.04.2011 13:24, schrieb percival.music...@gmail.com:
> >Marc: can you send me the patch so that I can push it?
> >
> >http://codereview.appspot.com/4370054/
> Here it is.
thanks, pushed.
Cheers,
- Graham
__
10:42:11 +0200
Subject: [PATCH] Add predefined mandolin fretboards to lilypond.
---
.../display-predefined-mandolin-fretboards.ly | 74 ++
Documentation/notation/fretted-strings.itely | 24 +-
Documentation/notation/notation-appendices.itely |4 +
ly/predefined-mando
Marc: can you send me the patch so that I can push it?
http://codereview.appspot.com/4370054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM.
If I had done it I would have defined chordShapes for the common shapes
and moved them up and down the fretboard. But that's not necessary; I'd
totally support this addition.
Sorry I'm so slow on this -- I reviewed it a while ago and forgot to
comment.
Carl
http://codereview.appspot.co
I can't see anything wrong, but I'm away from my desktop so I haven't
tried a regtest comparison. I can't see how it would break anything,
though.
http://codereview.appspot.com/4370054/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lis
Am 11.04.2011 10:34, schrieb Marc Hohl:
[...]
So please have a look at
http://codereview.appspot.com/4370054/
LGTM, anyone? ;-)
Marc
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Am 11.04.2011 06:43, schrieb carl.d.soren...@gmail.com:
Reviewers: ,
Message:
Marc Hohl has prepared a patch for mandolin predefined fretboards.
The patch looks good to me.
Please review.
Thanks,
Carl
http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted
Reviewers: ,
Message:
Marc Hohl has prepared a patch for mandolin predefined fretboards.
The patch looks good to me.
Please review.
Thanks,
Carl
http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely
On 1/30/10 11:44 AM, "n.putt...@gmail.com" wrote:
> Hi Carl,
>
> I've just tested this, and it breaks two regtests:
>
> 1) dead-notes.ly
>
> The \deadNote command inside a chord is ignored (i.e., the tabs appear
> as numbers rather than crosses). Replacing \deadNote with \tweak also
> fail
Hi Carl,
I've just tested this, and it breaks two regtests:
1) dead-notes.ly
The \deadNote command inside a chord is ignored (i.e., the tabs appear
as numbers rather than crosses). Replacing \deadNote with \tweak also
fails.
2) tablature-harmonic.ly
The harmonic brackets have disappeared. W
The patch set now seems to be complete. I've responded to Neil's
comments, and regression tests all pass.
Please review.
Thanks,
Carl
http://codereview.appspot.com/186268/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.g
I've found a bug in this code that showed up with the latest changes in
the regression tests.
I'll have a new patch set later; don't spend any time on this one right
now.
THanks,
Carl
http://codereview.appspot.com/186268/show
___
lilypond-devel
I've found a bug in this code that showed up with the latest changes in
the regression tests.
I'll have a new patch set later; don't spend any time on this one right
now.
THanks,
Carl
http://codereview.appspot.com/186268/show
___
lilypond-devel
OK, so I added the optional default to ly:context-property, and fixed
the indentation.
make check works.
I think it's good to go now.
http://codereview.appspot.com/186268/diff/1/7
File scm/translation-functions.scm (right):
http://codereview.appspot.com/186268/diff/1/7#newcode236
scm/transla
2010/1/26 Carl Sorensen :
> Should this be a separate patch, probably applied before the current patch?
Definitely a separate patch, though I think it can wait until this
patch has been sorted.
> I tried scm_call_5, and got a compile error. Then I looked at the guile
> page, and no scm_call_5,
On 1/25/10 6:59 PM, "n.putt...@gmail.com" wrote:
> On 2010/01/24 01:36:35, Carl wrote:
>
>> I think I've dealt with everything, but there is still an open
> question on
>> ly:context-property. As far as I can see, there is not currently a
> means of
>> putting a default in the ly:context-pro
On 2010/01/24 01:36:35, Carl wrote:
I think I've dealt with everything, but there is still an open
question on
ly:context-property. As far as I can see, there is not currently a
means of
putting a default in the ly:context-property call. I can see that it
would be
good to have that. I'm
newcode432
scm/translation-functions.scm:432: (format "~a" fret-number)))
On 2010/01/23 16:42:33, Neil Puttock wrote:
indent
Done.
http://codereview.appspot.com/186268/diff/1/7#newcode442
scm/translation-functions.scm:442: (number->string (cond
On 2010/01/23 16:42:33, Neil Puttock wro
http://codereview.appspot.com/186268/diff/1/2
File lily/fretboard-engraver.cc (left):
http://codereview.appspot.com/186268/diff/1/2#oldcode100
lily/fretboard-engraver.cc:100: SCM changes =
get_property("chordChanges");
get_property (
http://codereview.appspot.com/186268/diff/1/2#oldcode101
lily
Hi Carl,
On 22 January 2010 03:14, Carl Sorensen wrote:
> Please review the patch at
>
> http://codereview.appspot.com/186268/show
I'll post some comments on Rietveld soon.
Cheers,
Neil
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://
In response to a request from Patrick Schmidt on the tablatures list, I
became aware of the fact that we have two separate methods of finding
strings and frets given notes -- one for the tab-note-heads-engraver and one
for the fretboards-engraver.
This didn't seem to me to be a very
t as I think more about
it, the fret diagram depends on the capo setting, so it should be part of
the diagram definition.
It's probably the right thing to do to add a verbose interface to
storePredefinedFretBoard, so things like scales can be added if desired,
with the idea of moving all fret dia
34 matches
Mail list logo
