On 2009/04/17 19:25:31, joeneeman wrote:
http://codereview.appspot.com/11052/diff/3409/2410
File scm/music-functions.scm (right):
http://codereview.appspot.com/11052/diff/3409/2410#newcode1047
Line 1047: ((and (equal? ignore-octave #f)
I think eq? is more appropriate here
Done.
http://code
http://codereview.appspot.com/11052/diff/3409/2410
File scm/music-functions.scm (right):
http://codereview.appspot.com/11052/diff/3409/2410#newcode1047
Line 1047: ((and (equal? ignore-octave #f)
I think eq? is more appropriate here
http://codereview.appspot.com/11052/diff/3409/2410#newcode1048
On 2009/03/24 23:06:42, joeneeman wrote:
lgtm, except for the description "move check_pitch_against_signature
() to SCM,"
since ly:check-pitch-against-signature is still implemented in C++.
OK, I've junked the C++ code completely and reimplemented
check-pitch-against-signature in SCM.
http:/
exporting check_pitch_against_signature as
a Scheme function.
I guess it would be better to rework the whole thing in Scheme.
Description:
Fix key signatures with accidentals in specific octave.
- when testing whether a pitch matches the key signature, try using
keySignature if no match is found in localKeySignatur
lgtm, except for the description "move check_pitch_against_signature ()
to SCM," since ly:check-pitch-against-signature is still implemented in
C++.
http://codereview.appspot.com/11052
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://list
