Reviewers: joeneeman, Message: On 2009/03/24 23:06:42, joeneeman wrote:
lgtm, except for the description "move check_pitch_against_signature
() to SCM,"
since ly:check-pitch-against-signature is still implemented in C++.
Erk. I misinterpreted that to mean exporting check_pitch_against_signature as a Scheme function. I guess it would be better to rework the whole thing in Scheme. Description: Fix key signatures with accidentals in specific octave. - when testing whether a pitch matches the key signature, try using keySignature if no match is found in localKeySignature. - move check_pitch_against_signature () to SCM, passing context instead of localKeySignature - remove ly:find-accidentals-simple Please review this at http://codereview.appspot.com/11052 Affected files: A input/regression/key-signature-scordatura-persist.ly M lily/accidental-engraver.cc M scm/music-functions.scm _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
