On 2009-09-06, Michael Käppler wrote:
> Hi Patrick,
> I recently noticed that /input/regression/bookparts.ly gives the
> warning "Missing stencil expression: utf-8-string" what I think is
> related to your patchset.
> Could you please have a look at this?
This should be fixed in git.
Thanks,
Patr
On 2009-09-06, Patrick McCarty wrote:
> On 2009-09-06, Michael Käppler wrote:
> > Hi Patrick,
> > I recently noticed that /input/regression/bookparts.ly gives the
> > warning "Missing stencil expression: utf-8-string" what I think is
> > related to your patchset.
> > Could you please have a look at
On 2009-09-06, Michael Käppler wrote:
> Hi Patrick,
> I recently noticed that /input/regression/bookparts.ly gives the
> warning "Missing stencil expression: utf-8-string" what I think is
> related to your patchset.
> Could you please have a look at this?
Thanks, I will look at this shortly. I ha
Hi Patrick,
I recently noticed that /input/regression/bookparts.ly gives the warning
"Missing stencil expression: utf-8-string" what I think is related to
your patchset.
Could you please have a look at this?
Thanks,
Michael
___
lilypond-devel maili
On Thu, Jul 16, 2009 at 05:42:25AM +, joenee...@gmail.com wrote:
> lgtm
>
> http://codereview.appspot.com/83046
Thanks, Joe. It's applied.
-Patrick
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilyp
lgtm
http://codereview.appspot.com/83046
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On Tue, Jul 7, 2009 at 2:44 PM, Patrick McCarty wrote:
> Hello,
>
> The third revision of my patch set (Patch Set 5) is on Rietveld:
>
> http://codereview.appspot.com/83046/show
>
> The change from Patch Set 4 is the generalization of
> -dwarning-as-error. Note that this is a series of 8 commits t
Hello,
The third revision of my patch set (Patch Set 5) is on Rietveld:
http://codereview.appspot.com/83046/show
The change from Patch Set 4 is the generalization of
-dwarning-as-error. Note that this is a series of 8 commits that
contain more in-depth commit summaries. They can be found here:
On Tue, 2009-07-07 at 01:24 -0700, Patrick McCarty wrote:
> On Tue, Jul 07, 2009 at 08:16:45AM +0200, Werner LEMBERG wrote:
> >
> > > The new option, -dwarning-as-error, does *not* turn every warning into
> > > an error. It only turns specific warnings (that don't exist without
> > > this patch)
On Tue, Jul 07, 2009 at 08:16:45AM +0200, Werner LEMBERG wrote:
>
> > The new option, -dwarning-as-error, does *not* turn every warning into
> > an error. It only turns specific warnings (that don't exist without
> > this patch) into errors.
>
> Then the name is indeed too generic and should be
> The new option, -dwarning-as-error, does *not* turn every warning into
> an error. It only turns specific warnings (that don't exist without
> this patch) into errors.
Then the name is indeed too generic and should be temporarily renamed
to something more specific until the code has been impro
On Mon, Jul 06, 2009 at 03:37:06PM -0700, Patrick McCarty wrote:
> On Mon, Jul 06, 2009 at 03:08:50PM -0700, Graham Percival wrote:
> > I don't see a huge urgency for this patch, so I would rather wait
> > until b) was non-existent. I totally agree that we should split
> > a) and c), though.
>
>
On Mon, Jul 06, 2009 at 03:37:06PM -0700, Patrick McCarty wrote:
>
> But, since the regression test suite only exercises the PostScript
> backend, which doesn't currently have any missing any *defined*
> stencil expressions, we won't be seeing any failures right now.
I should emphasize the *right
On Mon, Jul 06, 2009 at 03:08:50PM -0700, Graham Percival wrote:
> On Mon, Jul 06, 2009 at 07:09:11AM +0200, Werner LEMBERG wrote:
> > > and I'm not certain that we have enough Frogs to eat all the issues
> > > that would be added if we went this route.
> >
> > Perhaps it makes sense to classify r
On Mon, Jul 06, 2009 at 07:09:11AM +0200, Werner LEMBERG wrote:
> > and I'm not certain that we have enough Frogs to eat all the issues
> > that would be added if we went this route.
>
> Perhaps it makes sense to classify regression tests like this:
>
> a) intentionally emit warnings and errors
On Mon, Jul 06, 2009 at 09:37:19AM +0200, John Mandereau wrote:
> Le dimanche 05 juillet 2009 à 18:01 -0700, Patrick McCarty a écrit :
> > On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> > > -dwarning-as-error
> > > looks fine to me.
> >
> > I think Han-Wen suggested to enable t
Le dimanche 05 juillet 2009 à 18:01 -0700, Patrick McCarty a écrit :
> On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> > -dwarning-as-error
> > looks fine to me.
>
> I think Han-Wen suggested to enable this option for the entire
> regression test suite, so adding this option to
>> In other words, some makefile hacking is needed, which I would
>> probably need to delegate.
I agree.
> I doubt that the regtests compile without warnings,
Correct. Some of them are even expected to emit warning or error messages.
> and I'm not certain that we have enough Frogs to eat all t
On Sun, Jul 05, 2009 at 08:22:02PM -0700, Graham Percival wrote:
> On Sun, Jul 05, 2009 at 06:01:21PM -0700, Patrick McCarty wrote:
> > On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> > >
> > > -dwarning-as-error
> > > looks fine to me.
> >
> > Okay. On second thought, it look
On Sun, Jul 05, 2009 at 06:01:21PM -0700, Patrick McCarty wrote:
> On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> > On Sun, Jul 05, 2009 at 02:29:44PM -0700, Patrick McCarty wrote:
> > > 1.) I used Jan's suggestion for -d option name, but I'm not sure this
> > > is the best name
On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> On Sun, Jul 05, 2009 at 02:29:44PM -0700, Patrick McCarty wrote:
> > 1.) I used Jan's suggestion for -d option name, but I'm not sure this
> > is the best name. What should the option be called?
>
> -dwarning-as-error
> looks fine
On Sun, Jul 05, 2009 at 02:29:44PM -0700, Patrick McCarty wrote:
> 1.) I used Jan's suggestion for -d option name, but I'm not sure this
> is the best name. What should the option be called?
-dwarning-as-error
looks fine to me.
> 3.) I don't know how to enable the -d option by default for regres
Hello,
I have updated my patchset on Rietveld:
http://codereview.appspot.com/83046/show
Thank you all for your reviews. I have a few questions/concerns:
1.) I used Jan's suggestion for -d option name, but I'm not sure this
is the best name. What should the option be called?
2.) Is backend-li
On wo, 2009-07-01 at 12:37 -0700, Patrick McCarty wrote:
> > Does anyone have comments for this patch?
> The "catch all" routine is written, but disabled due to the (if #f
> ...).
Why not, instead of a programmer's switch between crash/warning,
do something like see attached?
Greetings,
Jan.
http://codereview.appspot.com/83046/diff/1/3
File scm/output-ps.scm (right):
http://codereview.appspot.com/83046/diff/1/3#newcode58
Line 58: (ly:all-output-backend-commands)
Perhaps this could be a macro (so that you don't need to c&p for every
backend). And if you add a -d option like Han-W
Can this be made so that the regtests and similar crash when an unknown
stencil expression is executed? Perhaps a -d option could help here.
http://codereview.appspot.com/83046/diff/1/5
File scm/output-svg.scm (right):
http://codereview.appspot.com/83046/diff/1/5#newcode284
Line 284: (if (< 0
On Fri, Jun 26, 2009 at 1:46 PM, Patrick McCarty wrote:
> On Sat, Jun 20, 2009 at 11:55 AM, Patrick McCarty wrote:
>> Hello,
>>
>> I have uploaded a patch to Rietveld:
>>
>> http://codereview.appspot.com/83046/show
>
> Does anyone have comments for this patch?
I will provide some more background i
On Sat, Jun 20, 2009 at 11:55 AM, Patrick McCarty wrote:
> Hello,
>
> I have uploaded a patch to Rietveld:
>
> http://codereview.appspot.com/83046/show
Does anyone have comments for this patch?
Here are some more thoughts I have about this:
***
The problematic function that causes the crash is
Hello,
I have uploaded a patch to Rietveld:
http://codereview.appspot.com/83046/show
***
The motivation for the patch is this report:
http://lists.gnu.org/archive/html/lilypond-user/2009-02/msg00603.html
However, since dashed slurs no longer use the "dashed-slur" routine,
this particular cras
29 matches
Mail list logo
