On 2011/02/02 23:55:59, Neil Puttock wrote:
LGTM.
Just needs rebasing (I assume you don't want to delete
tablature-dot-placement.ly)
Done
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists
LGTM.
Just needs rebasing (I assume you don't want to delete
tablature-dot-placement.ly)
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM, and passes regtests.
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/01/23 19:11:46, c_sorensen_byu.edu wrote:
I could make a separate patch that moves it, and then compare against
that patch, if you think it's worth it
Thanks, but don't worry about it. I'll try that myself once I've
applied the patch.
Cheers,
Neil
http://codereview.appspot.com/40
On Jan 23, 2011, at 10:54 AM, "n.putt...@gmail.com"
wrote:
> Hi Carl,
>
> Is moving `determine-frets-and-strings' required for the patch to
> work?
> It makes reviewing the changes difficult.
>
If I don't move it, I will need to add an argument for either the
context or the property valu
Hi Carl,
Is moving `determine-frets-and-strings' required for the patch to work?
It makes reviewing the changes difficult.
Cheers,
Neil
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org
Thanks, Marc. Good suggestion.
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm
File scm/translation-functions.scm (right):
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm#newcode394
scm/translation-functions.scm:394: ((eq? handle-negative '
Hi Carl,
LGTM - I don't think that many users will ever
change handleNegativeFrets, but your solution
is encompassing and leaves nothing to be desired ;-)
Regards,
Marc
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm
File scm/translation-functions.scm (right):
http
Reviewers: marc,
Message:
I've posted a patch for fixing issue 1035, by giving the user control
over
what to do with negative fret numbers demanded by an assigned string.
The default behavior is to recalculate the note and put it in the
tablature or fretboard as if it had not had a string assign
