On Jan 23, 2011, at 10:54 AM, "n.putt...@gmail.com"  
<n.putt...@gmail.com> wrote:

> Hi Carl,
>
> Is moving `determine-frets-and-strings' required for the patch to  
> work?
> It makes reviewing the changes difficult.
>

If I don't move it, I will need to add an argument for either the  
context or the property value.  I think it's much cleaner to move  
determine-frets-and-strings inside the scope where context is defined.

It probably should have been there in the first place.

I could make a separate patch that moves it, and then compare against  
that patch, if you think it's worth it

Thanks,

Carl


> http://codereview.appspot.com/4056041/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to