Re: Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

On 2010/06/29 23:58:07, Neil Puttock wrote: Do you think the property name's OK though? I agree with Carl it could be a bit more descriptive, but then there's also the need to keep verbosity to a minimum. Yes, I think the property name is fine. -Patrick http://codereview.appspot.com/93104

Re: Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

On 2010/06/29 23:58:07, Neil Puttock wrote: On 2010/06/18 21:56:10, Patrick McCarty wrote: Sure, I'm happy to emend the description (I think Carl will be happy too. ;) Yep! Do you think the property name's OK though? I agree with Carl it could be a bit more descriptive, but then there'

Re: Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

On 2010/06/18 21:56:10, Patrick McCarty wrote: http://codereview.appspot.com/931041/diff/14001/15007 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/931041/diff/14001/15007#newcode757 scm/define-grob-properties.scm:757: multi-measure rest relative to its left and

Re: Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

Thanks for working on this, Neil. Just one quick comment, and otherwise, LGTM. http://codereview.appspot.com/931041/diff/14001/15007 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/931041/diff/14001/15007#newcode757 scm/define-grob-properties.scm:757: multi-measure r

Re: Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

On 2010/04/19 21:13:14, Neil Puttock wrote: On 2010/04/19 19:37:12, Carl wrote: > Should the name of this property be something like ignore-prefatory-material? Actually, I've had a thought: instead of using booleans, it would probably make more sense (and allow finer control) to use a pai

Re: Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

LGTM. Thanks, Patrick http://codereview.appspot.com/931041/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

Reviewers: carl.d.sorensen_gmail.com, Message: Hi Carl, Thanks for checking this out. On 2010/04/19 19:37:12, Carl wrote: Should the name of this property be something like ignore-prefatory-material? Hmm, possibly; it's certainly less vague. :) Actually, I've had a thought: instead of usin

Fix #915 (faulty full-bar rest positioning with clef). (issue931041)

Thanks, Carl http://codereview.appspot.com/931041/diff/1/9 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/931041/diff/1/9#newcode756 scm/define-grob-properties.scm:756: (spacing-pair ,pair? "A pair of booleans which set the spacing for a Should the name of this pro