- Original Message -
From: "David Kastrup"
To: "Carl Peterson"
Cc: "James" ; "Lilypond Dev" ;
"Phil Holmes"
Sent: Saturday, December 14, 2013 2:27 PM
Subject: Re: Enable manual-specific styling of documentation; issue 3714
(issue
Carl Peterson writes:
> On Sat, Dec 14, 2013 at 1:50 AM, James wrote:
>> On 14/12/13 05:57, Carl Peterson wrote:
>>> I have updated the patch in Rietvald
>>
>>
>> But not the tracker. So the patch will not get tested.
>>
>> Please remember to either use git-cl or change the tracker to patch-new
On Sat, Dec 14, 2013 at 1:50 AM, James wrote:
> On 14/12/13 05:57, Carl Peterson wrote:
>> I have updated the patch in Rietvald
>
>
> But not the tracker. So the patch will not get tested.
>
> Please remember to either use git-cl or change the tracker to patch-new
> whenever you make a change in R
On 14/12/13 05:57, Carl Peterson wrote:
On Fri, Dec 13, 2013 at 10:41 PM, Graham Percival
wrote:
On Fri, Dec 13, 2013 at 10:02:23AM -0500, Carl Peterson wrote:
On Thu, Dec 12, 2013 at 7:36 PM, wrote:
I think that the index sidebar colors are too dark. They dominate the
page, in my opinon.
On Fri, Dec 13, 2013 at 10:41 PM, Graham Percival
wrote:
> On Fri, Dec 13, 2013 at 10:02:23AM -0500, Carl Peterson wrote:
>> On Thu, Dec 12, 2013 at 7:36 PM, wrote:
>> > I think that the index sidebar colors are too dark. They dominate the
>> > page, in my opinon. In the current design, the si
On Fri, Dec 13, 2013 at 10:02:23AM -0500, Carl Peterson wrote:
> On Thu, Dec 12, 2013 at 7:36 PM, wrote:
> > I think that the index sidebar colors are too dark. They dominate the
> > page, in my opinon. In the current design, the sidebar color and the
> > highlight box fill color are the same.
- Original Message -
From: "Carl Sorensen"
To: "Phil Holmes" ; "Carl Peterson"
Cc: "Lilypond Dev"
Sent: Friday, December 13, 2013 3:31 PM
Subject: Re: Enable manual-specific styling of documentation; issue
3714(issue 36480048)
On 12/13/13
On 12/13/13 6:04 AM, "Phil Holmes" wrote:
>Thanks for what you're doing, but please don't put a lot of images on the
>Google Issue tracker. For bizarre reasons only known to themselves, the
>storage available for attachments is _very_ limited. By accident you've
>just
> used about 1/25 of our r
On 12/13/13 8:02 AM, "Carl Peterson" wrote:
>On Thu, Dec 12, 2013 at 7:36 PM, wrote:
>> I think that the index sidebar colors are too dark. They dominate the
>> page, in my opinon. In the current design, the sidebar color and the
>> highlight box fill color are the same. Why not keep it th
On Thu, Dec 12, 2013 at 7:36 PM, wrote:
> I think that the index sidebar colors are too dark. They dominate the
> page, in my opinon. In the current design, the sidebar color and the
> highlight box fill color are the same. Why not keep it that way?
Attaching another option, to address your c
- Original Message -
From: "Carl Peterson"
To: "James"
Cc: "Lilypond Dev"
Sent: Friday, December 13, 2013 2:01 PM
Subject: Re: Enable manual-specific styling of documentation;issue
3714(issue 36480048)
On Fri, Dec 13, 2013 at 8:31 AM, James wrote:
Carl Peterson writes:
> On Fri, Dec 13, 2013 at 8:31 AM, James wrote:
>> On 13/12/13 13:04, Phil Holmes wrote:
>>
>> Thanks for what you're doing, but please don't put a lot of images on the
>> Google Issue tracker. For bizarre reasons only known to themselves, the
>> storage available for atta
On Fri, Dec 13, 2013 at 8:31 AM, James wrote:
> On 13/12/13 13:04, Phil Holmes wrote:
>
> Thanks for what you're doing, but please don't put a lot of images on the
> Google Issue tracker. For bizarre reasons only known to themselves, the
> storage available for attachments is _very_ limited. By
, 2013 10:58 PM
*Subject:* Re: Enable manual-specific styling of documentation;
issue 3714(issue 36480048)
On Thu, Dec 12, 2013 at 1:06 AM, mailto:carlopeter...@gmail.com>> wrote:
Message:
Patch for initial solution to issue 3714, regarding
color-coding of
--
Phil Holmes
- Original Message -
From: Carl Peterson
To: Carl Peterson
Cc: Lilypond Dev
Sent: Thursday, December 12, 2013 10:58 PM
Subject: Re: Enable manual-specific styling of documentation; issue
3714(issue 36480048)
On Thu, Dec 12, 2013 at 1:06 AM, wrote:
Message
On Thu, Dec 12, 2013 at 05:58:33PM -0500, Carl Peterson wrote:
>For those who need a visual of these changes, I've uploaded screenshots to
>the Google Code issue.
>https://code.google.com/p/lilypond/issues/detail?id=3714.
Woah, why are you changing the whole background? It looks a bit
On 2013/12/12 22:50:05, Carl P. wrote:
issue 3714, adjust sidebar colors for legibility and contrast
I think that the index sidebar colors are too dark. They dominate the
page, in my opinon. In the current design, the sidebar color and the
highlight box fill color are the same. Why not keep
On Thu, Dec 12, 2013 at 1:06 AM, wrote:
>
> Message:
> Patch for initial solution to issue 3714, regarding color-coding of
> manuals.
>
> Please review this at https://codereview.appspot.com/36480048/
I have submitted follow-up patches to Rietveld to address comments
regarding the duplicate CSS
On Thu, Dec 12, 2013 at 4:10 AM, wrote:
> LGTM, although it is difficult to visualise
> the effect of the various colours without seeing
> them.
>
> https://codereview.appspot.com/36480048/
>
I'll see what I can do about getting representative screenshots.
___
On Thu, Dec 12, 2013 at 7:49 AM, Carl Peterson wrote:
> On Thu, Dec 12, 2013 at 2:21 AM, wrote:
>
>> LGTM, with one small nit.
>>
>>
>> https://codereview.appspot.com/36480048/diff/1/
>> Documentation/css/lilypond-manuals.css
>> File Documentation/css/lilypond-manuals.css (right):
>>
>> https://c
On Thu, Dec 12, 2013 at 2:21 AM, wrote:
> LGTM, with one small nit.
>
>
> https://codereview.appspot.com/36480048/diff/1/Documentation/css/lilypond-
> manuals.css
> File Documentation/css/lilypond-manuals.css (right):
>
> https://codereview.appspot.com/36480048/diff/1/Documentation/css/lilypond-
LGTM, although it is difficult to visualise
the effect of the various colours without seeing
them.
https://codereview.appspot.com/36480048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Carlo,
On 12/12/13 06:06, carlopeter...@gmail.com wrote:
Reviewers: ,
Message:
Patch for initial solution to issue 3714, regarding color-coding of
manuals. .
Make sure the tracker is set to patch-new else it won't get reviewed
properly (if at all) and certainly won't get tested and th
LGTM, with one small nit.
https://codereview.appspot.com/36480048/diff/1/Documentation/css/lilypond-manuals.css
File Documentation/css/lilypond-manuals.css (right):
https://codereview.appspot.com/36480048/diff/1/Documentation/css/lilypond-manuals.css#newcode456
Documentation/css/lilypond-manual
Reviewers: ,
Message:
Patch for initial solution to issue 3714, regarding color-coding of
manuals.
This patch color codes more-or-less according to David K.'s proposal on
the lilypond-user. Does not currently distinguish between dev and stable
in the styling, but the functionality is there to do
25 matches
Mail list logo
