Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-16 Thread Trevor Daniels
http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhythms.itely#newcode2229 Documentation/notation/rhythms.itely:2229: changed, so that when the time signature is set the desired What about: ... changed, so that the desired beaming is always used for that time signat

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-15 Thread percival . music . ca
LGTM. I prefer not to fuss about @knownissues, so just push it when(ever) you think it's good enough. http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/11001/Docume

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-15 Thread Carl . D . Sorensen
On 2011/02/15 07:15:48, Trevor Daniels wrote: http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely#newcode2211 Documentation/notation/rhythms.itely:2211: To avoid this problem, the time signature can be set in only one I still prefer "should" I don't want to

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-14 Thread tdanielsmusic
LGTM, apart from a couple of niggles http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely#newcode2211 Documentation/notation/rh

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-14 Thread Carl . D . Sorensen
On 2011/02/15 00:27:35, Felipe wrote: http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely#newcode2207 Documentation/notatio

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-14 Thread FelipeG . Assis
http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely#newcode2207 Documentation/notation/rhythms.itely:2207: @code{Score} context

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-14 Thread percival . music . ca
LGTM. http://codereview.appspot.com/4160048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-14 Thread Carl . D . Sorensen
Updated patch set posted for review. THanks, Carl http://codereview.appspot.com/4160048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-12 Thread percival . music . ca
Why isn't this inside @knownissues ? http://codereview.appspot.com/4160048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-12 Thread pkx166h
On 2011/02/12 10:08:57, Trevor Daniels wrote: I'd rather drop the first two examples illustrating the problem. It is stated clearly enough, and bad examples shouldn't appear in the docs. Otherwise it looks OK to me. I'd agree with Trevor's general point, for the NR anyway, I like to try to

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-12 Thread tdanielsmusic
I'd rather drop the first two examples illustrating the problem. It is stated clearly enough, and bad examples shouldn't appear in the docs. Otherwise it looks OK to me. Trevor http://codereview.appspot.com/4160048/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms

Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-11 Thread Carl . D . Sorensen
Reviewers: , Message: Mats identified some unexpected behavior with autobeam settings and time signature setting. http://thread.gmane.org/gmane.comp.gnu.lilypond.bugs/23117 This patch demonstrates the problem, describes the reason, and documents two ways of avoiding the problem. Please review