Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Patrick Schmidt
Am 04.03.2011 um 20:41 schrieb Graham Percival: > On Fri, Mar 04, 2011 at 05:17:39PM +0100, Patrick Schmidt wrote: >> >>> Hmm, it doesn't apply for me. Could you do a git pull -r , and then >>> try making the patch again? >>> >> Sorry for that. Don't know what I'm doing wrong. How about this o

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Graham Percival
On Fri, Mar 04, 2011 at 05:17:39PM +0100, Patrick Schmidt wrote: > > > Hmm, it doesn't apply for me. Could you do a git pull -r , and then > > try making the patch again? > > > Sorry for that. Don't know what I'm doing wrong. How about this one? Thanks, it applied without any problems whatsoeve

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Graham Percival
On Fri, Mar 04, 2011 at 07:43:34PM +0100, Patrick Schmidt wrote: > > Am 04.03.2011 um 19:14 schrieb Trevor Daniels: > > > It should be > > easy for Graham to fix this before applying. Oops, I didn't notice. But yes, it will be. > That is strange! I'm using Mac OS X/Ubuntu (Lilydev in > Virtual

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Patrick Schmidt
Am 04.03.2011 um 19:14 schrieb Trevor Daniels: > Patrick Schmidt wrote Friday, March 04, 2011 4:17 PM >> >>> Hmm, it doesn't apply for me. Could you do a git pull -r , and then >>> try making the patch again? >>> >> Sorry for that. Don't know what I'm doing wrong. How about this one? > > The

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Trevor Daniels
Patrick Schmidt wrote Friday, March 04, 2011 4:17 PM Hmm, it doesn't apply for me. Could you do a git pull -r , and then try making the patch again? Sorry for that. Don't know what I'm doing wrong. How about this one? The problem is the line endings. They are DOS but should be Unix in pa

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Patrick Schmidt
> Hmm, it doesn't apply for me. Could you do a git pull -r , and then > try making the patch again? > Sorry for that. Don't know what I'm doing wrong. How about this one? Cheers, patrick > Cheers, > - Graham -- GMX DSL Doppel-Flat ab 19,99 Euro/mtl.! Jetzt mit gratis Handy-Flat! http://port

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread Graham Percival
On 3/4/11, Patrick Schmidt wrote: > Thanks for your help! Hmm, it doesn't apply for me. Could you do a git pull -r , and then try making the patch again? Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mai

Re: Doc: harmonics and slides (issue4186049)

2011-03-04 Thread percival . music . ca
Looks good, and there's no complaints. Could you send me the full patch for pushing? http://codereview.appspot.com/4186049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread Patrick Schmidt
Am 28.02.2011 um 22:14 schrieb James Lowe: > Patrick > > -Original Message- > From: > Reply-To: , , > , , lilypond-devel > , > Date: Mon, 28 Feb 2011 21:00:15 + > To: , , > > Cc: , lilypond-devel > > Subject: Re: Doc: harmonics and slides

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread James Lowe
Patrick -Original Message- From: Reply-To: , , , , lilypond-devel , Date: Mon, 28 Feb 2011 21:00:15 + To: , , Cc: , lilypond-devel Subject: Re: Doc: harmonics and slides (issue4186049) >BTW I accidentally created another issue number (4245047). Sorry for >that. How can I

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread p . l . schmidt
Hi all, here is a revised patch. I hope everything is ok now. I don't know why two files I did not alter are part of this patch: hymn-template.ly and partcombine-and-autobeamoff.ly. BTW I accidentally created another issue number (4245047). Sorry for that. How can I delete it? Thanks for your h

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread Patrick Schmidt
Am 28.02.2011 um 14:21 schrieb pkx1...@gmail.com: > One comment. > > Thanks for your time. > > > http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely > File Documentation/notation/fretted-strings.itely (right): > > http://codereview.appspot.com/4186049/

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread tdanielsmusic
LGTM. Just one trivial nitpick. http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode389 Documen

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread pkx166h
One comment. Thanks for your time. http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode427 Doc

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread percival . music . ca
LGTM http://codereview.appspot.com/4186049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread p . l . schmidt
Is it ok, now? Thanks, patrick http://codereview.appspot.com/4186049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread percival . music . ca
I had to run scripts/makelsr.py before I could compile this patch. Please do the same, then do: git add Documentation/snippets/*.ly git commit . and upload a new patch. Other than that, LGTM. http://codereview.appspot.com/4186049/ ___ lilypond-

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread p . l . schmidt
Reviewers: Graham Percival, Message: Hi Graham, here is a revised patch. Cheers, patrick Description: harmonics and slides new patch # This will displayed on the codereview site. harmonics-and-slides-V include file for chord glissando harmonics-and-slides-IV new snippets harmonic